From nobody Tue Feb 10 05:43:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1770645181; cv=none; d=zohomail.com; s=zohoarc; b=eOA4F4jojx43eHJCdVx5lr0xSZT2AnoduN0yt189gWOjfgqReEir4+tyu+0FNhhKbaJzfl6XtUMaaweXiCVTEp9tEhhCPRVI2hTDPhz7Hie4DmaZSXTWlooT7oxexJvzdB0SiDzwZi1BhYe2K58JB32uT0+x3yCZO24bVBk23n8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770645181; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=tTs7ftxHlTMwhcRlMSR5PsXmuvuImo4zdw7vDZb7JTA=; b=KZA5CvHm3ED3VH4EXH6L+/707Q2/1aq/S/zV4M1XivmS48YIg6vTeipP7he99QdXjeQc7mrw0v5lhtXjkT1EDPXCCYy1hxSa2gmsyIaWSwa3BvydM2PDmp6rGvun096TrNtBJtB+Mmn5xoJI5KbQdgbG+Mqd9J04bXQChPcYq8o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1770645181293375.435463832041; Mon, 9 Feb 2026 05:53:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6FD5C41C1A; Mon, 9 Feb 2026 08:53:00 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 00EFF43E0C; Mon, 9 Feb 2026 08:47:35 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 48BB93F840; Mon, 9 Feb 2026 08:47:23 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C56D741965 for ; Mon, 9 Feb 2026 08:47:22 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-V8lSWFAIMB-aRlrhGqaEyQ-1; Mon, 09 Feb 2026 08:47:20 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D5B81955F12 for ; Mon, 9 Feb 2026 13:47:20 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.226.251]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 44E1C1956056 for ; Mon, 9 Feb 2026 13:47:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770644842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tTs7ftxHlTMwhcRlMSR5PsXmuvuImo4zdw7vDZb7JTA=; b=RZb4RMjHGbV5yzhkosuwjRIYYsCNSpeu9lt87HxNoRYCml2YiZsnWmME7ky7eqtTjiCJdB PXAL3OvubU9KgYxqWBIiBFL5murtQwmw/q38ZxfaHg6xStyVK7dkgaB11Vj6wgXOg+ONn8 QIEXRmEDySPt0U4RK2nhP8uBZzRHWh8= X-MC-Unique: V8lSWFAIMB-aRlrhGqaEyQ-1 X-Mimecast-MFC-AGG-ID: V8lSWFAIMB-aRlrhGqaEyQ_1770644840 To: devel@lists.libvirt.org Subject: [PATCH v2 03/38] qemu_firmware: Improve matching when loader.type is absent Date: Mon, 9 Feb 2026 14:46:37 +0100 Message-ID: <20260209134712.296670-4-abologna@redhat.com> In-Reply-To: <20260209134712.296670-1-abologna@redhat.com> References: <20260209134712.296670-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: csZfqTMic84jzMMErer7gEPHpRLoG5RKO-AzST1vzug_1770644840 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EI2HO5CHDJTRSFQPTFCBGEFZ56IX54N5 X-Message-ID-Hash: EI2HO5CHDJTRSFQPTFCBGEFZ56IX54N5 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1770645183686158500 Content-Type: text/plain; charset="utf-8"; x-default="true" Right now we don't allow any match in that scenario, but really if a specific type hasn't been requested it means that any type is considered acceptable and we should allow matching against both UEFI and BIOS. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_firmware.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index e0e6a3a557..1d414da601 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1104,16 +1104,17 @@ qemuFirmwareMatchDomain(const virDomainDef *def, * not present, we can still infer this information from * other factors. Specifically, the pflash loader type is * only used for UEFI, while the rom loader type can be used - * both for UEFI and BIOS */ + * both for UEFI and BIOS. If the loader type has not been + * specified, we keep our options open */ switch (loader->type) { case VIR_DOMAIN_LOADER_TYPE_PFLASH: wantUEFI =3D true; break; case VIR_DOMAIN_LOADER_TYPE_ROM: + case VIR_DOMAIN_LOADER_TYPE_NONE: wantUEFI =3D true; wantBIOS =3D true; break; - case VIR_DOMAIN_LOADER_TYPE_NONE: case VIR_DOMAIN_LOADER_TYPE_LAST: default: break; --=20 2.53.0