From nobody Sat Feb 7 07:30:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=flant.com ARC-Seal: i=1; a=rsa-sha256; t=1770229675; cv=none; d=zohomail.com; s=zohoarc; b=F7oPsUwWehbqhXRcD3Sy6VNJornVuPQvXPS8deZDPRNfqDOBOLtxUGH2QY7S+bonRkqS/3Q1iqi2DBFDczUm8dZbNcsr3owlrZYz82ah4Ux6icPSRl+6Ma/hgzVylcrT/d39FgzfdpUduxXXOzM1Z4IuYnpOfjxyNzAM99Gg4zs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770229675; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=tG08PjZGmLRwZNiEHgghhwCzGnZm0HP8wZLTRuPrCm0=; b=fxz0KGyUxBtzsLN96Gkh6BwODfYXYhpAORGHv2wwh8g0jiW1KxKpMAjA5Kj6GB1Bjo9pz9gdTL/WZDH3X29dfTmrX427quMf3Wzq/rOTZKBo7EdKhfSy0jZk/7lKx9a+xgyY49FR+PQ/MZe3Qn1FOBQ7Dr4VVY1wW9yvtIU7YpE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1770229673750662.6245995103941; Wed, 4 Feb 2026 10:27:53 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A182F41A97; Wed, 4 Feb 2026 13:27:52 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5D6A541B22; Wed, 4 Feb 2026 13:27:18 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id BF025417CB; Wed, 4 Feb 2026 13:27:12 -0500 (EST) Received: from forward100a.mail.yandex.net (forward100a.mail.yandex.net [178.154.239.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1C9E23F943 for ; Wed, 4 Feb 2026 13:27:09 -0500 (EST) Received: from mail-nwsmtp-smtp-production-main-68.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-68.vla.yp-c.yandex.net [IPv6:2a02:6b8:c18:3e07:0:640:a874:0]) by forward100a.mail.yandex.net (Yandex) with ESMTPS id D3FBEC0189; Wed, 04 Feb 2026 21:26:56 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-68.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id YQuPFJCHqCg0-cg0Pvghz; Wed, 04 Feb 2026 21:26:56 +0300 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flant.com; s=mail; t=1770229616; bh=tG08PjZGmLRwZNiEHgghhwCzGnZm0HP8wZLTRuPrCm0=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=hyVveVU2sYblrBjMQJy1LCUA+kd18rTm9+FvfBxD4tF+KQzcc9/fhXSrZv5bt4Kfs 497nG15zQ9oKUeG3+QwMKeeYsjZrNCQ84jHx1Se4coNYSATV8+BX/TovX48Z6vf5Au 9ksj6WpDxDnYR930PDs+waAjBEygZQzL6BBYeAl0= Authentication-Results: mail-nwsmtp-smtp-production-main-68.vla.yp-c.yandex.net; dkim=pass header.i=@flant.com From: Dmitry Lopatin To: Tomko Subject: [PATCH v2] virt-aa-helper: Fix unchecked return value Date: Wed, 4 Feb 2026 21:26:31 +0300 Message-Id: <20260204182631.348040-1-dmitry.lopatin@flant.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LE6ZRT6IO5G4EIE6Y7UY2RC6HJHDCFCV X-Message-ID-Hash: LE6ZRT6IO5G4EIE6Y7UY2RC6HJHDCFCV X-MailFrom: dmitry.lopatin@flant.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@lists.libvirt.org, Dmitry Lopatin X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @flant.com) X-ZM-MESSAGEID: 1770229678700158500 Content-Type: text/plain; charset="utf-8" - virDriverLoadModule() call when loading the storage driver (line 908) was not checked, while there are examples with return code check throughout the code. --- src/security/virt-aa-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f4ec6b7826..2de1b31b5a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -892,7 +892,8 @@ get_files(vahControl * ctl) =20 /* load the storage driver so that backing store can be accessed */ #ifdef WITH_STORAGE - virDriverLoadModule("storage", "storageRegister", false); + if (virDriverLoadModule("storage", "storageRegister", false) < 0) + goto cleanup;("storage", "storageRegister", false); #endif =20 for (i =3D 0; i < ctl->def->ndisks; i++) { --=20 2.34.1