From nobody Mon Feb 2 07:26:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass(p=none dis=none) header.from=cyberus-technology.de ARC-Seal: i=2; a=rsa-sha256; t=1767958249; cv=pass; d=zohomail.com; s=zohoarc; b=dvt7qBpDp4hCpI8RExMK+zV/TCBBpUkdAtQMwbygqaDiXOnwzYbpSE7Aykij73YRjUfjXScMBevkRzyn4y/PfkLx4CQX06Q12IQxUUdSjy4rMlXEA+3EZug0/jvvMA8yS82m02hxuhMmDY2qFhzrSbg4DDv8plIc8WmApu3mGIo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767958249; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=nDfmWrzsDLP/iBGhWJOkGRmJ7SDToP2ormjYz1D9Tww=; b=kPLMN2CA1vT1G3ee9UFLlFr2Yoe39t+ktqzVyMyKibG2WzAkEwysdTgaGzksokMv+f+JDBfJhvdAz7qRrUSyfgzs+4bnMh0lVDNi5/ilOuEb9HzQFOyis9EsISD1QfZtBopVvnGM5o3srLL9d+xA9RZO3zZrIiRtZRrxYdhQFDI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767958247999873.0449728746071; Fri, 9 Jan 2026 03:30:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id E650243FE8; Fri, 9 Jan 2026 06:30:46 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 7D0A1440C2; Fri, 9 Jan 2026 06:30:00 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 2B66741CB0; Thu, 8 Jan 2026 09:03:19 -0500 (EST) Received: from FR4P281CU032.outbound.protection.outlook.com (mail-germanywestcentralazon11022131.outbound.protection.outlook.com [40.107.149.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 380973F89E for ; Thu, 8 Jan 2026 09:03:17 -0500 (EST) Received: from BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:52::6) by FR4P281MB4580.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:144::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.3; Thu, 8 Jan 2026 14:03:10 +0000 Received: from BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM ([fe80::31a2:949d:fb59:ef58]) by BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM ([fe80::31a2:949d:fb59:ef58%3]) with mapi id 15.20.9499.003; Thu, 8 Jan 2026 14:03:10 +0000 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PW+/AS5ZcRfF316nUm05F43Qj5PZFlSIPcN78NQudIbJ1CN+p+SOgXWuLE29l9JsuKAwSV4y0xxKbZzYjYbWUWbDvsx/MiwGYEmxp2U8ReGN74Of0z/YXGQuS0+zf0BUKrrNADpDwiisb8raXGX5C6e2hrq1jDkL1JccRwGL1aHU51j076VmUqh91/vp84o8EYpx1mu4NW89kOmeF6ki6fuObz1jKnJKlTVDKpIk0MZVHOWMv0ZPaISqWcYEfrZ2ORxkgWe+wXWijzA1Q/3bjYluDEghTeLOKTDL1aY7l2+IolHWWGJOkpZwGvylrlDADyxhf5XMPjYJrJd0UPTpag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nDfmWrzsDLP/iBGhWJOkGRmJ7SDToP2ormjYz1D9Tww=; b=vm1Lr6cE/v/GviqJgJXT4nG4B3GGUYn4hS6/8hSdh8CEhQHxPCyjP8lDBxbt+TuNFteAOlMQVkOJ7HcKttvg9Nr5QDDIAEooIYMgmuNKSuhR/O5GyKeNVGEFROJFB8VLpPCJzNp4t988eKjytmAlXl90YiHM9o6v132QZRg0se9/UqI406LlBQtQC/xjxUUEDmGImW7FwHAd3zyAv2CVEJN9FRmAfu0R4KNkJzZFmqMleLebgRKOCvG302daCzSVxCeCfCP0ddf2Eh/0jE9/AmvDzP5TPkT3eneNkkTJZwUH7Nj0jQpZplrL1e0lG4VhdNEmHO4NjIION5e9dUl9xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cyberus-technology.de; dmarc=pass action=none header.from=cyberus-technology.de; dkim=pass header.d=cyberus-technology.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyberus-technology.de; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDfmWrzsDLP/iBGhWJOkGRmJ7SDToP2ormjYz1D9Tww=; b=wJyGjzxyymF2mNFQMh24GkWQ/teFCvp/GkuanWszIDIYdi5kdbaSfa7zBdMKl8pb5BhMU6YlBDpsiVwcXGoaxqDTehjSSxF4sxn2aTEk51HREaSl8l93NcdnSMn0jii25skNkGN+JiP+VPuaxMeEmysjbmgKnXOVMuLhRX8p31CtKtoN5ipPNQVJuAzcNHowcw03lt4T+F6ER/cnw28vOxg3EWt6K5STC9T9IjKnbkxP6fK07cd3la7Doh3vBSX5iAiRBiZZ5S3YeS5yb4tGhu6WesGyU06Y1d3M/x8zm01DzSov1Iih2xOukp/SZaMlEjnTz3i22wqRkP7//mMJZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cyberus-technology.de; From: Thomas Prescher To: devel@lists.libvirt.org Subject: [PATCH v2] qemu: fix locking in qemuProcessHandleMemoryFailure Date: Thu, 8 Jan 2026 15:03:03 +0100 Message-ID: <20260108140303.165678-1-thomas.prescher@cyberus-technology.de> X-Mailer: git-send-email 2.52.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::16) To BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:52::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BEZP281MB2149:EE_|FR4P281MB4580:EE_ X-MS-Office365-Filtering-Correlation-Id: 2745abf8-816a-43d5-7f53-08de4ebea807 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?E+mOmHo6IZDcy+BzxVIGay+xhCp+BuHEj3gCs0rAHrFIqhZsx4fPPanza3Ts?= =?us-ascii?Q?DLK9VcbEm1D4R4rZQo7fSMMrPMvckobiifuP6OR87M+AnGSbpZDjVsFgCcyA?= =?us-ascii?Q?Ul3JjyA1US6Chi7DbBE2qLZ/q4U8BsVtYhzNJorULkS5XtNs6FCAks+RrqoU?= =?us-ascii?Q?10sB5cT6pBMSQE6eTeWG/kqgU0ZRO78/0AYN4BObpMS3AN8C4u0K887racvO?= =?us-ascii?Q?ECuWZFqBOUgTEI1Yje92mrT+6M6x0OG/e7/RZU61J7f64vQbqp8azg9DQiyc?= =?us-ascii?Q?U6Mi9EPm+++4tWcXBC4NSHjbWrWJyQhLgfaG5Nx0u6k0RmcH/LXe2Tnowbz1?= =?us-ascii?Q?Kv1R/pb6iBZQCbAWXZdsAQtP1XDNwRbKc27za6kr4Im+axpKnbfk7LLOKm5D?= =?us-ascii?Q?0nphmRCBZfrsWwv+gLepWLuPIdIff33iZUiEUn3TkztxgxQ7JMSViDE4ZrqK?= =?us-ascii?Q?n2dmb5FiSGodT+cnvjGE40sNZq6tQ3e9VyrmyQ6kIBo/MGV1etQoDcbPnYiI?= =?us-ascii?Q?Gs3NcRTkRpaO+bmBCatmbfkZWSfP/u4nzMEk7eahHnLKdhp/N7oAyRiQjXmI?= =?us-ascii?Q?qeZAS5zcNA2SPTwPK4GIQxKzKyxRYseZHD1TDPfhN68v+LDoaJSZyNuiMDwM?= =?us-ascii?Q?sp3Ktvs1UlKTm2ZbXTZ53VCzJ3oeQLmx8U8VE1WAK4On7DyIdsMqJsi/yLN1?= =?us-ascii?Q?fU3W9Xx0rzs/0floFKmWRL5LVqMDM4KIzgvI16CE+YgQDWJWXjXv9be4rw+j?= =?us-ascii?Q?NCDRjFWFdniMqTp/p+Vk+YfH+inX384eBqWgQc+So/DQcBYhWshe+K4Hr3VV?= =?us-ascii?Q?iTir4aESCPrN2PFEl3kvxs/DuV3hhDRQIcpPbadHuQrfh8El5MSdQ+YJInYY?= =?us-ascii?Q?omfB9kB2yXZVzlN6NgSJv5QE69WlfCMlDM9RGy4jtLn3O9PV8iKF/MMr+vfA?= =?us-ascii?Q?3c0Y0PPOkm9hxRgoCKWq5A7GszneIL8h6PujleuYQZLErjy4M9qyH/9DGbbo?= =?us-ascii?Q?E8BTR2rMehGLv5YXQYNApkaReQQ02uJPD/q/NBm4vLR2o1Cq0d7AAkKGiz2E?= =?us-ascii?Q?sdFvuI2vs5sbYEQpbWSpF6ag1PdAM342M0zjMFj521yGLPXIPcOvK0ACgf2e?= =?us-ascii?Q?RLvp5hTZaKnwSeY0rJL9a5n+tO3pQ+wE+uFC3wglIRvl1OMxEWXun8oghwBR?= =?us-ascii?Q?k85NEwEgHoh2QICL6TkLX6aaOBybQIq0HRt8fz+4hcoBdFzDZWSXH0kfVeqt?= =?us-ascii?Q?sYPSVeBNs387QHVmqS/zXL+1Oh+Ro0x836OLk0uaBl6m4cAinyNl+LX+2t29?= =?us-ascii?Q?vSz2Q3SlvbNDR5HxJfeXOwJs5XuOxfvSogUfRPJX7vHFS+DY1iymffal3E9W?= =?us-ascii?Q?Ir5y/u/hCLwpBtj87Bx8p3mmsoeyV0wMgcPdahBVq41uD0aV4hXRp4cxVf1/?= =?us-ascii?Q?EjrsDDC/VmXfF0ipv5eDI55r5F76Rapo?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n65DPckZAQO8AAWNPQWMbZ2WPiN7JGf6CZfCiTXiurJl7S46z5DuQytGPSu0?= =?us-ascii?Q?kI1tscaTX+NorZaSnryREXLziZRxOiKgdR3pOXKqskVkEegZQJVyW8ZVlMht?= =?us-ascii?Q?6vKerOYoiXAsYZIqcEyIcBfmqBAcWXxBsKMu0OOt9I/ArNl5Y9TtdHLOEWBg?= =?us-ascii?Q?HRxgSqXmF/8sWgWsb0RlQ7ImihcOa3SO5vw6ObQKpCWNmyjnKFxPgBHEBWnm?= =?us-ascii?Q?Cuf0W3iNdNclYowkAlu6IHqgxRmiCkhQhfdtPbefEqEaydF1opyBp46iFPxc?= =?us-ascii?Q?zgZ/xow/VLQg3S4FNdrEIpvJcQLYc1034gDhtj8k5diF+CTpdFyTXFe4el9d?= =?us-ascii?Q?0LZ2D14VVOLCAp7vh4qbKuymikZrZtvygRJPHzP/sIsg9UGUqE92mQJwO1xG?= =?us-ascii?Q?FAAZGdcA2ChsuMbdNAy1ayazpdg3nrSUzoFHgRQhJBJnYyHThoqnAL/5Kb8c?= =?us-ascii?Q?vOnfbNKMYFvI1CJD+Md0LEvyosJjEnZwA3Ib9BVzasZJcu0vom2tZ5OEum7g?= =?us-ascii?Q?QTtoDuEW+a76/W9WoHs2FsWzl5eSxihxopQDRZNmQeyRjJzmeVLZ+Slww4kL?= =?us-ascii?Q?bUkN8FI9VRqn3GJYzuhgiJJXcDrIG7aPC/Kb7uxCWG5TlNKXDx+ZKt6mcD7p?= =?us-ascii?Q?vimhgNHMKFNy+E/kLGs8VaeqxtJ9sI/ceOs+c2ZHZKb62mqIhoDUjlG4fP3U?= =?us-ascii?Q?miWTjOyyMK7D2UqN8AAAUXNlwcU91QlF7b6qp+4OxutUrs7lGfG9/LzdLvvK?= =?us-ascii?Q?ODVoSHqfEOBrRrbnizrTEGMOrngDUfquNu/RhDCWK/hBDN5lgVOYbpxQY74+?= =?us-ascii?Q?EX9RHRTgAhs/fyMTia2I0e5Xuf/iab3KqX4OAQy7c0Dez9TxpWAglFYqnWlI?= =?us-ascii?Q?TgwnoIF9bEzlgW/RcCNJsknMoJhq9y1WsD5I36BHSuwCVlI3L9Z2AHiJ+63g?= =?us-ascii?Q?KE7EQclOI68wU5BHwmHPjTYHzvLjrvybP/MYvEo0VRI06tr/T4FEu/VIQwSL?= =?us-ascii?Q?REl1Q1n4o1EP+LNPS7hVeTLhzir9Bz0mdZ8ZAfoewwYBjxC1BOIeNbY2UNos?= =?us-ascii?Q?RAYrzmQLO0SAFVBKYBOOxi4uldaI3JvfzhSj79ojUNg8c8mzzSUuUIzfPjuf?= =?us-ascii?Q?xkzowFbjjo41FIXHmrxZSTY7kLagMKwDoP6m6kn+5UulMp4H1bAWijIJcYIm?= =?us-ascii?Q?8HzJMlcazuwOY7fz6q4lJRJzySC1c5OjQW+wGIfe07cY/BzgvVhE7xoQIWBy?= =?us-ascii?Q?wwGygY1fCbGy3JzcPYyFnZQJrNhsmaf07jD17h61yfRKoiI7NkwjYr30GCaV?= =?us-ascii?Q?vQskAoInGAW8G0PQzHjrkTSCBYMyEYZalIspaa0xSOYfW5k/RF8l50lUE5aE?= =?us-ascii?Q?ZDt8oY2Qo9Y8/GJHjSVnCDCtSCOoGcQ/Oc/ClJcSJOQvAS6u5oxRLTwk130K?= =?us-ascii?Q?1UhGX6h2L/SPcb+13KuwC2Y1wNn5/GBTKa6QSaGpNu2xv9/HHooDZDtkbo8h?= =?us-ascii?Q?zfxeRtexQKPZ8F7SsOu8GjrT2JH/V/C49Vbx+ywwURuFAcyKmXqGFClz7HtB?= =?us-ascii?Q?z3F4ccv10oNlFTll8172Ul/Bnem0iLk/Xhs2ptWNecuepKQdnEAuE4YdDbe+?= =?us-ascii?Q?lT3+aD3ooYKCyvSgbU6H8BQWX9HzPcZHpqgf4sm5S9SXbs5mwnulaB0UZ2Qb?= =?us-ascii?Q?sR7SmHYyL1rztcL8p1AuO+ly1JuTcWRnTI1oQeP623oC+QLEcHNPgVhtVJGx?= =?us-ascii?Q?UuoraURN8ToeAT9WS0U1+4J5av7PAjliqbuyrScJEdxTo3IgBfmf?= X-OriginatorOrg: cyberus-technology.de X-MS-Exchange-CrossTenant-Network-Message-Id: 2745abf8-816a-43d5-7f53-08de4ebea807 X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2026 14:03:10.4919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L3Gi4q34Aa0l/kuZ/vtGmPgszTrUeAst4nwBdMOOBy2J4PjXWORSbv5RKsuaaddQSJpWv7go9OwRLhZ7nSyfIOPMzvea22aZx4xxGlqmmTDeXRJI1tOoYcjbLwXjUCJT X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR4P281MB4580 X-MailFrom: thomas.prescher@cyberus-technology.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: OR756DR7ZR2NEUILQ6W4VN2FX2JRFMTH X-Message-ID-Hash: OR756DR7ZR2NEUILQ6W4VN2FX2JRFMTH X-Mailman-Approved-At: Fri, 09 Jan 2026 11:29:54 +0000 CC: thomas.prescher@cyberus-technology.de X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @cyberus-technology.de) X-ZM-MESSAGEID: 1767958251489158500 Content-Type: text/plain; charset="utf-8" Fix locking in qemuProcessHandleMemoryFailure. We use a lock guard now because we can directly return from the default switch cases. Issue has been discovered by johannes.kulik@sap.com On-behalf-of: SAP thomas.prescher@sap.com Signed-off-by: Thomas Prescher --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4e1d713809..a53bb40783 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1939,8 +1939,8 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, virDomainMemoryFailureRecipientType recipient; virDomainMemoryFailureActionType action; unsigned int flags =3D 0; + VIR_LOCK_GUARD lock =3D virObjectLockGuard(vm); =20 - virObjectLock(vm); driver =3D QEMU_DOMAIN_PRIVATE(vm)->driver; =20 switch (mfp->recipient) { @@ -1980,8 +1980,6 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, =20 event =3D virDomainEventMemoryFailureNewFromObj(vm, recipient, action,= flags); =20 - virObjectUnlock(vm); - virObjectEventStateQueue(driver->domainEventState, event); } =20 --=20 2.52.0