From nobody Mon Feb 2 07:30:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass(p=none dis=none) header.from=cyberus-technology.de ARC-Seal: i=2; a=rsa-sha256; t=1767797005; cv=pass; d=zohomail.com; s=zohoarc; b=bYU/C/68lWj/ohLw82i/IKaX0qgvWIa/YBRYSSOJ45y7TMGtriesU6M/HQmlQCeu6/dfCnlzGWwwgXUogqSR3utNhTpLImgwkPyjigTCkH7Hm6TvzefusmJyc8mZHYC5YFCTXbE4/iCOmH/dTqrfBuCFMUNAJB5CnBuhv8wHs2E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767797005; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=yLcROVxvS9tjBVxplB9fDorxuhZOnNWgf7MPosEGKIo=; b=RVbpdV7JR1bRdwC9WsUrfTDyzuMEdq1FwLn8N1zvEKgVqRGkliCGakKL75TvHmAv6Mg9gq85JxkEkh0I1q1rEIUIhvKtncDJGxeM/h4I2UFArdp8oIOzVEIfZxetl3AWp6ZzpNa3xTgUa7ALY6JJfkqsNy+przwDiOhLcRPSlrg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767797004805573.5529871116755; Wed, 7 Jan 2026 06:43:24 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1812C43F63; Wed, 7 Jan 2026 09:43:24 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 38C8544039; Wed, 7 Jan 2026 09:42:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DA48543F43; Wed, 7 Jan 2026 09:38:50 -0500 (EST) Received: from FR5P281CU006.outbound.protection.outlook.com (mail-germanywestcentralazon11022116.outbound.protection.outlook.com [40.107.149.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EBD8243F2D for ; Wed, 7 Jan 2026 09:38:49 -0500 (EST) Received: from BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:52::6) by FR6P281MB3824.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:110::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.2; Wed, 7 Jan 2026 14:38:45 +0000 Received: from BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM ([fe80::31a2:949d:fb59:ef58]) by BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM ([fe80::31a2:949d:fb59:ef58%3]) with mapi id 15.20.9499.002; Wed, 7 Jan 2026 14:38:44 +0000 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tEDLqe0+dIVcOonZ8a+021eAaPRm7KSIu6QcqRsfuvpmYzFI5B/xbYj3s3JBefsU8yfKj+voCFBhJjGnGLqZGAwz5gk5X6RvtprYhlWXGKCqcf+fY1c7W1Ym7YO5VKMwb/RsxBtmxF/Al3CuOUK/j8PKS2ouVhwtbRaOhqvtFjEVK/7SGsRijDE3GlpiPYVStT3Erf4q+ErwzysP4fFafGBmBtJLBbxA26M6I2QqIiG2F3U31qkDC++6m4RjCi5h3bo/XwbhFYRsT3Du++7JOnBvRNWYEgSUArIksiQSoKXrpTElU8AVcs99ll8oxUy6XHuFMm76T8JM9Y4gzjBxSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLcROVxvS9tjBVxplB9fDorxuhZOnNWgf7MPosEGKIo=; b=ODWV9mBMh/ZXEwjCtrurpSl5sh0YgyG6bJuaEooI7nieTjIUzj0kYLtlS4WgbM+yhd0wtwJ8YDpPlDIEDrFfewlaPllCu2fIdWgshVlPfzL68V9PiAHKo+soF7IKqlLSIgorsoNHVVITB/qUGDDtu37XO7ZWlBMjv/lw3dqqeEgsPZtYjXwHJYYQmau2MsYGBEDE17S2p0nd2TS2+nKTDT65/8DfRW/HrD8EXwhBmNhbU+CKNg9QQyTN8+6cISYj5oEtIw1kpcieCHsYSLLObDUD01RJlnDXd2FygVbIMRUSZmBG/QCiqy+jiPkmV/AfCzbCYVI0BueUxM8sTY1fUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cyberus-technology.de; dmarc=pass action=none header.from=cyberus-technology.de; dkim=pass header.d=cyberus-technology.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyberus-technology.de; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLcROVxvS9tjBVxplB9fDorxuhZOnNWgf7MPosEGKIo=; b=r90cjbio2ftoTo0bjbdR5zZ7lMoKng0bwQgycsq2JDp4lVR+qKehzLk5jJeF/mRrQubm6dX0PKcLZxcx7T7qV6J5KmFhZmSJkAW8dJsc7AdM2C2zlUpVAX88UTGETjmWBCTGJNaHeqUXqafI2HvwpqaPzLYtdT4NvZ7MVg7ifXoxGx8YEBpeevEn7ascX6FUWJY4tsW+pRKroSDdI15RoUq8hKIsduwrFRhDqmq1wpccrxwvKasAB7B4JDSYxtl8boA0dNWw9FvOHrlTSGLRibNQ/COUIC+ux3C/kIAcan8Vxo5FJPIjRWO8ywaRP5UzHU1hQe2lwqAn6OQ24ktzzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cyberus-technology.de; From: Thomas Prescher To: devel@lists.libvirt.org Subject: [PATCH] qemu: fix locking in qemuProcessHandleMemoryFailure Date: Wed, 7 Jan 2026 15:38:37 +0100 Message-ID: <20260107143837.120739-1-thomas.prescher@cyberus-technology.de> X-Mailer: git-send-email 2.52.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0253.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::8) To BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:52::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BEZP281MB2149:EE_|FR6P281MB3824:EE_ X-MS-Office365-Filtering-Correlation-Id: 76401b31-8024-4f37-ec7a-08de4dfa757a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lsEuBh4zFn15+T/VdmC/dPEerEjF6oOREAsoeo5L24bS393e2Bj/WJ+PSl2b?= =?us-ascii?Q?gRvDk3BpdNp7FVq1VSzwcGGBshsjSKqD+5pxj9wv4M9A1D4nYcKiK6ri9O/3?= =?us-ascii?Q?A6EubM1s7HyLPj03EP4sWGP1M8RgyI8u98O63ahKXSqwa79YYgLtsqevFDvc?= =?us-ascii?Q?6LBPKv2lUxiKUJp8U1OqEJ1RDVv99kXpTSnCU7QjyFP+dAoDwuDu7r6tXpfc?= =?us-ascii?Q?2hOju7ztk83emzoefAjlAxukb8Skw2N10TOSKd+BlpZF7OV1z/t9HkId1x98?= =?us-ascii?Q?6gYA5MWs5I/I57iV0b23K9hq5YZbAGsU70Y5p+j6Ikd8WR6ZP4zvAqPaaopN?= =?us-ascii?Q?2ZhXBe7fGzu6Y3GtRitcIo3+VGwGWoKs9cs/CJPLC+fr0KLbT7ZyIAxO33Ay?= =?us-ascii?Q?2sbDe3CokkWGgvold2JodcAGkuLjcvibX/INYCVG0M39cqNPOcgTXJJzyWMv?= =?us-ascii?Q?QdXplLrCCJ+ft7UGv6B8M543MwddHxv4aOTBe+AtacrMIbqzAgUzqqqT3i1d?= =?us-ascii?Q?rMyV3L8J/kDebNmVfTAHelnUefr6YzDZj45pYh26LhJ6+3z2FKSU0r+6ZW3b?= =?us-ascii?Q?eh9gWDAvzNOpbLz4q6VAY5Ax3xv3PyaI+2/VdAnAw2suZjKkjvHpAE7hpOnI?= =?us-ascii?Q?UMmUJUAdYKcRNqgecwgDgbTrCwNuVDAh/Kk/uRIVVUaqZ0w/RZkkRxX1x4C9?= =?us-ascii?Q?2Nam4yvqIQTsl7WDLuTCJGytwFsSvivtLJZBi90uiVViyd11gpL6jWpz73bV?= =?us-ascii?Q?adiIZxqWryufnplQsY3NJ+gfb1Swt99t7zclUMqne+RJzUscLAsCJyFchPcR?= =?us-ascii?Q?lmImrxplQ50Z9unLSyM76LXUthZs1Q/piM4VGiNlyqRVx4hvJjjPnooirN2T?= =?us-ascii?Q?XtqKC8IkpdKucSakHcdL36CFwh8VWQraBlfab9fHwr+6fGkeKI9/inurAooa?= =?us-ascii?Q?WSQ2OAaF5NSZ3ArSeqvx1TP/JL73OFe/vREnn+cjbd+vyyp929y9qUEAw/WS?= =?us-ascii?Q?Je5yAQLhqzqL37V0lydtfxW7scpW5PqKP9PrJLTAvdNBxljbleT20g9zhUgc?= =?us-ascii?Q?YnNN0AJykq9FR0aeo6HhKJZXNunvkyLyYhFe2AhwRsOudwyGugnebDXReeJK?= =?us-ascii?Q?7j5y+I7Vj8hNNtEOAho4b18VGskn53tlkakqyHSJX8iBQcZJ89zk1Qn7Dn3/?= =?us-ascii?Q?yY+u/hMzuu4/ABZBO2wekTUDNIQxvxJP35xWD+hXlXcWQ/MUIzyPOseer6fp?= =?us-ascii?Q?BGHlmVW9KZG9fogfm6NwGKdx8zdjcJW8R1V8P9+elTZ0ogMaV3JZot8b73+U?= =?us-ascii?Q?ailVB2+ClZi3iayvJNkOX7VKGfkm4YjwoDU254xrk8iIh8WRq8BG8RXi7dlC?= =?us-ascii?Q?0kDRdH0TWKjc7VV0SFlaMop3pY9ssV7gvrPu7rB5UxnLaJgFh+BHYwmu6pDl?= =?us-ascii?Q?/reDhvY5zQTa5uZGb4if5j6lW3Av6Aog?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sjSeJDxNQmd/ggkbnpLJY5Qp3aHOwDzsSaHeP03zXr1Y4GgqoEGyxx12ZqgL?= =?us-ascii?Q?lyPdAvwwiyxK2/LxUxnOkykciyWzoEgZ2niY50q48zZr0I2H++9RqCi2Btlm?= =?us-ascii?Q?c0MY40S146y/G7mII4kQ1Lln4NmfSdeB8kfv9q84Xk8oSYwCcIbxpnZyf0oA?= =?us-ascii?Q?JLJAMCZoeIVCQ2FwADoslfQExIX1A1XGcCBCooN6fEm59Yz0bEJoUyG7EF5y?= =?us-ascii?Q?3/1aYivZ9ORKZZ9PgqhZeOmcqCwwu/P5IGfDZLLM14bV2Gb07UFY12HZrZgq?= =?us-ascii?Q?cIA+DR8HdUsd9dqIVh6tlHQ1ctIR4yOftU64T/FHiRaJ5dUOpNG+wdI/3GIV?= =?us-ascii?Q?EU37Jf2NYMeZyyYryktoptWA8eyM05q+Ud1wyHa0273ULj9xLcIDh8H8Fbb6?= =?us-ascii?Q?RBfw8Fvlzj+DtbugeYAANbyO/axthPM6DUEQqBXkM0pvIhvzS6YQwse8i4Ed?= =?us-ascii?Q?0yJ1xJKhzUtN4Rdkmz3B/KZ1ScwulxMtW1SqIbb5HFqqGYBY1AO+FZYwa1Wq?= =?us-ascii?Q?Yz267Jj7a+UCp4037mkpZf7nq29+C+VJDmAa78Aa4AcZOF6flBsS9/wTY/0d?= =?us-ascii?Q?p1iS7fMm2r3ZLapCFWHSd3OEZWFht1VlERmNAQkze0+LheGZ6NFDbUwJIazq?= =?us-ascii?Q?dJjuDq6BYw/eH0eLGevXXODZsbagzt/5PAYD3kAjo5vqZicnpwMNt8M0vEYD?= =?us-ascii?Q?Hzmz5zPuUjyf2cX5BMYTTe18imUg0OmM7g/NqVezdgpgfrAKdOd4HxkN8XbA?= =?us-ascii?Q?eZ9wIa8NkXAul34hWrBhJzvOb0uU8DoZg4h5adJfTD7O6fGLZEU7JIochKaW?= =?us-ascii?Q?j4wuaHQjho4dob80mV9bIS0lcaem5fRWm2mOy2IP3ZAwEwfjkfJyFzc+Bky+?= =?us-ascii?Q?CvX7OcRbBs66n6LhXzEKfvJxGEQ1PLpdaAAWBNOx5sASZy/prz4lO8HOGbRJ?= =?us-ascii?Q?CPpbo2HfOWrMUEihhidfSFWp4zZQb5yST9NJeAmG57P5o1cl+NGEEZQhVzKl?= =?us-ascii?Q?vSd8eR0I6pQ/o3wupVQNFqmg9QUuVwo13TzG9ZAnMDl1cPJEYOgF+LzWNZP3?= =?us-ascii?Q?DL73dVn5dUDzBA66/0PDkP+ll406zBlxtTFPfHCc6akKctQ+2zIBoEhRLFxf?= =?us-ascii?Q?oRqIVKbhFWvl3uI81k1HfrfLXGtHl3HSAKXjRbV+0d7vClGUHmBQ7BVGH1f6?= =?us-ascii?Q?LG6V5DODiLT6UdpssH7RUkk3K/EPIo9WzVUkn1f67rm75p++Z7g9+abwvbBm?= =?us-ascii?Q?rxwGKSNrVTkvGqavRVdL9OUvPm+rNKyfKsA25NGVkoaLaw7t40ENGsXGOqw/?= =?us-ascii?Q?SO4S3qrA65f6TzAUjfzswmePmaRvxWjvVOgHZEjpSF1fcsK4Tv2PocBtlcjp?= =?us-ascii?Q?hwlJRGnJ+Y1nSPvRkS+ANkkiEKKYTq2xvy3zhON++28w4dT+c7pWC5Z6cHwR?= =?us-ascii?Q?YEhET/LeErz0nYPQkPpERSBjDA122FpP6uc9wVnJP5iQnDYFcbrRPhKy/svY?= =?us-ascii?Q?/hKJ3KcWSVKAaly/sbFZQKwFcbAWnx/0x/y9pdK2KGKLDHiS/p3w+Ew0ANya?= =?us-ascii?Q?jnrqesDGsH/DH0A104QqIQDMURjoMEF4TSgdyEYg9WGDsvAtqKgqQeBM4t4v?= =?us-ascii?Q?yXPZgC/CZhtIykXTMfAdXjGa/w21O7efPalCtZsGY1syFMdCNWo+8ILjTh06?= =?us-ascii?Q?+DpeEXhAA22EO51TApiJ+CNOcLobHUlMOF7nU6gBJ2LM6vgZjEjE5knojD96?= =?us-ascii?Q?GgZFAMdC2DTaHUnLFyzhPCkueJqQrOR6pfcEdfFkf8PZFKu/BomXPyrF2/Sz?= X-MS-Exchange-AntiSpam-MessageData-1: x0GN/Tl1A4deYAegfvGPvEcs3re9b2EO7PU= X-OriginatorOrg: cyberus-technology.de X-MS-Exchange-CrossTenant-Network-Message-Id: 76401b31-8024-4f37-ec7a-08de4dfa757a X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB2149.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2026 14:38:44.2355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4HYbE2FHTDqqWLC2SEJ8rGFhwXMq44TKfWkjFl4//nQ6iMABP5hJipL4H0jYnr/ghsfAgApMrSTgZU6W0LFrejdLuqCIapMQNZYdjpnhrhnNcT07w/aw0xFo4csVr/V/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR6P281MB3824 X-MailFrom: thomas.prescher@cyberus-technology.de X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: RUF4OJTRUBZRUGZMVGQSPATRDXU4ES7Y X-Message-ID-Hash: RUF4OJTRUBZRUGZMVGQSPATRDXU4ES7Y X-Mailman-Approved-At: Wed, 07 Jan 2026 14:42:14 +0000 CC: thomas.prescher@cyberus-technology.de X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @cyberus-technology.de) X-ZM-MESSAGEID: 1767797007920158500 Content-Type: text/plain; charset="utf-8" Fix locking in qemuProcessHandleMemoryFailure. We use a lock guard now because we can directly return from the default switch cases. Issue has been discovered by johannes.kulik@sap.com On-behalf-of: SAP thomas.prescher@sap.com Signed-off-by: Thomas Prescher Reviewed-by: Michal Privoznik --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4e1d713809..cc902e1d37 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1940,7 +1940,7 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, virDomainMemoryFailureActionType action; unsigned int flags =3D 0; =20 - virObjectLock(vm); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(vm); driver =3D QEMU_DOMAIN_PRIVATE(vm)->driver; =20 switch (mfp->recipient) { @@ -1980,8 +1980,6 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNU= C_UNUSED, =20 event =3D virDomainEventMemoryFailureNewFromObj(vm, recipient, action,= flags); =20 - virObjectUnlock(vm); - virObjectEventStateQueue(driver->domainEventState, event); } =20 --=20 2.52.0