From nobody Mon Feb 2 07:28:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1767635444; cv=none; d=zohomail.com; s=zohoarc; b=Yd+h8AEutT5qbhCjz3a3xTuoODXfhsMiAq85mkmN/NjVYBwjsM9TD0GMJrXL4Z/2geV4YTtTN5m1RNFZDXrL+47k+FizasEpI+iKxyMC0XM9eWR0gAbnULGJ3YiPbh3idemKGVrOriFlQQKml95ypkdTZirYe55TvR74lYvrXWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767635444; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=WPy75haL4ZVCYJsWccQoZib1yJS6LajDrzcLL6+FggY=; b=Ch9azA6srVotRUSrAxr9bTr8TAOaxQfjNubskaejRRmZ34YykdiPDVPG5zNi0vrDufTpqIJxMCi+wuI5kiKqO6eIjyeucOGbX8syvccwukcrXRN35LgO0ANNbpNupE6+veMdl3mzOtZVkhSXD+JUCwFi5znyv+/RRyViPBbzV5o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767635443971626.2776397303869; Mon, 5 Jan 2026 09:50:43 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id BF4CC419A9; Mon, 5 Jan 2026 12:50:42 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id F1A3D41ABC; Mon, 5 Jan 2026 12:49:41 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DFEF3418B7; Mon, 5 Jan 2026 12:49:33 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 480CF418A9 for ; Mon, 5 Jan 2026 12:49:29 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-_tczbO9tON2-VzZsLU0OTw-1; Mon, 05 Jan 2026 12:49:27 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4A4A180065F for ; Mon, 5 Jan 2026 17:49:26 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.159]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2618F1800579; Mon, 5 Jan 2026 17:49:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767635369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WPy75haL4ZVCYJsWccQoZib1yJS6LajDrzcLL6+FggY=; b=Bs9v68gTYgA8q01r8vXQV0WO06EiuACgUe7QGkuvVOuDmRJXsAYW/cgU96O28JAI4qVjzO 3riR1wc2Xge9tKhlj3N2WzYqdnK5qx/oSGs7ChZ8rUKsL6nYx2rAjZgoMbVptQ9qjipizr Vc4O0nrGuwsOeWsbiVfPR3yW/ZOuWXw= X-MC-Unique: _tczbO9tON2-VzZsLU0OTw-1 X-Mimecast-MFC-AGG-ID: _tczbO9tON2-VzZsLU0OTw_1767635367 To: devel@lists.libvirt.org Subject: [PATCH] tools: check for failure decoding secret base64 value Date: Mon, 5 Jan 2026 17:49:24 +0000 Message-ID: <20260105174924.554203-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KcDlyp9tLZzThUNJjldwfb0ef8pLsg5aEoNxQECb3oY_1767635367 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7B53DYBQXWVECRBJ6KZN6UNJ3X7ZKNZJ X-Message-ID-Hash: 7B53DYBQXWVECRBJ6KZN6UNJ3X7ZKNZJ X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1767635446634158500 From: Daniel P. Berrang=C3=A9 The g_base64_decode function will return a valid pointer, but with length of zero when it fails to decode data. Report an error in that scenario, so avoid a later more obsecure error. eg old behaviour # virsh secret-set-value f52a81b2-424e-490c-823d-6bd4235bc507 foo warning: Passing secret value as command-line argument is insecure! error: Failed to set secret value error: value in virSecretSetValue must not be NULL new behaviour # /home/berrange/virsh secret-set-value f52a81b2-424e-490c-823d-6bd4235b= c507 foo warning: Passing secret value as command-line argument is insecure! error: Secret value is not valid base64 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- tools/virsh-secret.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 26ecb41073..215e8e1017 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -267,6 +267,11 @@ cmdSecretSetValue(vshControl *ctl, const vshCmd *cmd) =20 secret_val =3D (char *) g_base64_decode(tmp, &secret_len); virSecureErase(tmp, tmp_len); + + if (!secret_len) { + vshError(ctl, "%s", _("Secret value is not valid base64")); + return false; + } } =20 res =3D virSecretSetValue(secret, (unsigned char *) secret_val, secret= _len, 0); --=20 2.52.0