From nobody Fri Jan 9 08:53:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1767619924; cv=none; d=zohomail.com; s=zohoarc; b=CpBKRnnLFKDqe51b+WB5NVUB9jlAyteZBOE5OjnU6+svrTgAe3swyh63s3LMj7S5yyRtYyPWtvFClYLDynMKIyPmtSG0G48HTaLd2Uzs1K8YGrbUNCmHo8MBzFyDKXnOWVIwtwhyFDJ8zI96mX13Z6BeX+n1N/Nkm1SNxUKxqPA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767619924; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZS0wGn/RKvfsIa5CvW9OkzSGSpDyiPdyVREBPuwrZH0=; b=AUeXwQkjWNKGdEigMmxEvaup00uN3EuSUG7KrQPur+BM5UwcS4+bQ4LOUBsULuk3/ek29Z0M8RkNRKw60d2a9j71aKAQYlcYtnPyVF/vxi178DkfDFQJL6VMdXW7s6XLAhQrwv8IP1HiKB36vHMIhLrzoqXSnkAOemYi2UrLMI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767619924445163.54410773281177; Mon, 5 Jan 2026 05:32:04 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id DDBCD418BC; Mon, 5 Jan 2026 08:32:02 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id D863541AB2; Mon, 5 Jan 2026 08:30:14 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 23E0F418B2; Mon, 5 Jan 2026 08:29:56 -0500 (EST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A1CE7418F0 for ; Mon, 5 Jan 2026 08:29:55 -0500 (EST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso14649073b3a.3 for ; Mon, 05 Jan 2026 05:29:55 -0800 (PST) Received: from fedora ([2804:14c:3b83:91fd::9d2a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724de25dsm130836510c88.7.2026.01.05.05.29.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 05:29:53 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767619794; x=1768224594; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZS0wGn/RKvfsIa5CvW9OkzSGSpDyiPdyVREBPuwrZH0=; b=P3rJeCVyDSNqVMb8KXxsNmud22deTb+09DO2Ze05N3Q49kbswcMOTjPEcOavcnrbSh YbuusZJFkONm40OlwMOYINF2P6sPq9o1Fucr0g+H8oCLQ5yXp4Cj6s71GXGWplqJAQH8 uEbQZOWdLB0i9de0Rx9xa1G3lTGxgMBPHvWrbwjGwnavLTef3J8pkgbAgIdOOdZdKOLI H5oW/lNZtCWSci4fhh3/UMn7vtKc9Uv7k3hf+PW/XfUGpbZIN6dq5KyezpDf4VmKMMtS d1RCmtr+lVx1skKGwBp00mF9fFXX9cLgjettvLPQjDGGku6yfHfjIji9fV1UF3XgLkMp hTVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767619794; x=1768224594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZS0wGn/RKvfsIa5CvW9OkzSGSpDyiPdyVREBPuwrZH0=; b=sWiGXJ7UqrTuVrQXaW+r6wE4gaA5KCywAV4kS+Dsri1YeO5pw/J29CpQY4T1R5A3J0 rUPcqXuT22f4zeJ8octOnPLzTBNxY5BUqBZIV+ZZjd54QEZr/vYp3BtupBpQ8RTOYyky fWmSap4RFjTe/IpbTi1Imew9CqDpgcg6E2GTtA5al93AQE6w/bbGOs6c36v/ie/yPJX/ EKXsSsFwS5sgM1DDKGjCJdGbzf9X/B0vwB0tqncppYzJzZFe7FaWDVy1eMxr3c19puuP WmqF5x+wXc6GTjoCQFXfnTFH3PKzFbgVfxgFL18CDjuS4vVQkO7yTA6P42HwxxlULwb1 f0Kg== X-Gm-Message-State: AOJu0Yxiggot70Y1Ekol9YyWnkAN5KkI5hwPHuLdTZS8Y0pEFzTQW2PW +YdiLQSnTemGdusiF1/ClI5au2atvlfqQLrz0rHpx2S3P0Izh+eLNsOGaHgq7g== X-Gm-Gg: AY/fxX5AJyEHWYPuYOs4gkan0y9HqGlalKQfJYTvbbq1USM2X5fMAfC134us4AI+GIM nXgxklovj9v4ZLWrhVNvonXC/REEcatD4OdPnzzvF0MTVFWh1AdRQScGyB+W9OSwB32iY46cr1F hLcwPHMmW6U+bqQQzo/YGg8MPfQRAyxmIjsPHdFHngiiDzVglq5ZTNecs/vevazByEIjm7tarZn cgg6YKtJUT7H2IUqk4v0S3bCTdM8G2x2eua7MQ/+/ZnpoXVTh1/E2nNQT/sY5UB+r2pHUA5sYCB pcCkm28Ush5hgstNAdiQSvZnja6IWa3Lj6CEu3musg9BVdxb/AHY5xoMt6PUag4ynUPFeZGx3wm FvYCdIIgVtsYDRrBmrO/3ZTf/o4oH+m9eqcVoUEY+ug8LNJdKbkV9dFjo662izH6O X-Google-Smtp-Source: AGHT+IGS4bLuB1o80EF+zmkltfX9Gr6nM2RsxK8ws+zB88KBSO+oO2jLLT6TGYggA2w7J/J4LO4cGg== X-Received: by 2002:a05:7022:6709:b0:11a:29e5:12e5 with SMTP id a92af1059eb24-121722ebc26mr49178408c88.30.1767619794114; Mon, 05 Jan 2026 05:29:54 -0800 (PST) From: Julio Faracco To: devel@lists.libvirt.org Subject: [PATCH 1/3] util: Fix uninitialized variable in virSocketAddrFormatWithPrefix Date: Mon, 5 Jan 2026 10:28:01 -0300 Message-ID: <20260105132904.25578-2-jcfaracco@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260105132904.25578-1-jcfaracco@gmail.com> References: <20260105132904.25578-1-jcfaracco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: DOEV6UQRZCP7EICANAXW5QDZY26R4T3V X-Message-ID-Hash: DOEV6UQRZCP7EICANAXW5QDZY26R4T3V X-MailFrom: jcfaracco@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1767619926693154100 Content-Type: text/plain; charset="utf-8" The virSocketAddrFormatWithPrefix() function has a bug where the 'network' variable is left uninitialized when masked=3Dfalse. This occurs because the function only assigns to 'network' inside the masked=3Dtrue conditional branch. When masked=3Dfalse, the caller wants to format the original address with a prefix notation (e.g., "1.2.3.4/24") without applying the network mask. However, the code was only initializing 'network' when masking was requested, causing the subsequent virSocketAddrFormat(&network) call to operate on uninitialized data. Fix this by adding an else branch that copies the original address to 'network' when masking is not requested. This ensures 'network' is properly initialized in both code paths. Signed-off-by: Julio Faracco --- src/util/virsocketaddr.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index f53768878e..80ee3b4c51 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -549,10 +549,14 @@ virSocketAddrFormatWithPrefix(virSocketAddr *addr, return NULL; } =20 - if (masked && virSocketAddrMaskByPrefix(addr, prefix, &network) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Failure to mask address")); - return NULL; + if (masked) { + if (virSocketAddrMaskByPrefix(addr, prefix, &network) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Failure to mask address")); + return NULL; + } + } else { + network =3D *addr; } =20 netstr =3D virSocketAddrFormat(&network); --=20 2.52.0