From nobody Fri Jan 9 08:53:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766971155; cv=none; d=zohomail.com; s=zohoarc; b=MFBQ4NU+eXzLvVoJuMlVu9mbfR1MHVgKywJ77UnKz6GGah+ferKmwVNiYZW+Yp5RaT7yFtgnRb1WrrTGa6ZhViAMLWCFWonFwmjoDdYLWKGNLU7XkHXxvNn+IEqV5q7+XI7pOMk/nu+1GUwvZ5VWByzeZ34g3kQCVTEkIEcMWJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766971155; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=fJrRhIdxKGF9cgXBrspeBDOnTt0xFpw0PFFfMpHXm9c=; b=K8UmVRZueHPzGyUwhLxIXcLiG9jwMJSKwQRF0Sy9I//isdMQBxftOqiMj8ZX/bEuhSmq+saW5l1wd3SWPmtRBxuIQcLLQWmHdrjpx4oYeWiFrNdO9+XLFmghR6+E6i0xPDvzX7X/ceFQqsOeDlEo14fQEEV0/e2d1x1mQgrbFvY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766971155595503.3254925786923; Sun, 28 Dec 2025 17:19:15 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 24C533FBB5; Sun, 28 Dec 2025 20:18:57 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A71D83F84A; Sun, 28 Dec 2025 20:17:51 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6834A3F34F; Sun, 28 Dec 2025 18:49:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EBE4F41B6B for ; Sun, 28 Dec 2025 18:41:24 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-lb-FnxN3PyWE-X08bOawrg-1; Sun, 28 Dec 2025 18:41:22 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 841591956080 for ; Sun, 28 Dec 2025 23:41:21 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6032180035A for ; Sun, 28 Dec 2025 23:41:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766965284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fJrRhIdxKGF9cgXBrspeBDOnTt0xFpw0PFFfMpHXm9c=; b=cq0DKxEIp0yJNcP3LBcV111gA9+HqyolZnAKYhyW210kZgjF6WIHzh+x6IfRf7lkRkz6Q7 3f/Sp/flqoMFNIN5ivlMRMqC3kh+m1Fz6FFr19jYya1HMdEugCG+t4MqDZfCbqhh4QYdBw ZwX5B/P3Kjzo+2SLJwLGo3//y2JQ1UY= X-MC-Unique: lb-FnxN3PyWE-X08bOawrg-1 X-Mimecast-MFC-AGG-ID: lb-FnxN3PyWE-X08bOawrg_1766965281 To: devel@lists.libvirt.org Subject: [PATCH 25/29] qemu_firmware: Require host-uefi-vars feature for JSON NVRAM Date: Mon, 29 Dec 2025 00:40:44 +0100 Message-ID: <20251228234048.1711701-26-abologna@redhat.com> In-Reply-To: <20251228234048.1711701-1-abologna@redhat.com> References: <20251228234048.1711701-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hcnsjqiikQIu9UWgZ9UQDubP_TPTfy11xShvxDAfugI_1766965281 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OHOUA4O5TOLIXFL7NEEOLLUPIKMCEUFE X-Message-ID-Hash: OHOUA4O5TOLIXFL7NEEOLLUPIKMCEUFE X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766971156559158500 Content-Type: text/plain; charset="utf-8"; x-default="true" NVRAM files in JSON format can only be used together with the uefi-vars QEMU device, and the firmware descriptor is required to advertise the host-uefi-vars feature in that case. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_firmware.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index f56a4977cf..ce90f95d0a 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1217,6 +1217,7 @@ qemuFirmwareMatchDomain(const virDomainDef *def, bool supportsTDX =3D false; bool supportsSecureBoot =3D false; bool hasEnrolledKeys =3D false; + bool usesUefiVarsDevice =3D false; int reqSecureBoot; int reqEnrolledKeys; =20 @@ -1305,6 +1306,9 @@ qemuFirmwareMatchDomain(const virDomainDef *def, break; =20 case QEMU_FIRMWARE_FEATURE_HOST_UEFI_VARS: + usesUefiVarsDevice =3D true; + break; + case QEMU_FIRMWARE_FEATURE_VERBOSE_DYNAMIC: case QEMU_FIRMWARE_FEATURE_VERBOSE_STATIC: case QEMU_FIRMWARE_FEATURE_NONE: @@ -1533,6 +1537,11 @@ qemuFirmwareMatchDomain(const virDomainDef *def, virStorageFileFormatTypeToString(loader->nvram->= format)); return false; } + + if (!usesUefiVarsDevice) { + VIR_DEBUG("Discarding loader with nvram template format 'j= son' and no 'host-uefi-vars' feature"); + return false; + } } else { if (loader && loader->nvram && (loader->nvram->path || loader->nvram->format)) { --=20 2.52.0