From nobody Fri Jan 9 08:49:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766970274; cv=none; d=zohomail.com; s=zohoarc; b=J6Id6wjklYkeBVHxLcBF/SZXVNTI0Q80CA28C037uhQCBXhE1RPnLtae2W4hGMJLSP2ZFa34vgtHGBHAJ9sCuuW52z82oN+1nZeDeAgrODobKxaM3vcNT/PtJI4GEvmLVZtZWLaOsCk1VvhuB0sRoE5rxox9bj1FQMQSac+k+Lk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766970274; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=4MNMxA5NPxdexstVRxJYkelc+c280QsRKAG3QiSPXfk=; b=ag7K0WX32uLndDujQIMxW+ySk15c4D9WQ42ohX6skM3vchhL4gVgdzMaXre4haqk/Z6/zvP2hwrRltrEucUdyFs7L3EqwOBCcqz6ADdbawUV40dCLORt7iPDPNzD7uAe0KQBCAlzULNLo4WLiI99XHZGRn2ZZ/6jXu3jT4iZbDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766970274002726.4909569825332; Sun, 28 Dec 2025 17:04:34 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 25E553F886; Sun, 28 Dec 2025 20:04:24 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9C7DD43DBF; Sun, 28 Dec 2025 19:59:08 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9FB7A417F8; Sun, 28 Dec 2025 18:49:49 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BD4DC419D7 for ; Sun, 28 Dec 2025 18:41:20 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-jJwt6kXIPh6-Ux5NcHUQlA-1; Sun, 28 Dec 2025 18:41:18 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 153D91800675 for ; Sun, 28 Dec 2025 23:41:18 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3EBAC1800666 for ; Sun, 28 Dec 2025 23:41:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766965280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4MNMxA5NPxdexstVRxJYkelc+c280QsRKAG3QiSPXfk=; b=Q0Od282InWLTVMJg9Eu7yXNXsiIpZdaqT39MIcYMVt/biY/QRXIguRn1twSiwC4sV/+lFu St5DVoJL0Zqu511uYzcbwK5O4In3RRPKmOShIBeAitCgT63/9jT8DYLxzWSmAAyN7awgpG UkMtQEOUPyY/5OW3DeiH69Vj5gvrKLQ= X-MC-Unique: jJwt6kXIPh6-Ux5NcHUQlA-1 X-Mimecast-MFC-AGG-ID: jJwt6kXIPh6-Ux5NcHUQlA_1766965278 To: devel@lists.libvirt.org Subject: [PATCH 22/29] qemu: Don't allow remote locations for JSON format NVRAM Date: Mon, 29 Dec 2025 00:40:41 +0100 Message-ID: <20251228234048.1711701-23-abologna@redhat.com> In-Reply-To: <20251228234048.1711701-1-abologna@redhat.com> References: <20251228234048.1711701-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8KM95g9whPuL2pmYBkRkO22LrbQH1hYHxU2hgv_gHKg_1766965278 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NFLIRRP6YRGA7TH2P5EWBM3UJASYT6NS X-Message-ID-Hash: NFLIRRP6YRGA7TH2P5EWBM3UJASYT6NS X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766970275598158500 Content-Type: text/plain; charset="utf-8"; x-default="true" JSON format NVRAM files are accessed through the uefi-vars QEMU device, and at least currently that only supports local files, so we need to forbid the use for remote locations for the format. The firmware-manual-efi-qemuvars-nvram-network-nbd test case starts failing earlier and with a different error message after this change. This is expected and desirable. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_validate.c | 5 +++ ...muvars-nvram-network-nbd.x86_64-latest.err | 2 +- ...muvars-nvram-network-nbd.x86_64-latest.xml | 40 ------------------- tests/qemuxmlconftest.c | 2 +- 4 files changed, 7 insertions(+), 42 deletions(-) delete mode 100644 tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvra= m-network-nbd.x86_64-latest.xml diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 40676bef39..5ecf34f622 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -734,6 +734,11 @@ qemuValidateDomainDefNvram(const virDomainDef *def, _("The uefi-vars device is not supported by thi= s QEMU binary")); return -1; } + if (!virStorageSourceIsLocalStorage(src)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Remote JSON files are not supported with NVR= AM")); + return -1; + } } =20 if (src->sliceStorage) { diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvram-netwo= rk-nbd.x86_64-latest.err b/tests/qemuxmlconfdata/firmware-manual-efi-qemuva= rs-nvram-network-nbd.x86_64-latest.err index e5f67f8d09..424b06199a 100644 --- a/tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvram-network-nbd.= x86_64-latest.err +++ b/tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvram-network-nbd.= x86_64-latest.err @@ -1 +1 @@ -unsupported configuration: Unsupported nvram format 'json' +unsupported configuration: Remote JSON files are not supported with NVRAM diff --git a/tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvram-netwo= rk-nbd.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-manual-efi-qemuva= rs-nvram-network-nbd.x86_64-latest.xml deleted file mode 100644 index 14f2800174..0000000000 --- a/tests/qemuxmlconfdata/firmware-manual-efi-qemuvars-nvram-network-nbd.= x86_64-latest.xml +++ /dev/null @@ -1,40 +0,0 @@ - - guest - 63840878-0deb-4095-97e6-fc444d9bc9fa - 1048576 - 1048576 - 1 - - hvm - /usr/share/edk2/ovmf/OVMF.qemuvars.fd - - - - - - - - - - - - qemu64 - - - destroy - restart - destroy - - /usr/bin/qemu-system-x86_64 - - -
- - - - -