From nobody Fri Jan 9 08:49:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766969229; cv=none; d=zohomail.com; s=zohoarc; b=cnBt4XR4L9L+ET4xI5Mk0dcGBaOoofSUr17Zk6Zi0iIhRdbosRUlX+IwRlikrpkBVpEGBlWq2wzGYzBvUDDEO0aph99Xx+RSVTiU5ng/0UBhLhNI1yZeV2o0W9TP4z64ErI2vQBDTsvaWl37eKD7Y8WjcJ9WgK7iduxe74iqgkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766969229; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=XeOZmyM2nC7YtF3uC2eBoPQ6GOPt74JSdErGeoB6bDg=; b=GC1cBKmnbWnc4mMossHY5ayuFcCiB4nHsl53Dh8hZmkpvnFIaYbCJy3yUy9Bldq+Vs2HDls0Bzqd3zLJ6Yf+1ybK2jNfljmf8s5B+nek2FPnbzOb3YY9fzMapUq0PikwjydOojHvEMBn/Wlmj2wDoQcwdIBszChspLqxk1itWSc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766969229686318.0855651018078; Sun, 28 Dec 2025 16:47:09 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 86ADD3F95B; Sun, 28 Dec 2025 19:47:07 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 4965941ADE; Sun, 28 Dec 2025 19:40:44 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6A058417EB; Sun, 28 Dec 2025 18:49:29 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 62B8E419EC for ; Sun, 28 Dec 2025 18:41:07 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-0nnMGpkAPVSMigTl5DpkeQ-1; Sun, 28 Dec 2025 18:41:05 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC7DC1800669 for ; Sun, 28 Dec 2025 23:41:04 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B3931800367 for ; Sun, 28 Dec 2025 23:41:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766965267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XeOZmyM2nC7YtF3uC2eBoPQ6GOPt74JSdErGeoB6bDg=; b=Fu0gJc30YWqjPv7q9yuOZJR4wxXySoM5hK0Z0/Uf4BPU4nAET7QIDvfTJSjeemDUuS/nxg uFK8eWvpiOsRwYgSwXGLiAADmCP62tnHmIC0jpR5IAJfb07N7niRm8R3exqspDsyLKL38N E8725ZnKfgwZw16BhX3bEddLeP/TI+E= X-MC-Unique: 0nnMGpkAPVSMigTl5DpkeQ-1 X-Mimecast-MFC-AGG-ID: 0nnMGpkAPVSMigTl5DpkeQ_1766965265 To: devel@lists.libvirt.org Subject: [PATCH 11/29] qemu_firmware: Don't skip EnsureNVRAM() for ROMs Date: Mon, 29 Dec 2025 00:40:30 +0100 Message-ID: <20251228234048.1711701-12-abologna@redhat.com> In-Reply-To: <20251228234048.1711701-1-abologna@redhat.com> References: <20251228234048.1711701-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U-yAys1bPFjBH8V04U0ixW21Z1a6DjUZQ8S-hlxayZE_1766965265 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OI3R4QKMLCKU33XTAGSHJ2TVDAORUGEP X-Message-ID-Hash: OI3R4QKMLCKU33XTAGSHJ2TVDAORUGEP X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766969231194158500 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that we expect NVRAM to be used together with ROM firmware builds, we need to ensure that the corresponding configuration is always populated correctly. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_firmware.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index fc78433100..1b97cdb316 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1076,9 +1076,6 @@ qemuFirmwareEnsureNVRAM(virDomainDef *def, if (!loader) return; =20 - if (loader->type !=3D VIR_DOMAIN_LOADER_TYPE_PFLASH) - return; - if (loader->readonly !=3D VIR_TRISTATE_BOOL_YES) return; =20 --=20 2.52.0