From nobody Fri Jan 9 08:52:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766966735; cv=none; d=zohomail.com; s=zohoarc; b=mQIkhDkaGYG74a3PGX13dZ+glfLm5qY0YuQmJ7zoLz94SlixYi43Ho6Hss0Y5+LkS7/ey6Xuy52kOB3YOnljGUk+h02dmePxy6z9amkpfAUjqNh1CKI/hjuYtHSAA2klTsW4skPbX3WLqVinhtnM6bP1OrFAObZyNqb8vnVhdtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766966735; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=kcb177rVmqSU/+gt9KQS7hfGsHcHWIOtU4Qu4I1YUTY=; b=QKtsq8cLHG0ubBqjcmrc7WSfRaI687OaakrF00EMEs1AIlfaPTwVpZYzGHtMnLl6zmZUxGT7u8meIw3KyLLNTbIjUaFhNf4T/vJJx0wMepF4UqJo6OaFXQ8kiy7Uagyhxhz2PtjKCY2vUqFI2r45OPnUaUMED2wi1JA1ZXwlwek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766966735791622.0591565009382; Sun, 28 Dec 2025 16:05:35 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id CA84643DF3; Sun, 28 Dec 2025 19:05:34 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id F16E64195D; Sun, 28 Dec 2025 18:52:01 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id F1D9F417F0; Sun, 28 Dec 2025 18:34:40 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 00B1F417F3 for ; Sun, 28 Dec 2025 18:34:39 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-40w6hzwGMfynHWTcfbKLhA-1; Sun, 28 Dec 2025 18:34:38 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C7AB1800654 for ; Sun, 28 Dec 2025 23:34:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E3D030001B9 for ; Sun, 28 Dec 2025 23:34:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766964879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kcb177rVmqSU/+gt9KQS7hfGsHcHWIOtU4Qu4I1YUTY=; b=OS2P2l2VEpVjiXUNJdfpviNtJ5gKZ3O49AAL8VezA5FIeu3yjwyj51m3o6JDzhNmONiyxV QGB7ztiKLnNXq5zCtO9cYR1B4OhraCJ0J58C7HT5AzI6ZYCNtNzVmDbix4WN15sThQMHEy MQiVDDVsVt/RMkno7plyJbqj7cagL78= X-MC-Unique: 40w6hzwGMfynHWTcfbKLhA-1 X-Mimecast-MFC-AGG-ID: 40w6hzwGMfynHWTcfbKLhA_1766964877 To: devel@lists.libvirt.org Subject: [PATCH 18/36] tests: Add firmware-auto-efi-format-nvram-raw-loader-path Date: Mon, 29 Dec 2025 00:33:54 +0100 Message-ID: <20251228233412.1709869-19-abologna@redhat.com> In-Reply-To: <20251228233412.1709869-1-abologna@redhat.com> References: <20251228233412.1709869-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dH_Yn5WXKT95YUk_mll8PBVD6HOUJuTw7GSbih4SCSE_1766964877 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LCFA2XXAMBCTZEM6VTIAUCJE7PZ7I47X X-Message-ID-Hash: LCFA2XXAMBCTZEM6VTIAUCJE7PZ7I47X X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766966737102158500 Content-Type: text/plain; charset="utf-8"; x-default="true" This test case demonstrates an issue with the current implementation of firmware autoselection. libvirt would normally be able to find the firmware descriptor for the binary mentioned in the domain XML, but the fact that at the same time we're asking for the NVRAM file to be of a different format throws a spanner in the works. Of course there is no requirement for the format of the NVRAM file to match that of the NVRAM template, so the fact that libvirt is unable to produce a working configuration out of this input is an issues that will be addressed in an upcoming commit. Signed-off-by: Andrea Bolognani --- ...at-nvram-raw-loader-path.x86_64-latest.err | 1 + ...at-nvram-raw-loader-path.x86_64-latest.xml | 36 +++++++++++++++++++ ...-auto-efi-format-nvram-raw-loader-path.xml | 19 ++++++++++ tests/qemuxmlconftest.c | 1 + 4 files changed, 57 insertions(+) create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-ra= w-loader-path.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-ra= w-loader-path.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-ra= w-loader-path.xml diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-raw-loade= r-path.x86_64-latest.err b/tests/qemuxmlconfdata/firmware-auto-efi-format-n= vram-raw-loader-path.x86_64-latest.err new file mode 100644 index 0000000000..3edb2b3451 --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-raw-loader-path.= x86_64-latest.err @@ -0,0 +1 @@ +operation failed: Unable to find 'efi' firmware that is compatible with th= e current configuration diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-raw-loade= r-path.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-n= vram-raw-loader-path.x86_64-latest.xml new file mode 100644 index 0000000000..6bb1ad1507 --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-nvram-raw-loader-path.= x86_64-latest.xml @@ -0,0 +1,36 @@ + + guest + 63840878-0deb-4095-97e6-fc444d9bc9fa + 1048576 + 1048576 + 1 + + hvm + /usr/share/edk2/ovmf/OVMF_CODE_= 4M.secboot.qcow2 + + + + + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + +
+ + + + +