From nobody Fri Jan 9 08:55:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766966010; cv=none; d=zohomail.com; s=zohoarc; b=iPQnnih6Qw2At/bwJB+jXQIeoSoeGhzrBwGUroNudCUgNiRkoa+RTiLtEsLJ5uvwXicZ6WiQ/Ou9Fy2hQOLj21p4a62LcZYXX1f8EOtNMCugccUPDb5/zRXpwxjV+vtdJzCuGbFwSYqiv8JMHNxgtpPiq35KuYSN8MPr+x8P//E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766966010; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=BmEoA+bkGDqVZKrtdCPTiJ+1+DFwVomEPoAvqWwxZ9Q=; b=ksdegXoAfD5B7JgvgCNvQKn3oOtSJaK0+/Gjfl0kWXe4elc4tSEFbubC+jZGkExMtmok2637s/3TsdaQuESSLCO8BOX1b4RxQnDS5MZayNwb/N8od4krqdKU/jiaLBo/TDkFiFnwPlLk3QQ5uQlya3Jlzd7T8e0yUI6GPnltfs0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766966010742991.5638618925536; Sun, 28 Dec 2025 15:53:30 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id DB1154195C; Sun, 28 Dec 2025 18:53:29 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 35A7A43E4C; Sun, 28 Dec 2025 18:45:26 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 197833FD11; Sun, 28 Dec 2025 18:34:32 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3DDE7417F0 for ; Sun, 28 Dec 2025 18:34:31 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-WuoM827tMA6CULEFspmigw-1; Sun, 28 Dec 2025 18:34:28 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 04C4C1956050 for ; Sun, 28 Dec 2025 23:34:28 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EF9A30001A8 for ; Sun, 28 Dec 2025 23:34:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766964870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmEoA+bkGDqVZKrtdCPTiJ+1+DFwVomEPoAvqWwxZ9Q=; b=S9T0qMRSYLsqDaSGs+R4SXhG1dFKCg6bYAp55pLFDmiqnWYWBTogb2xISVNHrVv/1RKS1F KkhJRHmLcDsj6AmhjF1Hem697YCPbC3poExQNkBteUTYt4EiTncKvlcTc7qvQQYLlaerWa IZZGccrw1X49KqdJZaX53S9nI94UXKo= X-MC-Unique: WuoM827tMA6CULEFspmigw-1 X-Mimecast-MFC-AGG-ID: WuoM827tMA6CULEFspmigw_1766964868 To: devel@lists.libvirt.org Subject: [PATCH 10/36] tests: Add firmware-auto-efi-format-loader-qcow2-rom Date: Mon, 29 Dec 2025 00:33:46 +0100 Message-ID: <20251228233412.1709869-11-abologna@redhat.com> In-Reply-To: <20251228233412.1709869-1-abologna@redhat.com> References: <20251228233412.1709869-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mtQDf9341_1nuX0zpI3Y3xtgdQKMv59_fugOXeOrHJ4_1766964868 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6Z5EA52AN4TF57WXBNYA4Q64RCQH6AAE X-Message-ID-Hash: 6Z5EA52AN4TF57WXBNYA4Q64RCQH6AAE X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766966012841158500 Content-Type: text/plain; charset="utf-8"; x-default="true" This test case demonstrates a flaw in the XML validation process. ROM images are by definition in raw format, so attempting to use any other format should have resulted in the domain XML being rejected. The issue will be addressed in an upcoming commit. Signed-off-by: Andrea Bolognani --- ...format-loader-qcow2-rom.x86_64-latest.args | 34 ++++++++++++++++ ...-format-loader-qcow2-rom.x86_64-latest.xml | 39 +++++++++++++++++++ ...mware-auto-efi-format-loader-qcow2-rom.xml | 18 +++++++++ tests/qemuxmlconftest.c | 1 + 4 files changed, 92 insertions(+) create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-loader-q= cow2-rom.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-loader-q= cow2-rom.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/firmware-auto-efi-format-loader-q= cow2-rom.xml diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-ro= m.x86_64-latest.args b/tests/qemuxmlconfdata/firmware-auto-efi-format-loade= r-qcow2-rom.x86_64-latest.args new file mode 100644 index 0000000000..417084d45e --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-rom.x86_6= 4-latest.args @@ -0,0 +1,34 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-machine pc-q35-10.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.r= am,acpi=3Don \ +-accel kvm \ +-cpu qemu64 \ +-bios /usr/share/edk2/ovmf/OVMF.inteltdx.secboot.fd \ +-m size=3D1048576k \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}= ' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 63840878-0deb-4095-97e6-fc444d9bc9fa \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-global ICH9-LPC.noreboot=3Doff \ +-watchdog-action reset \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-ro= m.x86_64-latest.xml b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader= -qcow2-rom.x86_64-latest.xml new file mode 100644 index 0000000000..862a50ddb4 --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-auto-efi-format-loader-qcow2-rom.x86_6= 4-latest.xml @@ -0,0 +1,39 @@ + + guest + 63840878-0deb-4095-97e6-fc444d9bc9fa + 1048576 + 1048576 + 1 + + hvm + + + + + /usr/share/edk2/ovmf/OVMF.intelt= dx.secboot.fd + + + + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + +
+ + + + +