From nobody Fri Jan 9 08:52:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1766965927; cv=none; d=zohomail.com; s=zohoarc; b=bdaOKAbX4rNj2i6Cib5lJspevibYA1K6kd+gS37aqfrc2D4OLqHsx3pOdWujoRFiGnZ39r88mtOvk9nHo9YS3wROHP4d9c/CTkTlNIZERZir3gydZ9iwXCaA+7kgcN1OdtxMN6teTggpXIsRNpPLKbw9DuYhqi52ZOTi0O16bMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766965927; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=NNj1sF7MjnK1rzjZCdTUEcjFneR9Ta5wdi3A14WMv+c=; b=OyDc38zjkyesp+gMJKQxOvZV5j9EsgAwUa/d569FS2Txc7pzdn1W4Dun0Ll2Gh3MSasmeE9E8ZyQIqSGtjJArKVNY21RopJGVYbi81vObZmbMuyK+lNwZTm2oKWIdvswBLIrVxFvVyRGSXQ7NMBnyWDB69QufVd/k5idr/WBMeY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1766965927603365.6016001617737; Sun, 28 Dec 2025 15:52:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A245941909; Sun, 28 Dec 2025 18:52:06 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 67EE943EB7; Sun, 28 Dec 2025 18:43:12 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DE3943FD11; Sun, 28 Dec 2025 18:34:30 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BDCCE417EB for ; Sun, 28 Dec 2025 18:34:29 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-fiCBgrwePYaN0i1QCBM-Iw-1; Sun, 28 Dec 2025 18:34:27 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B4B5719560B2 for ; Sun, 28 Dec 2025 23:34:26 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.19]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0290730001A8 for ; Sun, 28 Dec 2025 23:34:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766964869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NNj1sF7MjnK1rzjZCdTUEcjFneR9Ta5wdi3A14WMv+c=; b=HF3TJBh+Ycnz4l7ndsD2uTS0Y1b117ICzyQ5n+GPTWT6FdGYHrvD4MytXAml5aco61sxQA 3uVfCq4aQL+GC1lXDjT9s8DYDQtAoqP7aG/runsjd7oPlskAerRLdN1lvPhnCho99c90Vn xU2YfVUIcABDWp+qNfFw3smxxEmsnyk= X-MC-Unique: fiCBgrwePYaN0i1QCBM-Iw-1 X-Mimecast-MFC-AGG-ID: fiCBgrwePYaN0i1QCBM-Iw_1766964866 To: devel@lists.libvirt.org Subject: [PATCH 09/36] domain_validate: Reject read/write ROMs Date: Mon, 29 Dec 2025 00:33:45 +0100 Message-ID: <20251228233412.1709869-10-abologna@redhat.com> In-Reply-To: <20251228233412.1709869-1-abologna@redhat.com> References: <20251228233412.1709869-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4ZddFxXBzQLyxNVs5nJdC-ZnEZTswdyL2DBU2KTXFPo_1766964866 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZQSHXB5GRJ7PVC5OV3H3EV2VGVZELEQI X-Message-ID-Hash: ZQSHXB5GRJ7PVC5OV3H3EV2VGVZELEQI X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1766965928667158500 Content-Type: text/plain; charset="utf-8"; x-default="true" The combination doesn't make sense. After this change the firmware-manual-bios-rw test case starts failing, as it should have in the first place. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c | 6 ++++ ...firmware-manual-bios-rw.x86_64-latest.args | 32 ------------------- .../firmware-manual-bios-rw.x86_64-latest.err | 1 + .../firmware-manual-bios-rw.x86_64-latest.xml | 28 ---------------- tests/qemuxmlconftest.c | 2 +- 5 files changed, 8 insertions(+), 61 deletions(-) delete mode 100644 tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-la= test.args create mode 100644 tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-la= test.err delete mode 100644 tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-la= test.xml diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 09c1b3f13f..93a54f8cc7 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1766,6 +1766,12 @@ virDomainDefOSValidate(const virDomainDef *def, } =20 if (loader->readonly =3D=3D VIR_TRISTATE_BOOL_NO) { + if (loader->type =3D=3D VIR_DOMAIN_LOADER_TYPE_ROM) { + virReportError(VIR_ERR_XML_DETAIL, "%s", + _("ROM loader type cannot be used as read/write= ")); + return -1; + } + if (loader->nvramTemplate) { virReportError(VIR_ERR_XML_DETAIL, "%s", _("NVRAM template is not permitted when loader = is read/write")); diff --git a/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.ar= gs b/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.args deleted file mode 100644 index 969c7ad68c..0000000000 --- a/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.args +++ /dev/null @@ -1,32 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ -XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ -XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ -/usr/bin/qemu-system-x86_64 \ --name guest=3Dguest,debug-threads=3Don \ --S \ --object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ --machine pc-i440fx-10.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dp= c.ram,acpi=3Doff \ --accel tcg \ --cpu qemu64 \ --bios /usr/share/seabios/bios.bin \ --m size=3D1048576k \ --object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}= ' \ --overcommit mem-lock=3Doff \ --smp 1,sockets=3D1,cores=3D1,threads=3D1 \ --uuid 63840878-0deb-4095-97e6-fc444d9bc9fa \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --boot strict=3Don \ --audiodev '{"id":"audio1","driver":"none"}' \ --sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ --msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.er= r b/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.err new file mode 100644 index 0000000000..13e9d7c0f1 --- /dev/null +++ b/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.err @@ -0,0 +1 @@ +ROM loader type cannot be used as read/write diff --git a/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.xm= l b/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.xml deleted file mode 100644 index 65bb8493c9..0000000000 --- a/tests/qemuxmlconfdata/firmware-manual-bios-rw.x86_64-latest.xml +++ /dev/null @@ -1,28 +0,0 @@ - - guest - 63840878-0deb-4095-97e6-fc444d9bc9fa - 1048576 - 1048576 - 1 - - hvm - /usr/share/seabios= /bios.bin - - - - qemu64 - - - destroy - restart - destroy - - /usr/bin/qemu-system-x86_64 - - - - - - diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index f7f4aae79b..5f3cfe23fd 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -1527,7 +1527,7 @@ mymain(void) DO_TEST_CAPS_LATEST("firmware-manual-bios"); DO_TEST_CAPS_LATEST("firmware-manual-bios-stateless"); DO_TEST_CAPS_LATEST_PARSE_ERROR("firmware-manual-bios-not-stateless"); - DO_TEST_CAPS_LATEST("firmware-manual-bios-rw"); + DO_TEST_CAPS_LATEST_PARSE_ERROR("firmware-manual-bios-rw"); DO_TEST_CAPS_LATEST("firmware-manual-efi"); DO_TEST_CAPS_LATEST("firmware-manual-efi-features"); DO_TEST_CAPS_LATEST_ABI_UPDATE_PARSE_ERROR("firmware-manual-efi-featur= es"); --=20 2.52.0