From nobody Thu Jan 8 17:49:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1767603562; cv=none; d=zohomail.com; s=zohoarc; b=fFiiLR91bjcWkZJ2DtdGzWi2OUMCXnaVTd/TRvBeOJb/DWsmPq0C37zohxLspLzVpk2YoVKNe97/BGvp62vyVIf94HixH77SAvzFopXNvk2RlMoW5XKWFtK8LKOeQqbQiTH/EneX3smG/J6KjkSZufF4lUKurePA3vL7HgOSLoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767603562; h=Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Z9qv1ByE5t4EILHADC3me1zl63G0Nv0OuppZzYGUubo=; b=lqhLgqdrQAeNPvujXrFd2OlLua+uqKqFhv1XUyEy4PqzB4jHMB9tLTN7iysz8odFW70lE0I5zPszGb289m+kbhR7YJLlDVNNdLl1rtAxAjLS4dosLV8gbBW0eB0NBNKKiQZ0j3XdNC72TSKTslQrsXCrMdbCLIrRd9mtLX3iSu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767603562100349.46753624366227; Mon, 5 Jan 2026 00:59:22 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id D216741928; Mon, 5 Jan 2026 03:59:20 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 99AE641A18; Mon, 5 Jan 2026 03:57:46 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5CB9641908; Mon, 22 Dec 2025 13:08:30 -0500 (EST) Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3557141910 for ; Mon, 22 Dec 2025 13:08:29 -0500 (EST) Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vXk0o-005nfW-6O; Mon, 22 Dec 2025 17:48:01 +0000 Received: from localhost (ava [IPv6:2804:14d:7224:88bd:b38e:cd50:1e1d:e09a]) by vps.terceiro.xyz (Postfix) with ESMTPSA id C73F7400F2; Mon, 22 Dec 2025 14:47:58 -0300 (-03) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=4.0.1 X-Greylist: delayed 1224 seconds by postgrey-1.37 at lists.libvirt.org; Mon, 22 Dec 2025 13:08:29 EST DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=Z9qv1ByE5t4EILHADC3me1zl63G0Nv0OuppZzYGUubo=; b=OIYk1Pu7Vbn4U/Anq9W3vwZJKA Y4HdElLmIuGOABPeY3FO/QoNRPPVdJU8TJjWkPUYZgviQM3JAgAosa89KZaDl1AKJsEW/NOqN8H/9 ZUxTQAXo1cBFPQu1w0CBZvfB6trKCSsTaoEqHNeKWrMJlMPwarHiyaDdsEZFwkCLNxTRdmhtkeBeR Wq6M+ALoesvlw1U5Arjq/ldbXdWWeIs1xmG1HlMJLGC12kfyQYP7gYR9oEaytRkO4qfb3KXJJ3uve dIoTzfIWdLPv0OtTzJ1x7VvLVgLYspyqE8tW3nivU70lv5bKW7S+SujTEe7ZjxTDgZGtF8sjCuLZ7 e5ZiSjdw==; From: Antonio Terceiro To: devel@lists.libvirt.org Subject: [PATCH] libvirt-guests.service: use Type=exec Date: Mon, 22 Dec 2025 14:46:33 -0300 Message-ID: <20251222174633.13552-1-terceiro@debian.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Debian-User: terceiro X-MailFrom: terceiro@debian.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: KK3XGHVB72DZYO4AW7TZABJTBZN7HRG6 X-Message-ID-Hash: KK3XGHVB72DZYO4AW7TZABJTBZN7HRG6 X-Mailman-Approved-At: Mon, 05 Jan 2026 08:57:33 +0000 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @debian.org) X-ZM-MESSAGEID: 1767603563147154100 Content-Type: text/plain; charset="utf-8" Type=3Doneshot means that the service is only considered started after the main process exits. In setups where libvirt-guests is configured to be used and imposes a delay on the startup of guests, this will cause systemd to report a quite high boot time as it will wait until all guests have booted, plus all the delay between them. High boot times are often reported as issues in monitoring systems, and require operator attention, while in this case there is not really an issue with the system, it's just doing what it was configured to do. With Type=3Dexec, the service is considered started right after the main process is *started*, but the boot process will not wait for it. Having other units depend on libvirt-guests.service finishing was already not reliable because one cannot know how long the OS inside each guest takes to boot, and libvirt-guests already does not wait for them to be in any particular state. Signed-off-by: Antonio Terceiro Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service= .in index b044444298..c8e4d3d749 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -19,7 +19,7 @@ EnvironmentFile=3D-@initconfdir@/libvirt-guests # out the code ExecStart=3D@libexecdir@/libvirt-guests.sh start ExecStop=3D@libexecdir@/libvirt-guests.sh stop -Type=3Doneshot +Type=3Dexec RemainAfterExit=3Dyes StandardOutput=3Djournal+console TimeoutStopSec=3D0 --=20 2.51.0