From nobody Thu Jan 8 17:55:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1765983635; cv=none; d=zohomail.com; s=zohoarc; b=DfTlBCunkPYEIknvp8AaylZC6Coyq5e32msnMu6dRNq3D7I1kWCIU3GGEqyq4Hz/O1mrFsdc0YVpUMt7aU6nwYsSXihERsloRCiXZLZI4kVujs6HE5Fauj4ca50kLefig2xLf9UUtrdqEy0KU6oEEL0c73Ch7t5c1Y7ky/q8+lA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765983635; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=5LZiRCvjmrx/2T/FY3FTnyILQXHQqRRhFVxG1qyvqbw=; b=mYkIwkzcsX+O9n2T4ea6glDuHsyE7fSLCefwE6hDas14iUSEq39yu1N3YzspJL9corZxqfECCZOpq9vEcbNJjR0tfur9iCtnOQyDLQ8lo67++lXV+P4uHIhrfQh0CNX7Jy+iYRBtUVA7g3HpjptfwwI8fn1ztdWW4QJmNBTtSuo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1765983635102267.3629119389584; Wed, 17 Dec 2025 07:00:35 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 378C241918; Wed, 17 Dec 2025 10:00:34 -0500 (EST) Received: from [172.19.199.80] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A9D5F41C9C; Wed, 17 Dec 2025 09:59:56 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id AD6323F886; Wed, 17 Dec 2025 09:59:48 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1299F3F37B for ; Wed, 17 Dec 2025 09:59:48 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-i_MEHs9wMj6AscV1vC4m9w-1; Wed, 17 Dec 2025 09:59:35 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 955B119560A1 for ; Wed, 17 Dec 2025 14:59:34 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.217]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9BB8B1955F24; Wed, 17 Dec 2025 14:59:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765983587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5LZiRCvjmrx/2T/FY3FTnyILQXHQqRRhFVxG1qyvqbw=; b=Shq8STl8kOWcRlCJUY2esywwQbKjUiRdJpPNH5KBy3Wyw5IlNCPX2DdVU6Dq+q1t91sFSi SUfiqDz43C9HBu5oLLE349TIpoP2kXpTO20mfg43X3kGhLqXy7EX7BPO7LZj26doL5t7ec nmFSj0/uS2rQhyw6vAYoCDztItW2dd0= X-MC-Unique: i_MEHs9wMj6AscV1vC4m9w-1 X-Mimecast-MFC-AGG-ID: i_MEHs9wMj6AscV1vC4m9w_1765983574 To: devel@lists.libvirt.org Subject: [PATCH] rpm: disable -Werror on ELN builds Date: Wed, 17 Dec 2025 14:59:32 +0000 Message-ID: <20251217145932.3940210-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1YWiYpE3V4ZKqPVxKbkjRKcJrb4vA3uJHjuITCfx8qQ_1765983574 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SMWR6LSBWI2JBPMDBPNNLZGGE6MYARE4 X-Message-ID-Hash: SMWR6LSBWI2JBPMDBPNNLZGGE6MYARE4 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1765983637898154100 From: Daniel P. Berrang=C3=A9 The ELN build root performs rebuilds of Fedora rawhide packages with %{rhel} set instead of %{fedora}. The vast majority of the time this will "do the right thing", but when we control -Dwerror we chose to enable -Werror on RHEL on the basis that the GCC toolchain is stable and thus we don't expect new warnings to appear. That does not hold true for ELN which tracks rawhide GCC. Thus we have the rare situation where we should explicitly check %{eln} not just %{rhel}. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Jiri Denemark --- libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index ccfe75135b..22c9975d9f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -263,8 +263,9 @@ =20 # RHEL releases provide stable tool chains and so it is safe to turn # compiler warning into errors without being worried about frequent -# changes in reported warnings -%if 0%{?rhel} +# changes in reported warnings. ELN is a rebuild of Rawhide so should +# be treated as unstable for this flag +%if 0%{?rhel} && !0%{?eln} %define enable_werror -Dwerror=3Dtrue %else %define enable_werror -Dwerror=3Dfalse -Dgit_werror=3Ddisabled --=20 2.52.0