From nobody Fri Dec 12 14:05:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1764692920; cv=none; d=zohomail.com; s=zohoarc; b=nNLzLBasWoGDex49MWOnCuN1V4QYCzIvP/rGJrbcRxLBrQUQO+tqJiTvDKtwUEwYTVooNTM+SaYTRNEY78U3pToJZw+3eamD2Vd0vyjhDcx6xjKbYGlD5uDU90bOASYJWVSDn9Quhipdmhun2bzSib1YkYbwnw5JQnF9IQ5hLTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764692920; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oFMoN0j3418KkpmnCkFVIOUV1/FeeoHKRBgyHQzEzpc=; b=FWxrow7NncOXxIrUgaU706Wo/BJEXjjrL78L8Ri2578BJCLBiUskYequsP0uYSD8LPFVx0xCaFgq2O5DMhBcDRYGjTXK5LYi4+eB7OSa6t3SAt872NS+W3+FUT0yW3wk4JMgXO6qjVtGlfD2KnzBX3wb1KBaQmZGZSsUiIYlzB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176469292091230.05316552228419; Tue, 2 Dec 2025 08:28:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQSvO-0004Ye-Kl; Tue, 02 Dec 2025 11:08:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQSut-00043E-55; Tue, 02 Dec 2025 11:07:52 -0500 Received: from mgamail.intel.com ([192.198.163.7]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQSur-0008HR-AT; Tue, 02 Dec 2025 11:07:50 -0500 Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 08:07:46 -0800 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by orviesa005.jf.intel.com with ESMTP; 02 Dec 2025 08:07:36 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764691670; x=1796227670; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=x4x9GwtVyQN/1zu2eRKA2AyFq1QUrStlsY8oJcIM534=; b=mxL7vknNDwxXMtGCnileshkronX4Sg7Zvgb2JKFK6HSCPAI9WSLBnQM/ FNy3VkGSvCYQeGcCYZOH22vFtxsrO69Yni6RAWf85aViq9Pc97bNIvPkt N6xuCzTSUwgcC9Q2lBnYvp/RCGK5Xv4W2NoTCOWiTP3C9Vw3knsTRqLsI qa9sYbX/48so7sHmppRyEnCDub0HlTQC9wA5wkPZRkBcPrrCF3pkQ0J/j 6tlH6G8WKjl6eubr+RuL81JVcNcLBjG6hClL3Fx3qvGrXZYJpQLDqna/z CzWR3avUrR0rDPBlVb5KlFJdzTg3Y1vESu10S/dVRtNMyAkxzVk1Imku9 w==; X-CSE-ConnectionGUID: Fw+aetmkQTancxbO2bOPEQ== X-CSE-MsgGUID: OAAGuX27TPChIqKmUD8KSw== X-IronPort-AV: E=McAfee;i="6800,10657,11630"; a="92143035" X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="92143035" X-CSE-ConnectionGUID: Z/3e7+YlTk+4rCCHob2SYQ== X-CSE-MsgGUID: enPvPe20R5WSzqdBXTM8yA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="199537921" From: Zhao Liu To: Paolo Bonzini , "Michael S . Tsirkin" , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Thomas Huth Cc: qemu-devel@nongnu.org, devel@lists.libvirt.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Richard Henderson , Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , Eduardo Habkost , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , Weiwei Li , Amit Shah , Xiaoyao Li , Yanan Wang , Helge Deller , Palmer Dabbelt , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Ani Sinha , Fabiano Rosas , Liu Zhiwei , =?UTF-8?q?Cl=C3=A9ment=20Mathieu--Drif?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Huacai Chen , Jason Wang , Mark Cave-Ayland , BALATON Zoltan , Peter Krempa , Jiri Denemark , Zhao Liu Subject: [PATCH v5 24/28] hw/audio/pcspk: Remove PCSpkState::migrate field Date: Wed, 3 Dec 2025 00:28:31 +0800 Message-Id: <20251202162835.3227894-25-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251202162835.3227894-1-zhao1.liu@intel.com> References: <20251202162835.3227894-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.7; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1764692923495019200 From: Philippe Mathieu-Daud=C3=A9 The PCSpkState::migrate boolean was only set in the pc_compat_2_7[] array, via the 'migrate=3Doff' property. We removed all machines using that array, lets remove that property, simplifying vmstate_spk[]. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Reviewed-by: Zhao Liu Signed-off-by: Zhao Liu --- hw/audio/pcspk.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index 916c56fa4c0a..0b01544941cb 100644 --- a/hw/audio/pcspk.c +++ b/hw/audio/pcspk.c @@ -57,7 +57,6 @@ struct PCSpkState { unsigned int play_pos; uint8_t data_on; uint8_t dummy_refresh_clock; - bool migrate; }; =20 static const char *s_spk =3D "pcspk"; @@ -202,18 +201,10 @@ static void pcspk_realizefn(DeviceState *dev, Error *= *errp) } } =20 -static bool migrate_needed(void *opaque) -{ - PCSpkState *s =3D opaque; - - return s->migrate; -} - static const VMStateDescription vmstate_spk =3D { .name =3D "pcspk", .version_id =3D 1, .minimum_version_id =3D 1, - .needed =3D migrate_needed, .fields =3D (const VMStateField[]) { VMSTATE_UINT8(data_on, PCSpkState), VMSTATE_UINT8(dummy_refresh_clock, PCSpkState), @@ -224,7 +215,6 @@ static const VMStateDescription vmstate_spk =3D { static const Property pcspk_properties[] =3D { DEFINE_AUDIO_PROPERTIES(PCSpkState, audio_be), DEFINE_PROP_UINT32("iobase", PCSpkState, iobase, 0x61), - DEFINE_PROP_BOOL("migrate", PCSpkState, migrate, true), DEFINE_PROP_LINK("pit", PCSpkState, pit, TYPE_PIT_COMMON, PITCommonSta= te *), }; =20 --=20 2.34.1