From nobody Fri Dec 12 14:09:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1764691654; cv=none; d=zohomail.com; s=zohoarc; b=AcFNv4/sllUmip/c07mloHd08b1c2BZlA/0ZAdROuw8fQaZ12ugSiPqox8GrBnEPNL/Gvt3TkY8pLbceKVtx9CP2RAWBgzwzD1bXvG3NsHfQwgy8fMkre8LVbmQpLQyyEGCeQ0mCFJfttNXOJn+hdJY4Avrd6WGi48jU77WcC80= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764691654; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B8P6wqQNFRaGANbLmA4zrtMnSAVJdcctmyeQU25AacI=; b=YgYwATT81WdamMkjTuN4krW5eDRm4aSlwFxtu4PCA671hl0vddIUs163ztx0Aeg5oeXlPlKoPRIikNbd6oSX7oW32crcC+3u4YedlZXVkLSF/XgU8a67LyWO+y1BkdHc71pZAMqLVCZLWTkhXd8yeRsp9xuyzRb4oOk0F2bV8UE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764691654803241.7622882920756; Tue, 2 Dec 2025 08:07:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQSu4-0000xb-Cz; Tue, 02 Dec 2025 11:07:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQStz-0000LT-79; Tue, 02 Dec 2025 11:06:55 -0500 Received: from mgamail.intel.com ([192.198.163.7]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQStx-0007xU-65; Tue, 02 Dec 2025 11:06:54 -0500 Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 08:06:50 -0800 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by orviesa005.jf.intel.com with ESMTP; 02 Dec 2025 08:06:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764691613; x=1796227613; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/n0ftya4A99iHjWPZUr3WDol3H8mQTwBUoAVwDtk6y4=; b=m0o2plEazctQtoiWzDDMbMtBjQGDpo6yYl2S9ozAxhC9KqwYeqGRvy8U xcXyoBM5o5EzTNMNBGF6LrI4wIDLQmDxNdvZzwzBs8V51qqmXDXVmU/E9 XG9yqBGJiHV9c6fy1kFCNeVPljW58Lw4txIempqqc30PFIWqRD1DnsU9q xiAGf+V40CxOIx3yZCiaj6yYijnADkU4CauV+QMjNFzI9djLuHaoE+MO4 Lci5EMmwMXSCbKZ4j7p40W7pBUdVEz3NiOjImb4yMhb+FQwnHqPV0CecP K8H8M4635vNg2yv02HezMIRCUyTLQBUvjkm4KJ3zgvqNqDqWwIQ1IYaXf g==; X-CSE-ConnectionGUID: puSSr1yPQkyL9VdT3GcR+Q== X-CSE-MsgGUID: H+/si3JRRRyTbO17uI0HJA== X-IronPort-AV: E=McAfee;i="6800,10657,11630"; a="92142798" X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="92142798" X-CSE-ConnectionGUID: H0vus8aaRLakTXdaogt3nQ== X-CSE-MsgGUID: TEFPBB7vSquCrbpUZ8eS+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="199537727" From: Zhao Liu To: Paolo Bonzini , "Michael S . Tsirkin" , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Thomas Huth Cc: qemu-devel@nongnu.org, devel@lists.libvirt.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Richard Henderson , Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , Eduardo Habkost , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , Weiwei Li , Amit Shah , Xiaoyao Li , Yanan Wang , Helge Deller , Palmer Dabbelt , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Ani Sinha , Fabiano Rosas , Liu Zhiwei , =?UTF-8?q?Cl=C3=A9ment=20Mathieu--Drif?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Huacai Chen , Jason Wang , Mark Cave-Ayland , BALATON Zoltan , Peter Krempa , Jiri Denemark , Zhao Liu Subject: [PATCH v5 18/28] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Date: Wed, 3 Dec 2025 00:28:25 +0800 Message-Id: <20251202162835.3227894-19-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251202162835.3227894-1-zhao1.liu@intel.com> References: <20251202162835.3227894-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.7; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1764691656812019200 From: Philippe Mathieu-Daud=C3=A9 The APICCommonState::legacy_instance_id boolean was only set in the pc_compat_2_6[] array, via the 'legacy-instance-id=3Don' property. We removed all machines using that array, lets remove that property, simplifying apic_common_realize(). Because instance_id is initialized as initial_apic_id, we can not register vmstate_apic_common directly via dc->vmsd. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Reviewed-by: Zhao Liu Signed-off-by: Zhao Liu --- hw/intc/apic_common.c | 5 ----- include/hw/i386/apic_internal.h | 1 - 2 files changed, 6 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index ec9e978b0b40..69a7b1bd5d3e 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -276,9 +276,6 @@ static void apic_common_realize(DeviceState *dev, Error= **errp) info->enable_tpr_reporting(s, true); } =20 - if (s->legacy_instance_id) { - instance_id =3D VMSTATE_INSTANCE_ID_ANY; - } vmstate_register_with_alias_id(NULL, instance_id, &vmstate_apic_common, s, -1, 0, NULL); =20 @@ -395,8 +392,6 @@ static const Property apic_properties_common[] =3D { DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14), DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_= BIT, true), - DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instanc= e_id, - false), }; =20 static void apic_common_get_id(Object *obj, Visitor *v, const char *name, diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_interna= l.h index 4a62fdceb4ea..0cb06bbc76c9 100644 --- a/include/hw/i386/apic_internal.h +++ b/include/hw/i386/apic_internal.h @@ -187,7 +187,6 @@ struct APICCommonState { uint32_t vapic_control; DeviceState *vapic; hwaddr vapic_paddr; /* note: persistence via kvmvapic */ - bool legacy_instance_id; uint32_t extended_log_dest; }; =20 --=20 2.34.1