From nobody Fri Dec 12 14:07:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1764074396; cv=none; d=zohomail.com; s=zohoarc; b=gefHe32lAuxK/mXf6TUwm3yYYRG6PDGktNwFGxgv97/YiFpbli/GFc5Ffwu7+8kh0LLM3dBOg3BedzOi5YSQDHOyFrkA/eHPB4A6ZJcE3g8Nm4vdjropZago1CmkBBaKvku9rX9jx2n3woN8A6y8m0oY1VS5iz4D9sJjgLZpMd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764074396; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=tWBMxKw8MoHCvkGXmqj++Q230eJKJsSxvGB7/cIiqpA=; b=EgH3TvJMt5U6dlYUqH9wSYnPtOYHpW0R4A8KIPDF+21NDNZZZRJ8//vbwsfhmYhJR2h7Oz4Zhhe6uYO5Ua410rJvDhstSKuOTDo2ZKPr/ObGKD+Ijc0dQAla4pO64AEX1nV6Q8aLRZqReX8OhmbRiy8NYx0twwn1PEM6gGjCAiw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1764074396546680.4844144039859; Tue, 25 Nov 2025 04:39:56 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id E76F344AB0; Tue, 25 Nov 2025 07:39:55 -0500 (EST) Received: from [172.19.199.68] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B1A8D44BE3; Tue, 25 Nov 2025 07:28:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 19C6D44B84; Tue, 25 Nov 2025 07:22:56 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CD5AB44B87 for ; Tue, 25 Nov 2025 07:18:37 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-bvb202zhOLWd3SJGGPnY-g-1; Tue, 25 Nov 2025 07:18:36 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 85A7D1956059 for ; Tue, 25 Nov 2025 12:18:35 +0000 (UTC) Received: from kshcheti-thinkpadp1gen4i.tpbc.csb (unknown [10.43.3.229]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A645E180047F; Tue, 25 Nov 2025 12:18:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764073117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWBMxKw8MoHCvkGXmqj++Q230eJKJsSxvGB7/cIiqpA=; b=ZpvGVW5l2/22kTpDXOK22cU2XYPc0wJWj5NZNQQZYkzmmoCZAuss5+/IYizfthW5nUkFmh nVJH1lcJuwyiRazKAB7FyKLleFmiozqN6vbzvNk+/rPzOSLdaT3d6N2SCyezYWEfRCCwBz fRehvppbyCaIqZfV5sLTKDPO+aSlTBw= X-MC-Unique: bvb202zhOLWd3SJGGPnY-g-1 X-Mimecast-MFC-AGG-ID: bvb202zhOLWd3SJGGPnY-g_1764073115 To: devel@lists.libvirt.org Subject: [PATCH v2 20/22] virDomainIdmapDefParseXML: Use automatic memory management Date: Tue, 25 Nov 2025 13:11:50 +0100 Message-ID: <20251125121753.444490-21-kshcheti@redhat.com> In-Reply-To: <20251125121753.444490-1-kshcheti@redhat.com> References: <20251125121753.444490-1-kshcheti@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cYUbdRkfpIc8BZ7ABA1IpMqrgnBJdk2H9hmKq-iyuBM_1764073115 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BQFZTJMCCJUT25GIMSWIVZKXSXQY5HKT X-Message-ID-Hash: BQFZTJMCCJUT25GIMSWIVZKXSXQY5HKT X-MailFrom: kshcheti@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kirill Shchetiniuk X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kirill Shchetiniuk via Devel Reply-To: Kirill Shchetiniuk X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1764074397730019200 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Kirill Shchetiniuk Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b36a71dba..d41dd4a829 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9187,7 +9187,7 @@ virDomainIdmapDefParseXML(xmlXPathContextPtr ctxt, size_t num) { size_t i; - virDomainIdMapEntry *idmap =3D NULL; + g_autofree virDomainIdMapEntry *idmap =3D NULL; VIR_XPATH_NODE_AUTORESTORE(ctxt) =20 idmap =3D g_new0(virDomainIdMapEntry, num); @@ -9199,14 +9199,13 @@ virDomainIdmapDefParseXML(xmlXPathContextPtr ctxt, virXPathUInt("string(./@count)", ctxt, &idmap[i].count) < 0) { virReportError(VIR_ERR_XML_ERROR, "%s", _("invalid idmap start/target/count settings")); - VIR_FREE(idmap); return NULL; } } =20 g_qsort_with_data(idmap, num, sizeof(idmap[0]), virDomainIdMapEntrySor= t, NULL); =20 - return idmap; + return g_steal_pointer(&idmap); } =20 =20 --=20 2.49.0