From nobody Fri Dec 12 14:07:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1764074198; cv=none; d=zohomail.com; s=zohoarc; b=XCGe8L3ga3m/91+2QNloOgV6YCT8OUEjfiIXkcMHJlAMzAqwdzxrOpPkVZSIiPof7gOQSFiB+ffpCcy+ZjusbfWFJak+zbIUZTH7PHShXINHEj6X2Hpth/8EMxcQSVG98xDJzFdfA8FfioIqjk9azYbH85c38vuwSSjlHYxonHk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764074198; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=OWu/3pnwhlCxpKNIXr3F9VSYFXDCsjmI0I3c2ETieGo=; b=VT2lUPgGExVdUWJyrnSfxQpq9bH5XwrktLW9AlUJ4EcHFIWqvBAOQxqtnKN2kXY5d4J1ngifYU0qxVtzZvm/JcvkVjKsESJ3vfXAdPYtWVjIsEWhl4bTW4NoPKYBuVLWzH6YLzbSPi+v1/gOrUgp4WegsuUAt7VTAIXkCpdKO8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176407419892511.533437863720792; Tue, 25 Nov 2025 04:36:38 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 2A42344840; Tue, 25 Nov 2025 07:36:38 -0500 (EST) Received: from [172.19.199.68] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1BA0A44E41; Tue, 25 Nov 2025 07:21:56 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 251CB44B07; Tue, 25 Nov 2025 07:21:47 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3A59A44B47 for ; Tue, 25 Nov 2025 07:18:34 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-5sd1vXPGPpeV-pqrcBPBqQ-1; Tue, 25 Nov 2025 07:18:32 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA9AC18001FE for ; Tue, 25 Nov 2025 12:18:31 +0000 (UTC) Received: from kshcheti-thinkpadp1gen4i.tpbc.csb (unknown [10.43.3.229]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 024CA18002A6; Tue, 25 Nov 2025 12:18:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764073113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OWu/3pnwhlCxpKNIXr3F9VSYFXDCsjmI0I3c2ETieGo=; b=F1ODS8dy2+Ka3QskQ19SReUID/ohe64LtNNaqYe3XU79+SSSHXKRbazzUpQyMrVfXtYwYl ryNQnJQdtxyqCAlCLj1lJWlwjNwBGzc8z1CYNJRzB8Cj0cULUwcLnBMtNaxN/3r81pu23T yv1HLSneNXgyxKEMFDgtZTFMMQVzt74= X-MC-Unique: 5sd1vXPGPpeV-pqrcBPBqQ-1 X-Mimecast-MFC-AGG-ID: 5sd1vXPGPpeV-pqrcBPBqQ_1764073111 To: devel@lists.libvirt.org Subject: [PATCH v2 17/22] virDomainGraphicsDefNew: Use automatic memory management Date: Tue, 25 Nov 2025 13:11:47 +0100 Message-ID: <20251125121753.444490-18-kshcheti@redhat.com> In-Reply-To: <20251125121753.444490-1-kshcheti@redhat.com> References: <20251125121753.444490-1-kshcheti@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zGU9W8yFRbwCw14m5RQ1PL_04SL9h3Bh9drOByaJsaw_1764073111 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: A4WYYKRH7YCS5SUO36I5ORU7XNJCKOIK X-Message-ID-Hash: A4WYYKRH7YCS5SUO36I5ORU7XNJCKOIK X-MailFrom: kshcheti@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kirill Shchetiniuk X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kirill Shchetiniuk via Devel Reply-To: Kirill Shchetiniuk X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1764074200144019201 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Kirill Shchetiniuk Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 541dad5bdc..02f55ade44 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12277,16 +12277,16 @@ virDomainGraphicsDefParseXMLDBus(virDomainGraphic= sDef *def, virDomainGraphicsDef * virDomainGraphicsDefNew(virDomainXMLOption *xmlopt) { - virDomainGraphicsDef *def =3D NULL; + g_autoptr(virDomainGraphicsDef) def =3D NULL; =20 def =3D g_new0(virDomainGraphicsDef, 1); =20 if (xmlopt && xmlopt->privateData.graphicsNew && !(def->privateData =3D xmlopt->privateData.graphicsNew())) { - VIR_FREE(def); + return NULL; } =20 - return def; + return g_steal_pointer(&def); } =20 =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index cb35ff06bd..185fc959aa 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3726,6 +3726,7 @@ int virDomainObjWaitUntil(virDomainObj *vm, void virDomainPanicDefFree(virDomainPanicDef *panic); void virDomainResourceDefFree(virDomainResourceDef *resource); void virDomainGraphicsDefFree(virDomainGraphicsDef *def); +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainGraphicsDef, virDomainGraphicsDefFr= ee); const char *virDomainInputDefGetPath(virDomainInputDef *input); void virDomainInputDefFree(virDomainInputDef *def); virDomainDiskDef *virDomainDiskDefNew(virDomainXMLOption *xmlopt); --=20 2.49.0