From nobody Fri Nov 21 10:17:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763634185; cv=none; d=zohomail.com; s=zohoarc; b=NPopmCOUSINfQ/N0ceAFIi8nztkAYietJ6q8+qNI42obksWbr1tUd/UU7aYlUrud9CYaK7oKuHRPBYfBgbVUGQTpzjRDwykkAH7QCGU/+kBd1QaCAK1xTGCHEyWUX42M8eoX/iU+TRCWKAlEP26m+R0ZgMgXA62jLtI6j8BT6m4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763634185; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=I6AlW+WPYHwAGMYAsdPLPgmfVODLeMaUbka38eJf6uA=; b=MxX7J6dhdS2mUsy/iAMvJBczhFtq/P2U/aMUtpga9Ke0zsZDXStD3+bCXGY5ARzeQqWC8Ku2g2pzflSK/2WmOrrfzqxN6nX2H2UBux8gSjbLPQXo9YzSQPC860CzXPDzfdJHSYksMSps65eb5yOjKV4UnmVd3xZnpU7o4IiFK2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763634185415490.1603062480218; Thu, 20 Nov 2025 02:23:05 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id CDBBE417F4; Thu, 20 Nov 2025 05:23:04 -0500 (EST) Received: from [172.19.199.53] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 6976F446EE; Thu, 20 Nov 2025 05:17:27 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id C74AA41BC6; Thu, 20 Nov 2025 05:15:10 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7950141B50 for ; Thu, 20 Nov 2025 05:15:09 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-Bio2lVKNPIuPbkJyGEhqoQ-1; Thu, 20 Nov 2025 05:15:07 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D6097195605B for ; Thu, 20 Nov 2025 10:15:06 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EAB521800947; Thu, 20 Nov 2025 10:15:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763633709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6AlW+WPYHwAGMYAsdPLPgmfVODLeMaUbka38eJf6uA=; b=NpKndOPlGpdkJOBm/x4aHENimqiT30J08UwiDvLzlxzO7GD+aRP1QOiY1VlT1W8GFHD+n5 fYaydGit+sPHxvMOHPVFDCftY1D9YLdaggM6U75OGIK3xODeiKjt+3oO/5dR/Lgr8t8KdK muhtletTK518A7TNrvrc9KvvRd1F7+A= X-MC-Unique: Bio2lVKNPIuPbkJyGEhqoQ-1 X-Mimecast-MFC-AGG-ID: Bio2lVKNPIuPbkJyGEhqoQ_1763633707 To: devel@lists.libvirt.org Subject: [PATCH 5/5] tools: inform user which hardware virt was found during validation Date: Thu, 20 Nov 2025 10:14:51 +0000 Message-ID: <20251120101451.3468378-6-berrange@redhat.com> In-Reply-To: <20251120101451.3468378-1-berrange@redhat.com> References: <20251120101451.3468378-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uF6DxYo8Bg-p_gd_lE1-ZEigZ-Jo2J5t1oqL1LMUOwU_1763633707 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q4V25J5KZILPOA5SM4ATZBZGQJ74AVC7 X-Message-ID-Hash: Q4V25J5KZILPOA5SM4ATZBZGQJ74AVC7 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763634187167018900 From: Daniel P. Berrang=C3=A9 On x86 we can indicate VMX or SVM, while s390x would be SIE. There are several choices on ppc64 and virt-host-validate does not try to detect any, so don't report a specific technology on ppc64 arch. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tools/virt-host-validate-qemu.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qem= u.c index 833bb1b914..f04fc61cb3 100644 --- a/tools/virt-host-validate-qemu.c +++ b/tools/virt-host-validate-qemu.c @@ -34,6 +34,7 @@ int virHostValidateQEMU(void) bool hasHwVirt =3D false; bool hasVirtFlag =3D false; virArch arch =3D virArchFromHost(); + const char *hwVirtName =3D NULL; const char *kvmhint =3D _("Check that CPU and firmware supports virtua= lization and kvm module is loaded"); =20 if (!(flags =3D virHostValidateGetCPUFlags())) @@ -44,15 +45,22 @@ int virHostValidateQEMU(void) case VIR_ARCH_X86_64: hasVirtFlag =3D true; kvmhint =3D _("Check that the 'kvm-intel' or 'kvm-amd' modules are= loaded & the BIOS has enabled virtualization"); - if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM) || - virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) + if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM)) { + hwVirtName =3D "SVM"; hasHwVirt =3D true; + } + if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) { + hwVirtName =3D "VMX"; + hasHwVirt =3D true; + } break; case VIR_ARCH_S390: case VIR_ARCH_S390X: hasVirtFlag =3D true; - if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SIE)) + if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SIE)) { + hwVirtName =3D "SIE"; hasHwVirt =3D true; + } break; case VIR_ARCH_PPC64: case VIR_ARCH_PPC64LE: @@ -66,7 +74,7 @@ int virHostValidateQEMU(void) if (hasVirtFlag) { virValidateCheck("QEMU", "%s", _("Checking for hardware virtualiza= tion")); if (hasHwVirt) { - virValidatePass(); + virValidatePassDetails(hwVirtName); } else { virValidateFail(VIR_VALIDATE_FAIL, _("Host not compatible with KVM; HW virtualiza= tion CPU features not found. Only emulated CPUs are available; performance = will be significantly limited")); --=20 2.51.1