From nobody Fri Nov 21 10:16:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763634103; cv=none; d=zohomail.com; s=zohoarc; b=UXpNhveFsFFD+GGvpThzVIgeUU9ehKa2eGn3JR+OhkjbfDQjS16sZfkn5BeCLLltSicOEOUT/Ss6E7IWn3zlFulR4P5onyGx5aj5fmXkwhN+N4ka8IR7h9Z2OA9wobC198z3C+zJ5obhVyTedoIxEjIxdtP3Fh8AyH8c95EP/ng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763634103; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=52+AEg0olBWJ7LWlEg6dn4Rx2GrOAo2Asm4/X2aA4VQ=; b=Mq1TTf1wIr4WOhcEsmhDWIFoQl/b8Tydlb1RdMuQvPQbcWBY/y3zoHWxSYq8TRthyXC3imu4o526QeQWufs6BvY+aIwtpX9KFzcERaVeucQBXFeDUqt+bjNp/4xRry3QaEUG8eGYGJKDpc/eCyWZCDaarXYjR4K7Sc3qLlgQ4ww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763634103948243.84949342689606; Thu, 20 Nov 2025 02:21:43 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 62E1A3F33C; Thu, 20 Nov 2025 05:21:43 -0500 (EST) Received: from [172.19.199.53] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id D3E324418B; Thu, 20 Nov 2025 05:17:22 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id C0BCC43F4A; Thu, 20 Nov 2025 05:15:06 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 092E241B50 for ; Thu, 20 Nov 2025 05:15:06 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-CxZ-U20JNEyIAuzBmTviTA-1; Thu, 20 Nov 2025 05:15:04 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A093319560B5 for ; Thu, 20 Nov 2025 10:15:03 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 30355180049F; Thu, 20 Nov 2025 10:15:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763633705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=52+AEg0olBWJ7LWlEg6dn4Rx2GrOAo2Asm4/X2aA4VQ=; b=jT0UGxGDXmsnr0PBbyhNgqBtHH24OPvS/mKMn+rrvve4KjFIN4+dRwXjW7belb9nwI3O9y k/bHKusfPxtQEbQXuOPPz0KeWKsOFjNT32s8GRydx0/w/UjlENnzoDQfbWq9ctrFY6r9qJ TF9l7+ej7qXgg4Ymc8kB4O8jc+uVzqY= X-MC-Unique: CxZ-U20JNEyIAuzBmTviTA-1 X-Mimecast-MFC-AGG-ID: CxZ-U20JNEyIAuzBmTviTA_1763633703 To: devel@lists.libvirt.org Subject: [PATCH 4/5] tools: be explicit about failure to find x86 secure virt Date: Thu, 20 Nov 2025 10:14:50 +0000 Message-ID: <20251120101451.3468378-5-berrange@redhat.com> In-Reply-To: <20251120101451.3468378-1-berrange@redhat.com> References: <20251120101451.3468378-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: c04-58y1UgpTRfVMvpqR2fW99omxVnbWwDc6maCf5qo_1763633703 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 44W2LUUTNLSFJUDBLJ3GJTTGLGKTOUZK X-Message-ID-Hash: 44W2LUUTNLSFJUDBLJ3GJTTGLGKTOUZK X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763634104857018900 From: Daniel P. Berrang=C3=A9 If we fail to find either SEV or TDX on x86, we can explicitly say there is no secure guest support on the platform. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tools/virt-host-validate-common.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-c= ommon.c index 344f9656e5..6bca661ffc 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -492,13 +492,17 @@ int virHostValidateSecureGuests(const char *hvname, "support for IBM Secure Execution"); return VIR_VALIDATE_FAILURE(level); } - } else if (hasAMDSev) { - return virHostValidateAMDSev(hvname, level); - } else if (hasIntelTDX) { - return virHostValidateIntelTDX(level); + } else if (arch =3D=3D VIR_ARCH_X86_64) { + if (hasAMDSev) { + return virHostValidateAMDSev(level); + } else if (hasIntelTDX) { + return virHostValidateIntelTDX(level); + } else { + virValidateFail(level, "None of SEV, SEV-ES, SEV-SNP, TDX avai= lable"); + } + } else { + virValidateFail(level, + "Unknown if this platform has Secure Guest support= "); } - - virValidateFail(level, - "Unknown if this platform has Secure Guest support"); return VIR_VALIDATE_FAILURE(level); } --=20 2.51.1