From nobody Fri Nov 21 10:09:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763633917; cv=none; d=zohomail.com; s=zohoarc; b=XfQpaVHgJFG+n+rAtU4axh+MrtnkB97lF6mVTk/lODrgReZVWh2JHJcw5SopxLtd8T/NtOPbyIUA1DZHk83Kh/YLmP8FCgSGYPQMsGp2rZf4RSgKuAZ9+ZSoKE+3cW09LjG82rraWhwKPReKzLBFzktrfn0UL9fhEyfGr3R5Suk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763633917; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=dwILjdRp03NkZTxPNtAcXsT/Lt76T+Mh4J8H5uHgvg8=; b=moECqpbqnalHZguwZ9Kyt///UmR3vaT9s8yJYky0FMgCdPNjJRLlfX872QleFCom5gOEia+cWctQeEXhnjHwdPYVZ/5l8Ew4IyyZuVcNb7OhSL4qAa5i4iN9fZssT4GKNU49AMcMlYvqQdaAgcqclhI2vQa0KlRCE3KtynOMkOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763633917856841.3746669757791; Thu, 20 Nov 2025 02:18:37 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4AD87441C2; Thu, 20 Nov 2025 05:18:37 -0500 (EST) Received: from [172.19.199.53] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3B8B2442BE; Thu, 20 Nov 2025 05:17:08 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 858C041B2F; Thu, 20 Nov 2025 05:15:00 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 744CC41B50 for ; Thu, 20 Nov 2025 05:14:59 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-dDNhCoDEMkCWZs2px5MXEQ-1; Thu, 20 Nov 2025 05:14:57 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7624719540D5 for ; Thu, 20 Nov 2025 10:14:56 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4D0FB180094D; Thu, 20 Nov 2025 10:14:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763633699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dwILjdRp03NkZTxPNtAcXsT/Lt76T+Mh4J8H5uHgvg8=; b=LYtUHL7CnEr/4E0wwOucT/CBqri/6f6LUIpw59pdcF8OuywKqsTi7uC09EKAocsBmgJegv Di4F2VrG5jmG6++8OieV8bBomMhfGT73LWr25Ol6i5Kmde91k9c4pymMQPvT5WrTs+GsbS olm6wayBdWvF7uyVZ2VySGfZgzj1UbA= X-MC-Unique: dDNhCoDEMkCWZs2px5MXEQ-1 X-Mimecast-MFC-AGG-ID: dDNhCoDEMkCWZs2px5MXEQ_1763633696 To: devel@lists.libvirt.org Subject: [PATCH 1/5] tools: allow passing details for passed validation tests Date: Thu, 20 Nov 2025 10:14:47 +0000 Message-ID: <20251120101451.3468378-2-berrange@redhat.com> In-Reply-To: <20251120101451.3468378-1-berrange@redhat.com> References: <20251120101451.3468378-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 88AwbWV3PL_gD2kFW9lizbioEm481yuw3IWVmq27Y1k_1763633696 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: INNDSMTRFZNRAFAVAZ6I26J5QJLNTD76 X-Message-ID-Hash: INNDSMTRFZNRAFAVAZ6I26J5QJLNTD76 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763633919936018900 From: Daniel P. Berrang=C3=A9 In a number of virt-host-validte tests we are testing for at least one out of multiple acceptable features. For example the 'secure guest' test can be satisfied by s390x protvirt, or x86 TDX, SEV, SEV-ES, SEV-SNP. It would be useful to inform the user which one we detected when the test passes. This introduces virValidatePassDetails to enable that. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tools/virt-validate-common.c | 12 +++++++++++- tools/virt-validate-common.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/virt-validate-common.c b/tools/virt-validate-common.c index 9768fd9208..ef6130ff2a 100644 --- a/tools/virt-validate-common.c +++ b/tools/virt-validate-common.c @@ -62,14 +62,24 @@ static bool virValidateWantEscape(void) } =20 void virValidatePass(void) +{ + virValidatePassDetails(NULL); +} + +void virValidatePassDetails(const char *info) { if (quiet) return; =20 if (virValidateWantEscape()) - fprintf(stdout, "\033[32m%s\033[0m\n", _("PASS")); + fprintf(stdout, "\033[32m%s\033[0m", _("PASS")); else fprintf(stdout, "%s\n", _("PASS")); + + if (info) + fprintf(stdout, " (%s)\n", info); + else + fprintf(stdout, "\n"); } =20 =20 diff --git a/tools/virt-validate-common.h b/tools/virt-validate-common.h index 7f7c373a66..8981f5af71 100644 --- a/tools/virt-validate-common.h +++ b/tools/virt-validate-common.h @@ -52,6 +52,7 @@ void virValidateCheck(const char *prefix, ...) G_GNUC_PRINTF(2, 3); =20 void virValidatePass(void); +void virValidatePassDetails(const char *info); void virValidateFail(virValidateLevel level, const char *format, ...) G_GNUC_PRINTF(2, 3); --=20 2.51.1