From nobody Fri Nov 21 10:12:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762873967; cv=none; d=zohomail.com; s=zohoarc; b=H45aTqXc3Olo+YKWMSfddHWvGmkox7xSHK8hWCawUik1pWzeveTTHWQTcAn0mmlFeULHAlicdX416q8X22j4zRyNQPg9U6bBx3RYFtBiTza7oOqhTFyPopm/ADzpBAy/LnUu11Y74Yq6SgV+uBUmEHP33rX9V+rT5PfX4OYLpjo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762873967; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=VSOK4kl6c29tTm2NHtwGm6qCf1ypavdPm2HH6PXA8Ds=; b=B/mRyCd3sqSOLagXvH1turDZ3ZywxZxomFVmfQvfa0sV2CYvATgHYFM7penrUbW4d7/gPmnXuK28R/oealMC5JMQHr4Voe9fCaEk4S8gTgn3phjVfSIaToPSJeG8+asmxKuClL7n3qBL5NoQQWWENNnX6a/rHNc6f/xTboMYZCc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762873967797948.4737294562228; Tue, 11 Nov 2025 07:12:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8CF37443E8; Tue, 11 Nov 2025 10:12:46 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 12C0D44C8D; Tue, 11 Nov 2025 10:06:07 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6CE0444A4C; Tue, 11 Nov 2025 10:06:00 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3399C44A4C for ; Tue, 11 Nov 2025 10:05:34 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-h-YLDhqXPDCEGZHPvXbgDA-1; Tue, 11 Nov 2025 10:05:32 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3F61180034D for ; Tue, 11 Nov 2025 15:05:31 +0000 (UTC) Received: from kshcheti-thinkpadp1gen4i.tpbc.csb (unknown [10.43.3.60]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EA2F419560A2; Tue, 11 Nov 2025 15:05:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762873533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VSOK4kl6c29tTm2NHtwGm6qCf1ypavdPm2HH6PXA8Ds=; b=DF2cS0n23NB8Ngg5N0pIXTRhE2/lyd6dDm1fOo9Hg/AzIJJa5mc90IU/l814Hq8CEAj/co 2vZtJuoXxAIf8OdDErqupZvBWpEvF5n2LEdrSt7+F6TOEl0ywDr3t+ncDhOHAuCRHizyz4 Jw+1GYNNTnR2iFN+wbAmTsU++pDEbZc= X-MC-Unique: h-YLDhqXPDCEGZHPvXbgDA-1 X-Mimecast-MFC-AGG-ID: h-YLDhqXPDCEGZHPvXbgDA_1762873532 To: devel@lists.libvirt.org Subject: [PATCH 6/7] qemuProcessRefreshChannelVirtioState: Use automatic memory management Date: Tue, 11 Nov 2025 16:01:45 +0100 Message-ID: <20251111150508.257647-7-kshcheti@redhat.com> In-Reply-To: <20251111150508.257647-1-kshcheti@redhat.com> References: <20251111150508.257647-1-kshcheti@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RjDy6SzOqozVbEnZvRQ7Z9guaV-cKhr7CzVkPbyXkeg_1762873532 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: M3XKZZGZH3GQKT6NF45YYW5BJOJPGDHM X-Message-ID-Hash: M3XKZZGZH3GQKT6NF45YYW5BJOJPGDHM X-MailFrom: kshcheti@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kirill Shchetiniuk X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kirill Shchetiniuk via Devel Reply-To: Kirill Shchetiniuk X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762873969092158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Kirill Shchetiniuk Moved variables to closer scope to enbale asuto memory management Signed-off-by: Kirill Shchetiniuk --- src/qemu/qemu_process.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 45fc32a663..6f656a033e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2161,9 +2161,6 @@ qemuProcessRefreshChannelVirtioState(virQEMUDriver *d= river, { size_t i; int agentReason =3D VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_REASON_CH= ANNEL; - qemuMonitorChardevInfo *entry; - virObjectEvent *event =3D NULL; - g_autofree char *id =3D NULL; =20 if (booted) agentReason =3D VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_REASON_DO= MAIN_STARTED; @@ -2171,8 +2168,10 @@ qemuProcessRefreshChannelVirtioState(virQEMUDriver *= driver, for (i =3D 0; i < vm->def->nchannels; i++) { virDomainChrDef *chr =3D vm->def->channels[i]; if (chr->targetType =3D=3D VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_VIRT= IO) { + qemuMonitorChardevInfo *entry =3D NULL; + virObjectEvent *event =3D NULL; + g_autofree char *id =3D NULL; =20 - VIR_FREE(id); id =3D g_strdup_printf("char%s", chr->info.alias); =20 /* port state not reported */ --=20 2.49.0