From nobody Fri Nov 21 10:14:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1762797779; cv=none; d=zohomail.com; s=zohoarc; b=juwNuthbxRCBY/e7O8sW65rQCfeaF299i83J1Z6623vF7nraRXNc6CzfKzznGpJt7x0y443nXPtQ1EifSzBVZE6SJjIMXwvEjlvaTcQ7/VOv7ZScYh0SPy5Ki1ZNE6rgp62oCPyAGqMdVmLz1rm+zaujXwsZ8LuUvq84lcGfj7o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762797779; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=vlhjjuVtxnGy9awFTU3LZ3864LgTxBxQtqBOrOQYQxw=; b=bwJJwRguEIjKaIT/OWEsNkaSEXixc89XZSc5u2GEnwfpe58PcZUWWgmDj4O0xSpdPfH6PoJKnXYMi/n7V2PNf+QYc+V7eC5sBIDf1cT3XcuThArpPpAnl3uWF/ZbrWb05HMlZOUqaGOs6p9Oy5T71o6C7Hcw+bkvMYP9Xx2Sqko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762797779259522.9719144630861; Mon, 10 Nov 2025 10:02:59 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A5F1844204; Mon, 10 Nov 2025 13:02:58 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3C52044C41; Mon, 10 Nov 2025 12:58:14 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 30E6F449ED; Mon, 10 Nov 2025 12:57:49 -0500 (EST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 152DF441DE for ; Mon, 10 Nov 2025 12:57:48 -0500 (EST) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b728a43e410so713527266b.1 for ; Mon, 10 Nov 2025 09:57:48 -0800 (PST) Received: from tulp.my.domain (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc214sm1182030966b.52.2025.11.10.09.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 09:57:45 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762797466; x=1763402266; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vlhjjuVtxnGy9awFTU3LZ3864LgTxBxQtqBOrOQYQxw=; b=MgNJ8uRlA2+iUmehRwfAng3DtX4GHJjHVZy6t53dU6ibdweWzMfSBHRBb9fcAuYQaz y0djZJnsxG6RRt1J2tFPhDPQdV0bFoZFPC50T5jgZ5SIUDCglJUvSfivmOHZkNEeIn/M cMqejOzeQNMnsKVzteAcp8lUYuHYZROh6PriBz6/NDmqC01XW+mac8hXnYRwN/oJXcgB xqMZU+oTcLtCp4cKGnwjylabeE2dp870ApB2ViE10NpMoV5pdG4lZNghvRj5BUGOgtyr j4QovU/tm3U1fBgHFgabd64AiSxx8K6of7IXyL6jvpAadpdWqQgwLIFfddZpDG98Jpkv hzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762797466; x=1763402266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vlhjjuVtxnGy9awFTU3LZ3864LgTxBxQtqBOrOQYQxw=; b=WwefpTB67wrN9UT/66NYXngK+M7vtzl3Q0mWZec3lEyx2t6GG2r4Eu9yY1cnYeLsrB hGpDaYuGpzL/4epDIKHPAZkXCk+b2KCZ8MGlrwWjy+Z48BlJfyQIu8JVewQWzd1yoew6 AUEBoKWsEXSDIskLxCmVwmlsiIcbORC/DImsnA/++cDGqdqxVs2Pjj5/bSYE2sV3wcP5 Q117DHTAwNroD+NvzLbSj3UXypwWEkmARzepooJSbkzfsA4t8BYgnB5bY1DWNVDi3rkY qsie57+wgtaDl11PR8MYnp4O5ORcxrGtdAfIEygZhAUIJ5oOtXoAPvldNDbPLhh91k6v 0bDg== X-Gm-Message-State: AOJu0YwRyu5gEM9FYPgEMaWGvkCd1bbMoVAKyh4x+zPBgeC7kulOOv6V p8zoPIjZ+BW+TEpJ6Q0sgNAntW8jIfUlfIvdF5LbRcw4W8JElXBsFn0LXUwunUgfMxyckg== X-Gm-Gg: ASbGncuCE+r6+jNob2J7OnIvPzRdVVBl6JwIz7K1AVPXJ3uXaexhODF33C6GBj1HewV heNw4yRfg0e7PvAmlba45J8ejqL0vh+/FAvsO5MBLVGOvevnuJlKTqTE86bAYK8w+ddulqvexaE M/r9P0aEtHoPo5Q18cNuRA1bUYYcGJhcYIfHTAVmR4Pk0YeDzjU77gfRwvtyvPfmZMm4z731wuL lvOX3EVqQmlz/DivrLy5qLXoGkX8nAaLvmXHnV8okhmqrvZ/pSzaxKhTZ9euRV4/jyMXjO2JzwM VfzGwHREXKiycSWvNpup5aN99NXxLxWmbm81V7yREP4W+JaenEXBq2228voXA2G8nj4+hicQHXO XWMr8xnC2lsPVXHYLwEVbY1sGteuej0ARtD+o3sz8lWi3JeikeRpyAF95CJGsurB2NDTcVtC/zd qYV65SMwLa0seAJtsmK3JstgXWDpuT3bBNUIOeaPjxqGfMEMZlUeyHP8Vis5PIykM2cnw= X-Google-Smtp-Source: AGHT+IHIEw/Q4ly4Y2B6z0OFNySUcpe7G/uD4YYLHjZwFcULZqMrAu4Oy9CcDXDz93d/GUB/kTjsfQ== X-Received: by 2002:a17:907:9706:b0:b40:5752:16b7 with SMTP id a640c23a62f3a-b72e05e83c3mr1033293166b.51.1762797466461; Mon, 10 Nov 2025 09:57:46 -0800 (PST) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 4/4] bhyve: domain: improve disks validation Date: Mon, 10 Nov 2025 18:55:42 +0100 Message-ID: <20251110175542.36724-5-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251110175542.36724-1-bogorodskiy@gmail.com> References: <20251110175542.36724-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RPVKNO6IZYQ5GP36LF4WVMQ52DX4DAMD X-Message-ID-Hash: RPVKNO6IZYQ5GP36LF4WVMQ52DX4DAMD X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1762797780678153000 Content-Type: text/plain; charset="utf-8" Do not allow to configure queues and queue size for non-NVMe disks. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_domain.c | 7 ++++++ .../bhyvexml2argv-disk-virtio-queue-opts.xml | 23 +++++++++++++++++++ tests/bhyvexml2argvtest.c | 1 + 3 files changed, 31 insertions(+) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-disk-virtio-queue= -opts.xml diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 16ca4b1d0f..4c9ed29333 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -316,6 +316,13 @@ bhyveDomainDeviceDefValidate(const virDomainDeviceDef = *dev, return -1; } =20 + if ((disk->queues || disk->queue_size) && + disk->bus !=3D VIR_DOMAIN_DISK_BUS_NVME) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("queue configuration is only valid for NVMe b= us")); + return -1; + } + break; } case VIR_DOMAIN_DEVICE_AUDIO: diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-disk-virtio-queue-opts.x= ml b/tests/bhyvexml2argvdata/bhyvexml2argv-disk-virtio-queue-opts.xml new file mode 100644 index 0000000000..1119c37b2b --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-disk-virtio-queue-opts.xml @@ -0,0 +1,23 @@ + + bhyve + df3be7e7-a104-11e3-aeb0-50e5492bd3dc + 219136 + 1 + + hvm + + + + + + +
+ + + + + +
+ + + diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index f7411ee094..2a785ef8aa 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -267,6 +267,7 @@ mymain(void) DO_TEST_FAILURE("2-nvme-same-controller"); DO_TEST("sata-rotation-rate"); DO_TEST_FAILURE("disk-virtio-rotation-rate"); + DO_TEST_FAILURE("disk-virtio-queue-opts"); =20 /* Address allocation tests */ DO_TEST("addr-single-sata-disk"); --=20 2.51.0