From nobody Fri Nov 21 10:13:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1762797645; cv=none; d=zohomail.com; s=zohoarc; b=khmffgJLitg/YqCBkLFdXQfLrRDH6TuJWox0RuLXE3+VLZpabg5EvzC1D9AQbVs016Bc8uMTMpYCfH4yTmMamxgdfqSxnQ53qiHhDuG6eDv3XWz+q2VCwA3GzZiYFtQb/C6n+vYYzBT08bYxJGz4TftqZrTZtNjm/zgpdfCOrAU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762797645; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=cbab+5BBM97ufGMtkkc0IMq6NOcIrmW/jw1gB7Z+F0U=; b=T3eje4y9KV5bTEHBpvk4S8hVnT6RV8jPJAr78tTvD6cs1cbsF+2wMj4OKcM/98syDHf7duTf7tIqZduMSNf6Wqtcb8m8TLWSYlqndeJXRQaL8RL+rc3AXAr45e3RL1QCAqbKxdwa5GSDcrp8RLQPAIdnrYTLFKrabXZCMnKW5SA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762797645640889.009746970456; Mon, 10 Nov 2025 10:00:45 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9031144A87; Mon, 10 Nov 2025 13:00:44 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8F7FF44BD5; Mon, 10 Nov 2025 12:58:05 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id F23D0449C8; Mon, 10 Nov 2025 12:57:46 -0500 (EST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4A090448F0 for ; Mon, 10 Nov 2025 12:57:46 -0500 (EST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b403bb7843eso602712066b.3 for ; Mon, 10 Nov 2025 09:57:46 -0800 (PST) Received: from tulp.my.domain (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc214sm1182030966b.52.2025.11.10.09.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 09:57:43 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762797464; x=1763402264; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cbab+5BBM97ufGMtkkc0IMq6NOcIrmW/jw1gB7Z+F0U=; b=ZOBJxL2GaRZwEbtgf+tc4yua2H/k0BQdCrjomNAwAiS2x2ddB8In+H6aE3gy2jlpzh MFNTXH5to9vMZKswddkceuYH3FTVCbgyTF47YNfrniH7UzyaATZybA1WQufWFqPkLoL0 MT2j49HbvX61L0ZoNfyyLKUi7LZ3bJ2dF8HtjpGRFfROaWkzuYe6Ou9/9SNHmPWfV3l/ n6bzSGl/4K/d9TRBtpwaVPtosVeC5E3bovk1pS49sk6pc/AzvEV2CrBfuzq3bJFsz/JT 6t5n24wgRZpB59YvMw7Xzyu9T9Y/p54Y8ygclGFOkrJN0NlFGeB8NMjICq056sm7U0q2 h20A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762797464; x=1763402264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cbab+5BBM97ufGMtkkc0IMq6NOcIrmW/jw1gB7Z+F0U=; b=oZ9dsqo6jLzgi6kN2G7tZ3pWLuZReToC3ePLPUnqQSVtZwTEUKYykxrzXN8emqIyPV kRN50fYpNzWMDtLA2yoAGgwC20w7TQFobW6QLTFrJrBihFp+IM/tO8ZtG5zmSuKAZIpq +lJIdeWzBR+vymBkg6JFJlVEoF2RZKBKx1UcgKCIrtfB3rV1+OdYwsz83AVSkNGfYowi vin3SJ8bFCDdh+KUNZgB4PNNgXI/78ASPIqys84HcrrGQq/Zvv2GOcm/33qQ+Wcd5vfx ys5234/KFFy9/2ZUWPgw9WBogIXIX9Wzkd9645wa9gUcaEh/1xgETRxhPRtJEy+Ms4hC Krow== X-Gm-Message-State: AOJu0YzDOAJLiB4xW5/RFW7SD6h7JjrZDUC2QQoc6Mt5eulMM+F9gNg0 u9zzBoibqJvj9cJOavKwef2ys55/1CuaJaT6pgLAes7gM0cm0r9DktI57Ck03xVUu5WSKA== X-Gm-Gg: ASbGncuTeUkO8EngM8MrRWgYuY8p49qg0iBpYkxxiTPCBOBJLq7ZhcKCIcbIR0L2GfJ j/G5PlkFJrvtgbdX7YY2UMe0pYT/2NjGytmoULH5TxA5a4wuerBTQcpKbPYb4iGQgvxR73a2Fpb 30NwsKj2+BqFr+LrTw6RPrLihaqf4ea+FJC71X9664hvu/tOkixNTkCBN20wG24GumJUeE8sbtB wTr0eQ2b7Z8i1MfAOUYo6P7863uYTKAJeF6tLshb5B43NuBOpjfG2zVi3bWq0Q5psf7DlFyZeR5 MiZIirRT9cbQb+IXhTtmHBuybICu8h3YjkKb2TuqqTcOHN5YZ0sgGOOlKKkvnPhG7Gn67m7jM7y sNtYN8JV8kgmNqZEsQOXzwrTz2vSevwxwMcHJXlSy2JFsjAafZyzDbynsaAPqLVRlLZFgvRUGmh AeN1Gqo2Ne2cLBbUvE63cshwBRaxqPvwwoDvEOM+lZoLXwvHzqp2ObEtguFq57x+MJXFE= X-Google-Smtp-Source: AGHT+IEKjFyssR0chii264E6nlzSlVlOWTjtrJN+0wx6cXeNc703mlcYOIZdoRPRmrIlQl9hGK6oGg== X-Received: by 2002:a17:906:6a11:b0:b72:5bdf:6093 with SMTP id a640c23a62f3a-b72e030473bmr728980266b.23.1762797464145; Mon, 10 Nov 2025 09:57:44 -0800 (PST) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/4] bhyve: support queue configuration for NVMe disks Date: Mon, 10 Nov 2025 18:55:40 +0100 Message-ID: <20251110175542.36724-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251110175542.36724-1-bogorodskiy@gmail.com> References: <20251110175542.36724-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IJK4UYB6OTSKSA75RVBBQPAM4ZOYAQYH X-Message-ID-Hash: IJK4UYB6OTSKSA75RVBBQPAM4ZOYAQYH X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1762797646317158500 Content-Type: text/plain; charset="utf-8" bhyve supports queue configuration for the NVMe disks: maxq Max number of queues. qsz Max elements in each queue. Map that to the disk driver's "queues" and "queue_size" attributes respectfully, so: results in: -s N:0,nvme,/tmp/disk.img,maxq=3D2,qsz=3D256 Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 16 ++++++++++++++-- tests/bhyvexml2argvdata/bhyvexml2argv-nvme.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-nvme.xml | 2 +- .../bhyvexml2xmloutdata/bhyvexml2xmlout-nvme.xml | 2 +- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 0ceac618e8..8bfd5a6f93 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -371,6 +371,9 @@ bhyveBuildNVMeControllerArgStr(const virDomainDef *def, size_t i; =20 for (i =3D 0; i < def->ndisks; i++) { + g_autofree char *nvme_opts =3D NULL; + + g_auto(virBuffer) opt =3D VIR_BUFFER_INITIALIZER; virDomainDiskDef *disk =3D def->disks[i]; =20 if (disk->bus !=3D VIR_DOMAIN_DISK_BUS_NVME) @@ -389,10 +392,19 @@ bhyveBuildNVMeControllerArgStr(const virDomainDef *de= f, =20 disk_source =3D virDomainDiskGetSource(disk); =20 + if (disk->queues) + virBufferAsprintf(&opt, ",maxq=3D%d", disk->queues); + if (disk->queue_size) + virBufferAsprintf(&opt, ",qsz=3D%d", disk->queue_size); + + nvme_opts =3D virBufferContentAndReset(&opt); + virCommandAddArg(cmd, "-s"); - virCommandAddArgFormat(cmd, "%d:0,nvme,%s", + virCommandAddArgFormat(cmd, "%d:0,nvme,%s%s", controller->info.addr.pci.slot, - disk_source); + disk_source, + NULLSTR_EMPTY(nvme_opts)); + } =20 return 0; diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.args b/tests/bhyvex= ml2argvdata/bhyvexml2argv-nvme.args index bd39db1fe6..80877717f2 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.args +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.args @@ -5,5 +5,5 @@ bhyve \ -H \ -P \ -s 0:0,hostbridge \ --s 2:0,nvme,/tmp/freebsd.img \ +-s 2:0,nvme,/tmp/freebsd.img,maxq=3D2,qsz=3D256 \ bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.xml b/tests/bhyvexm= l2argvdata/bhyvexml2argv-nvme.xml index 8daaa11e85..5401ed6ad8 100644 --- a/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.xml +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-nvme.xml @@ -8,7 +8,7 @@ - + diff --git a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-nvme.xml b/tests/bhy= vexml2xmloutdata/bhyvexml2xmlout-nvme.xml index d4ab69b15f..40a1ea1c5e 100644 --- a/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-nvme.xml +++ b/tests/bhyvexml2xmloutdata/bhyvexml2xmlout-nvme.xml @@ -14,7 +14,7 @@ destroy - +
--=20 2.51.0