From nobody Fri Nov 21 10:11:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762440890; cv=none; d=zohomail.com; s=zohoarc; b=ODrp2rMi6aCCKXObBKrAx7p2X1FsRmbzdHLXHshWpiJLNm2mPMyvDTA3LMapiu+bj7DKQT7fOpff9Dzx4OIFeyJBxoOf/8T/F0l/caE6QMYQboBuPkWbNblEPmXvZ/wAmWxQ3aEEidKU0Kh3GNYSNJcT6JpJwsU3ef1p+AG453k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762440890; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=NncVV7PlF1uzQTurF9tZ53W0FcqUFjHJ7UYs/X141rI=; b=DBM6WBbr87AM6MbrUN8y63gX4Ow/UTS6kkuXugrT6o1fgNAtY5qfTgN44uSaIT5pnfYI1Lk7ypcLRyYe6Jmvb17MCX46g2huA9KpNinoJEyvQTRs7p3hKjoNshDIrI32B9v5x8aM61dCpOTTiaf2183hY5cV6adXyufh7iZkowU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762440890593346.9715208566158; Thu, 6 Nov 2025 06:54:50 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id EF71544377; Thu, 6 Nov 2025 09:54:49 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 6D5FA44265; Thu, 6 Nov 2025 09:51:58 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DEEF4418F9; Thu, 6 Nov 2025 09:50:59 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DCA6941988 for ; Thu, 6 Nov 2025 09:50:58 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-dOxMzxfiPAG_sTSAAN0byg-1; Thu, 06 Nov 2025 09:50:56 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64F4C1956070 for ; Thu, 6 Nov 2025 14:50:55 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.39]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 855CB1800451; Thu, 6 Nov 2025 14:50:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762440658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NncVV7PlF1uzQTurF9tZ53W0FcqUFjHJ7UYs/X141rI=; b=W7QS7Vmuyl+8Ngzow9iM0JtBs7ZdtSu3xW7sT8bEOBFAUXtuMaW3ZyzFBE3it8a6yVPpe4 Lg7ObX2JJ3KHiWJCsCPsc83DLVZTqUOGteC10t9rz2R575hkMIqKQeH76Jo5LHI8Y02EM1 3bRm5D/fzhmXlw+QH4V+vPjBNWl9Y7Y= X-MC-Unique: dOxMzxfiPAG_sTSAAN0byg-1 X-Mimecast-MFC-AGG-ID: dOxMzxfiPAG_sTSAAN0byg_1762440655 To: devel@lists.libvirt.org Subject: [PATCH 02/10] rpc: change 'isServer' parameter from 'int' to 'bool' Date: Thu, 6 Nov 2025 14:50:42 +0000 Message-ID: <20251106145050.1851526-3-berrange@redhat.com> In-Reply-To: <20251106145050.1851526-1-berrange@redhat.com> References: <20251106145050.1851526-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kk2aqI8h1sLnN3vYPjcdvvLq4JFEQEz4MQyy8nowV-4_1762440655 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4HZESDOODK24FN5EL5I7HKYHYHEFXFW5 X-Message-ID-Hash: 4HZESDOODK24FN5EL5I7HKYHYHEFXFW5 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762440892997154100 From: Daniel P. Berrang=C3=A9 The callers are all passing in a 'bool' value, and this type should be maintained rather than cast to 'int' and then inpreted as a bool again later. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/rpc/virnettlsconfig.c | 14 +++++++------- src/rpc/virnettlsconfig.h | 13 +++++++------ 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/rpc/virnettlsconfig.c b/src/rpc/virnettlsconfig.c index d020083d6a..ffab3b4fc8 100644 --- a/src/rpc/virnettlsconfig.c +++ b/src/rpc/virnettlsconfig.c @@ -49,7 +49,7 @@ static void virNetTLSConfigTrust(const char *cacertdir, VIR_DEBUG("TLS CA CRL %s", *cacrl); } =20 -static void virNetTLSConfigIdentity(int isServer, +static void virNetTLSConfigIdentity(bool isServer, const char *certdir, const char *keydir, char **cert, @@ -102,7 +102,7 @@ void virNetTLSConfigSystemTrust(char **cacert, } =20 void virNetTLSConfigCustomIdentity(const char *pkipath, - int isServer, + bool isServer, char **cert, char **key) { @@ -114,7 +114,7 @@ void virNetTLSConfigCustomIdentity(const char *pkipath, key); } =20 -void virNetTLSConfigUserIdentity(int isServer, +void virNetTLSConfigUserIdentity(bool isServer, char **cert, char **key) { @@ -129,7 +129,7 @@ void virNetTLSConfigUserIdentity(int isServer, key); } =20 -void virNetTLSConfigSystemIdentity(int isServer, +void virNetTLSConfigSystemIdentity(bool isServer, char **cert, char **key) { @@ -143,7 +143,7 @@ void virNetTLSConfigSystemIdentity(int isServer, } =20 void virNetTLSConfigCustomCreds(const char *pkipath, - int isServer, + bool isServer, char **cacert, char **cacrl, char **cert, @@ -161,7 +161,7 @@ void virNetTLSConfigCustomCreds(const char *pkipath, key); } =20 -void virNetTLSConfigUserCreds(int isServer, +void virNetTLSConfigUserCreds(bool isServer, char **cacert, char **cacrl, char **cert, @@ -182,7 +182,7 @@ void virNetTLSConfigUserCreds(int isServer, key); } =20 -void virNetTLSConfigSystemCreds(int isServer, +void virNetTLSConfigSystemCreds(bool isServer, char **cacert, char **cacrl, char **cert, diff --git a/src/rpc/virnettlsconfig.h b/src/rpc/virnettlsconfig.h index 797b3e3ac5..a9378c18b7 100644 --- a/src/rpc/virnettlsconfig.h +++ b/src/rpc/virnettlsconfig.h @@ -20,6 +20,7 @@ =20 #pragma once =20 +#include "internal.h" #include "configmake.h" =20 #define LIBVIRT_PKI_DIR SYSCONFDIR "/pki" @@ -39,29 +40,29 @@ void virNetTLSConfigSystemTrust(char **cacert, char **cacrl); =20 void virNetTLSConfigCustomIdentity(const char *pkipath, - int isServer, + bool isServer, char **cert, char **key); -void virNetTLSConfigUserIdentity(int isServer, +void virNetTLSConfigUserIdentity(bool isServer, char **cert, char **key); -void virNetTLSConfigSystemIdentity(int isServer, +void virNetTLSConfigSystemIdentity(bool isServer, char **cert, char **key); =20 =20 void virNetTLSConfigCustomCreds(const char *pkipath, - int isServer, + bool isServer, char **cacert, char **cacrl, char **cert, char **key); -void virNetTLSConfigUserCreds(int isServer, +void virNetTLSConfigUserCreds(bool isServer, char **cacert, char **cacrl, char **cert, char **key); -void virNetTLSConfigSystemCreds(int isServer, +void virNetTLSConfigSystemCreds(bool isServer, char **cacert, char **cacrl, char **cert, --=20 2.51.1