From nobody Fri Nov 21 10:17:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761978521; cv=none; d=zohomail.com; s=zohoarc; b=ZOuNs29SPuwsy6ohupf2POG4tqEyebgjDuIcdvbnApnWXI8v87CbrGCFRhv4nOZADoRddYxPj020EYkLuwx6RmNJ7uiXBLZmOsRyV6rMb++DefCX+r77Vcsp0NdaOno0JCJerzvZMz1QSXdNXvljKhHa3iULsKge5lKzBwhjpCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761978521; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=qRYYDOrWRYlhkcBKHF+fVmbpUxw/3I4D5Ji5IYDelTQ=; b=aHxO6V9zSgvMGUHjgaB9mUdrAWPQZzkLorsgEkSLhULwvmD6kQzrlb+uMyLN0SCjUN+0Vtn+EqcBCiGer+DlhEOm7MndKE7nhLFVh6EIQBRhPPHH66hNN1W5+t7D4D9vFjddPYvD9qpY8YOQv6W9lpvT68CzYHSOy95XFRj14tA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1761978521264732.9689878388684; Fri, 31 Oct 2025 23:28:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6EA1D43E91; Sat, 1 Nov 2025 02:28:40 -0400 (EDT) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 2D2D043E9C; Sat, 1 Nov 2025 02:26:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5AD9641BC1; Sat, 1 Nov 2025 02:26:07 -0400 (EDT) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 681ED43F72 for ; Sat, 1 Nov 2025 02:26:02 -0400 (EDT) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b4736e043f9so499158166b.0 for ; Fri, 31 Oct 2025 23:26:02 -0700 (PDT) Received: from tulp.my.domain (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7077975e18sm371807166b.2.2025.10.31.23.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 23:25:59 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761978360; x=1762583160; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qRYYDOrWRYlhkcBKHF+fVmbpUxw/3I4D5Ji5IYDelTQ=; b=Y27ya7zdwZbCY51ukqlaL96iGoMtC6NRHU9KFCeiEUJLcpUoVKkdI2x08yOXE2Zheb ifEiwx/NWgFhtxSeMMUpY0mgpUzBRrgqNzTNsZHLbaS4uEXKXAqfF/rwYI0hoVxMNAi0 oskP77Z2+R4XesCpO9/hAHxfAgpvIPsGxiBjv/J7VttQiIV/M17o4TWQ7h7ptq7FBfvb AQxiRLCbJlM6BUj7bu81W4llncRBJ9F+vs5AW+BHb/qjwo+FoY/afJTsKKDWkS1J9muF SADifTLz4fN5w4tRqj/4lzwpF064quWnqbaPF4yUUMpl6nD9jGzsjAjcYq2Vaey7RDh0 +aAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761978360; x=1762583160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qRYYDOrWRYlhkcBKHF+fVmbpUxw/3I4D5Ji5IYDelTQ=; b=udFREFZB8TltYEkKIJPPEUf7E2Y69O25ZLSehTY+znksVyoaHXSHJMU1SAeO08IUUQ XexqMIoCGjvpYGzEBuBbatnrLtf5Pc1W1DuYff61vc9BoGil2IJDKd6pcN7+zwb8SwtT 6pziroiEaBAQnM7eR0IZrzjOBn6bMC7mOg51ltJFFRje+KyD9H3fQmWWPxLOkMOhNkg+ kR4FzkaMgdc7Cx64Rl+TKj83AAM4P7PTkUKBWpqc0TTChZ80IxnusP+TFurzbGD9nEpY jw7jAm6plSwFEV/npIVT6+j4ijbIRqrO8pQ4KcZt40C48b0ljsV/bkVjoeQA2+9Gfesf yzZA== X-Gm-Message-State: AOJu0Yy3+mRk9P86DGlKrmFO4pQqdaWKRncxTtruchjr97HjSFM/XaNk 9qOtuScfi1tDWAYa95Je59Iw0JnV3TtBP68E4pNgpCiEN9X+cJrEDKx08M5lP/H48yhW3w== X-Gm-Gg: ASbGnctKJfFYmxoQlMrxV0hbKrVXLiVHzE25Xb3LLeNFiae1Jag1Q+Q8MgPnHZu40rX VYF+OCQYlR9uAWPjKOk4pwOTLGIObQ/BQt4TWeHHHoA5SfBsX5qzdvYfgcjuxlt6O+q1SLgFWIk HQNmt9AA8+z9THUo+4nLlUJxefh9odk1JJbyaafKhOPRJhaeQ69Qmp1WNivUYfWvRwjuAronA5H tWaJ+Gnc1jDsc57RhYdSlZRlx4MFL9WPgPHt502c84gwWn2VCeJCSKJX48Gxd8YPLLWrR148DTu v3cuOpte1wH+KFA4RaIKZ6V0rVkEJ4EjMomVAyYuK7f0MICFd52k3f239m8fWdnoQEt0gyOm0Yt OmZzoASIhmXCCKsd5zajyU/ssopv4EpryvR2ESKSO8/mhBVz/m1wotA3094WadYTthyrVV+GlaA ReKyJ5M5TWUrCZMu2maDlNcNEwFlBxsiequWiyYjEhls2uYg== X-Google-Smtp-Source: AGHT+IFELzb/7jW8cvnSeLVp67UoVPE6cOkxNY8Rmhk/ysQEPb6LKW7+REgCts10tgR3xoRfFmkNIA== X-Received: by 2002:a17:907:3d0e:b0:b3e:f89e:9861 with SMTP id a640c23a62f3a-b70701ac51amr597788066b.28.1761978360321; Fri, 31 Oct 2025 23:26:00 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/4] bhyve: Support passing the 'passthru' command line option Date: Sat, 1 Nov 2025 07:24:21 +0100 Message-ID: <20251101062424.57331-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251101062424.57331-1-bogorodskiy@gmail.com> References: <20251101062424.57331-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PBOQC2ASS2NAA4RYC4DXIKOBHYQZ75ZI X-Message-ID-Hash: PBOQC2ASS2NAA4RYC4DXIKOBHYQZ75ZI X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alexander Shursha , Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761978523970154100 Content-Type: text/plain; charset="utf-8" From: Alexander Shursha Bhyve supports PCI device passthrough using the following syntax: bhyve ... -s 4:0,passthru,5/2/0 ... Where 5/2/0 is PCI address of the device in the host, and "4:0" is the address in the guest. Currently, user is responsible for reserving the device for passthrough, i.e. by configuring pptdevs in loader.conf(5), or using devctl(8) to detach the device. Co-authored-by: Roman Bogorodskiy Signed-off-by: Alexander Shursha --- src/bhyve/bhyve_command.c | 27 ++++++++++++++++ src/bhyve/bhyve_domain.c | 6 ++++ .../bhyvexml2argv-passthru.args | 10 ++++++ .../bhyvexml2argv-passthru.ldargs | 4 +++ .../bhyvexml2argv-passthru.xml | 31 +++++++++++++++++++ tests/bhyvexml2argvtest.c | 1 + 6 files changed, 79 insertions(+) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-passthru.xml diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 4c5b4518ea..4224cdf0fc 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -3,6 +3,7 @@ * * Copyright (C) 2014 Roman Bogorodskiy * Copyright (C) 2025 The FreeBSD Foundation + * Copyright (C) 2024-2025 Future Crew, LLC * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -216,6 +217,29 @@ bhyveBuildRNGArgStr(const virDomainDef *def G_GNUC_UNU= SED, return 0; } =20 +static int +bhyveBuildHostdevArgStr(const virDomainDef *def, virCommand *cmd) +{ + size_t i; + + for (i =3D 0; i < def->nhostdevs; i++) { + virDomainHostdevDef *hostdev =3D def->hostdevs[i]; + virDomainHostdevSubsys *subsys =3D &hostdev->source.subsys; + + if (hostdev->mode !=3D VIR_DOMAIN_HOSTDEV_MODE_SUBSYS || + subsys->type !=3D VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) + continue; + virCommandAddArg(cmd, "-s"); + virCommandAddArgFormat(cmd, "%d:%d,passthru,%d/%d/%d", + hostdev->info->addr.pci.slot, + hostdev->info->addr.pci.function, + subsys->u.pci.addr.bus, + subsys->u.pci.addr.slot, + subsys->u.pci.addr.function); + } + return 0; +} + static int bhyveBuildAHCIControllerArgStr(const virDomainDef *def, virDomainControllerDef *controller, @@ -940,6 +964,9 @@ virBhyveProcessBuildBhyveCmd(struct _bhyveConn *driver,= virDomainDef *def, virCommandAddArg(cmd, bhyvecmd->args[i]); } =20 + if (bhyveBuildHostdevArgStr(def, cmd) < 0) + return NULL; + virCommandAddArg(cmd, def->name); =20 return g_steal_pointer(&cmd); diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 3c7997ad86..63d61b9f85 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -345,6 +345,12 @@ bhyveDomainDefValidate(const virDomainDef *def, } } =20 + if (def->nhostdevs && !def->mem.locked) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("using passthrough devices requires locking guest= memory")); + return -1; + } + if (!def->os.loader) return 0; =20 diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.args b/tests/bh= yvexml2argvdata/bhyvexml2argv-passthru.args new file mode 100644 index 0000000000..2ff43ad3b1 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.args @@ -0,0 +1,10 @@ +bhyve \ +-c 1 \ +-m 214 \ +-S \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 7:0,passthru,3/0/0 \ +bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.ldargs b/tests/= bhyvexml2argvdata/bhyvexml2argv-passthru.ldargs new file mode 100644 index 0000000000..5905f4b3e6 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.ldargs @@ -0,0 +1,4 @@ +bhyveload \ +-m 214 \ +-d /tmp/freebsd.img \ +bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.xml b/tests/bhy= vexml2argvdata/bhyvexml2argv-passthru.xml new file mode 100644 index 0000000000..02c932f62b --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-passthru.xml @@ -0,0 +1,31 @@ + + bhyve + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219136 + 219136 + + + + 1 + + hvm + + + destroy + destroy + destroy + + + + + +
+ + + +
+ +
+ + + diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 6837db2c7a..5d234b39fa 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -222,6 +222,7 @@ mymain(void) DO_TEST("serial-grub"); DO_TEST("localtime"); DO_TEST("net-e1000"); + DO_TEST("passthru"); DO_TEST("uefi"); DO_TEST("uefi-nvram"); DO_TEST("uefi-nvram-template-set"); --=20 2.51.0