From nobody Fri Dec 12 15:15:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761652801; cv=none; d=zohomail.com; s=zohoarc; b=WolENotTMb6kGhTmRpYB5SEc6c+jVkwq83GFnwVTpAclQE4fe9wIo/mMLzUNbkFXw4A1rDnr1YcD2H0hZH3EGyg/Kv33ebAT6LMYqxJnYiFFHxotaUNnLS7dZM+OvoAK3rg2cJfv1V5ehK0tDBkc1X9gf8Uo+vbgpIT+hEbH5ww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761652801; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=qmnxPQ68YQjaeFSZVnjz1fkGX7t9Rxzh3ZJfDUhqFHw=; b=l+trVxbRSQLLWuM4j/IjNS374ryc9oy1+UykOsH1jfSp0+40pgNPF5G9KZAbdasoqEu2WtI3lgdLZZ1Gcx/FOuF8f+bFL8L4A3jRoXFVIrbS4WKeE02h5G051yk5PeDhrHh3APLLoKqJvKBFaWOiMwW+vlTZ80aR/SHUGsjUCnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176165280108146.35315020243081; Tue, 28 Oct 2025 05:00:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0400841830; Tue, 28 Oct 2025 07:59:37 -0400 (EDT) Received: from [172.19.199.25] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 22CDD4192F; Tue, 28 Oct 2025 07:58:30 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3211E46562; Sat, 25 Oct 2025 04:18:05 -0400 (EDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D82C146564 for ; Sat, 25 Oct 2025 04:18:04 -0400 (EDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b6d83bf1077so122950966b.3 for ; Sat, 25 Oct 2025 01:18:04 -0700 (PDT) Received: from tulp.my.domain (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d85398463sm139688766b.34.2025.10.25.01.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 01:18:02 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761380283; x=1761985083; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qmnxPQ68YQjaeFSZVnjz1fkGX7t9Rxzh3ZJfDUhqFHw=; b=Cd9PNXKvWOo8cEcsmOdCnFitQnhxLokQpM3gl5MjtPUNxSUAsp5R1oFk8LIwoy/j+n 5BbjeS1mxjaXwqvegRDgOqz987kq1KO2TNyQ+ipBbgoraS7QerI6QCpOjswR8uumMK2H +cQ5J9bFIuW5rOfoHLeOTBUHd+kt3fL9coi42nDP4xAOPtEWKIG1vXnGUkiPu+MMfP9v 7/0m5xHFP2U5D5YnZXUwctzsqV8uxZsd4RWvL9mAw2LK/gd2IdmdZxYDm8gf1zvFi+rn xas25aUzpEDmhnJWN66v50anZ0WMwSxpiHmu3jPv01klkHAhm0gnW94YsJgdgPFTtsap Z0LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761380283; x=1761985083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qmnxPQ68YQjaeFSZVnjz1fkGX7t9Rxzh3ZJfDUhqFHw=; b=aGrtbHFRyfARyJqv95E2bqDWqPbTBlXl+64UlE53rr1oy4JvBQcSiXMhLn1qiM2rLf ciSidbRd686ap0l+qQWy9ehCxc/HiylVqc3BjmyN1dSGhcrQFGZbFf8DgFod0KJ1RcyZ mkWkhpYB1AufnGOEIriHEK/YpLDEYEcoVnWOmK4bri/siKaZQAmXdEu9YUnI5/FUYh5x Xdr4QI0/tDxYAB9SfjydAjAj1YN3KkdU2fuor5fG+/J13CLNvfi6eyjV+7HIHhOvr10R qTy94muRmCQGv1JwMMAYejUeZLURFVmIbS4kMX7W6mgRQvBNb8XRVnNEiNOfuclVT9Do f0cA== X-Gm-Message-State: AOJu0Yz/gGwNCcyzi9dICh37sxXU6s2LnGvd4A1kf1DCfdcX2d9VRIDC sDsrO0yqWybqf67U7bHI2b5F0knJBYEUBldpZfE3qkY3ul9PPD6bWgTpOjHZAcnZgRlsvA== X-Gm-Gg: ASbGncsalEhiqx9X4Gr8yfq6sBRSNTcsDtPGcD/VGoj5oFDh7Y1WMEavK/sxxiTlmyh t88puX7dl0BM6MWTSZ4OALxQCH7S/Uf1U460fJSXrdD+H9ExaMO1T+WXe1hhW0ReAx7o6N9pHHq +fTU1MUxPaikFqcCyLK1tqwe76/JgywxqaqTSqZrYntKYhFXQ3PQ2e6Z+niXIVmZaI+vELXE6qk +QEPjOeX2EnWz/+iZIzPLEG28eAC1eLs/wf4dmO99k0B//rzTbmGZG98GeJ6kBg4E5p6PfpsEiC FeXvffVyer4NjGoi6+H+lgdoFc/awW4KZDn6YAr+/nsB+64R+KJoJR9cfJvFcXb6DYKIUPA6t7I YvZFi8oZ87IOrBch6vOIbb/wdODkVNAk/wtscq670Mcz+T+YgM4RYKcGoDdFE2L0CH6gz7l9qii nBJNNORwwgj/kxzpWDTjESKy4DkiC2XZMHUbZsvbhngNG/bs6lqw5czuAJ X-Google-Smtp-Source: AGHT+IEa2u1/N7BtAXoCPvoirFwXy5FpwVyC17KmqZjX6zdpZEoG4xe4s4UwkLeeK3f0MbdWA1cp/A== X-Received: by 2002:a17:907:3f12:b0:b6d:5718:d43f with SMTP id a640c23a62f3a-b6d5718d7b1mr881705466b.39.1761380283319; Sat, 25 Oct 2025 01:18:03 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 4/4] bhyve: nvme: check if NVMe is supported by bhyve Date: Sat, 25 Oct 2025 10:15:58 +0200 Message-ID: <20251025081558.18715-5-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251025081558.18715-1-bogorodskiy@gmail.com> References: <20251025081558.18715-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GTYMW5WP3HUE6ZBJJMLTARWSQXQTJKXF X-Message-ID-Hash: GTYMW5WP3HUE6ZBJJMLTARWSQXQTJKXF X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761652802115158500 Content-Type: text/plain; charset="utf-8" For domains using NVMe disks make sure that the bhyve binary supports that by checking capabilities. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 8 +++++++- tests/bhyvexml2argvtest.c | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 9f2d02b484..14d07909ae 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -331,7 +331,7 @@ bhyveBuildUSBControllerArgStr(const virDomainDef *def, static int bhyveBuildNVMeControllerArgStr(const virDomainDef *def, virDomainControllerDef *controller, - struct _bhyveConn *driver G_GNUC_UNUSED, + struct _bhyveConn *driver, virCommand *cmd) { g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; @@ -344,6 +344,12 @@ bhyveBuildNVMeControllerArgStr(const virDomainDef *def, if (disk->bus !=3D VIR_DOMAIN_DISK_BUS_NVME) continue; =20 + if (!(bhyveDriverGetBhyveCaps(driver) & BHYVE_CAP_NVME)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Bhyve version does not support NVMe")); + return -1; + } + if (disk->info.addr.drive.controller !=3D controller->idx) continue; =20 diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 3c6d530f66..eb4a1eb2fd 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -311,6 +311,9 @@ mymain(void) driver.bhyvecaps &=3D ~BHYVE_CAP_VNC_PASSWORD; DO_TEST_FAILURE("vnc-password"); =20 + driver.bhyvecaps &=3D ~BHYVE_CAP_NVME; + DO_TEST_FAILURE("nvme"); + driver.config->bhyveloadTimeout =3D 300; driver.config->bhyveloadTimeoutKill =3D 20; DO_TEST("bhyveload-timeout"); --=20 2.51.0