From nobody Sun Oct 5 01:50:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1758824492; cv=none; d=zohomail.com; s=zohoarc; b=B7OdIQPOqEXfGfuJUzsJDyGgSYgvKArb2camWk97bwZ1btGeMIBpQnt1tZ+1o8PyjVQIsM6GKVjoXk84H3mUC+m07HVQ1CbZXBL9JpeuEU5uod8almMCNrTGubbu243qYXn+h9t6df0LN39jmng4faDfnpFs1cIj3uC0L25Zkbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758824492; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=AwsqyU+/OTxoXP7b7/005IuibjftX/hexa6lOEHMAFY=; b=dO6FbWVUOP6mY6owptsv+6U3xQ8Y4d8TEP2c40piIm/8+J/rvCPM4UpsxA2I5jvS1ijZUCT+DoYhYFndx0WPHVvoK4yytVvnOkONPqnYftS02V9nV8wKkKbvvz1NkV4JwPPaluc0N8tNOHp8iNC15VsO3E8pv4cqyKvalJTcETo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1758824492799835.0153085792165; Thu, 25 Sep 2025 11:21:32 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E220844A50; Thu, 25 Sep 2025 14:21:31 -0400 (EDT) Received: from [172.19.199.14] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3D7ED43F7E; Thu, 25 Sep 2025 14:08:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 74327440F7; Thu, 25 Sep 2025 14:07:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B2B4343FAB for ; Thu, 25 Sep 2025 14:07:39 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-S7w89P21OyGFVvKl2ZcaVQ-1; Thu, 25 Sep 2025 14:07:37 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0433D19774DD for ; Thu, 25 Sep 2025 18:07:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.225.196]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30D0F30002D2 for ; Thu, 25 Sep 2025 18:07:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758823659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwsqyU+/OTxoXP7b7/005IuibjftX/hexa6lOEHMAFY=; b=Blzur3TjkMoWP+3tmAz7R/ITqfoe0ynI8BM7GOuK5wONcwivAa1mi6BbwtSDWe97u9qk5A ygD4CUbhDxeTbK0tPcwkHANUmYPn47ouRHz6M3lLSHFmqXkEZBVbSz+XGzZiE3/6ghvbF6 jWuJp1NDEkyDzNuSTHkv+HfbfloN5KY= X-MC-Unique: S7w89P21OyGFVvKl2ZcaVQ-1 X-Mimecast-MFC-AGG-ID: S7w89P21OyGFVvKl2ZcaVQ_1758823657 To: devel@lists.libvirt.org Subject: [PATCH v2 06/38] tests: Rename usb-controller-implicit-* Date: Thu, 25 Sep 2025 20:06:52 +0200 Message-ID: <20250925180724.500758-7-abologna@redhat.com> In-Reply-To: <20250925180724.500758-1-abologna@redhat.com> References: <20250925180724.500758-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zWbG8O-q-vSKh9wfvRimPhsV9mYx8Csce10UegFJ_7A_1758823657 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VDGGC2M3R43TN2FJUPEXHT2HXJDMTHKA X-Message-ID-Hash: VDGGC2M3R43TN2FJUPEXHT2HXJDMTHKA X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1758824494891116600 Content-Type: text/plain; charset="utf-8"; x-default="true" To usb-controller-automatic-*. This matches the existing q35 test, and in general makes more sense as a name since these tests are providing coverage for USB controllers getting automatically added by libvirt for new domains, rather than implicit (i.e. built-in, non-removable) devices. Note that, in the case of physical i440fx machines, the USB controller is actually part of the chipset and would thus qualify as implicit; the corresponding QEMU machine type, however, allows for it to be removed, so the new name is still more appropriate when discussing virtual hardware. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Peter Krempa --- ...s =3D> usb-controller-automatic-i440fx.x86_64-latest.args} | 0 ...ml =3D> usb-controller-automatic-i440fx.x86_64-latest.xml} | 0 ...licit-i440fx.xml =3D> usb-controller-automatic-i440fx.xml} | 0 ...gs =3D> usb-controller-automatic-isapc.x86_64-latest.args} | 0 ...xml =3D> usb-controller-automatic-isapc.x86_64-latest.xml} | 0 ...mplicit-isapc.xml =3D> usb-controller-automatic-isapc.xml} | 0 ...args =3D> usb-controller-automatic-q35.x86_64-latest.args} | 0 ...t.xml =3D> usb-controller-automatic-q35.x86_64-latest.xml} | 0 ...er-implicit-q35.xml =3D> usb-controller-automatic-q35.xml} | 0 tests/qemuxmlconftest.c | 6 +++--- 10 files changed, 3 insertions(+), 3 deletions(-) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.x86_64-latest= .args =3D> usb-controller-automatic-i440fx.x86_64-latest.args} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.x86_64-latest= .xml =3D> usb-controller-automatic-i440fx.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.xml =3D> usb-= controller-automatic-i440fx.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.= args =3D> usb-controller-automatic-isapc.x86_64-latest.args} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.= xml =3D> usb-controller-automatic-isapc.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.xml =3D> usb-c= ontroller-automatic-isapc.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.ar= gs =3D> usb-controller-automatic-q35.x86_64-latest.args} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.xm= l =3D> usb-controller-automatic-q35.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.xml =3D> usb-con= troller-automatic-q35.xml} (100%) diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-i440fx.x86_64-la= test.args b/tests/qemuxmlconfdata/usb-controller-automatic-i440fx.x86_64-la= test.args similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-i440fx.x86_64-lat= est.args rename to tests/qemuxmlconfdata/usb-controller-automatic-i440fx.x86_64-late= st.args diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-i440fx.x86_64-la= test.xml b/tests/qemuxmlconfdata/usb-controller-automatic-i440fx.x86_64-lat= est.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-i440fx.x86_64-lat= est.xml rename to tests/qemuxmlconfdata/usb-controller-automatic-i440fx.x86_64-late= st.xml diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-i440fx.xml b/tes= ts/qemuxmlconfdata/usb-controller-automatic-i440fx.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-i440fx.xml rename to tests/qemuxmlconfdata/usb-controller-automatic-i440fx.xml diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-lat= est.args b/tests/qemuxmlconfdata/usb-controller-automatic-isapc.x86_64-late= st.args similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-late= st.args rename to tests/qemuxmlconfdata/usb-controller-automatic-isapc.x86_64-lates= t.args diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-lat= est.xml b/tests/qemuxmlconfdata/usb-controller-automatic-isapc.x86_64-lates= t.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-late= st.xml rename to tests/qemuxmlconfdata/usb-controller-automatic-isapc.x86_64-lates= t.xml diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-isapc.xml b/test= s/qemuxmlconfdata/usb-controller-automatic-isapc.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-isapc.xml rename to tests/qemuxmlconfdata/usb-controller-automatic-isapc.xml diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-q35.x86_64-lates= t.args b/tests/qemuxmlconfdata/usb-controller-automatic-q35.x86_64-latest.a= rgs similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-q35.x86_64-latest= .args rename to tests/qemuxmlconfdata/usb-controller-automatic-q35.x86_64-latest.= args diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-q35.x86_64-lates= t.xml b/tests/qemuxmlconfdata/usb-controller-automatic-q35.x86_64-latest.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-q35.x86_64-latest= .xml rename to tests/qemuxmlconfdata/usb-controller-automatic-q35.x86_64-latest.= xml diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-q35.xml b/tests/= qemuxmlconfdata/usb-controller-automatic-q35.xml similarity index 100% rename from tests/qemuxmlconfdata/usb-controller-implicit-q35.xml rename to tests/qemuxmlconfdata/usb-controller-automatic-q35.xml diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 7b185dae29..cc1387fc04 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -2057,9 +2057,9 @@ mymain(void) DO_TEST_CAPS_LATEST_PARSE_ERROR("chardev-reconnect-invalid-timeout"); DO_TEST_CAPS_LATEST_PARSE_ERROR("chardev-reconnect-generated-path"); =20 - DO_TEST_CAPS_LATEST("usb-controller-implicit-isapc"); - DO_TEST_CAPS_LATEST("usb-controller-implicit-i440fx"); - DO_TEST_CAPS_LATEST("usb-controller-implicit-q35"); + DO_TEST_CAPS_LATEST("usb-controller-automatic-isapc"); + DO_TEST_CAPS_LATEST("usb-controller-automatic-i440fx"); + DO_TEST_CAPS_LATEST("usb-controller-automatic-q35"); DO_TEST_CAPS_LATEST_PARSE_ERROR("usb-controller-default-isapc"); DO_TEST_CAPS_LATEST("usb-controller-default-i440fx"); DO_TEST_CAPS_LATEST("usb-controller-default-q35"); --=20 2.51.0