From nobody Sun Oct 5 01:50:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1758824404; cv=none; d=zohomail.com; s=zohoarc; b=TRxP/nD0PuewfFQND/+iTNRBulifTu101QscD65uDU7NeueU2kiv+BawRdWg/jn8qBhQXCkk6hTE5v8EHIFUps9Z75VPw2/jm02ntkzBqtH5Yb36tCyHpctIPtd7+h1SVLqN0LwckkNqn63qfZULMiYXVPX9mwT6fX/cLkDXmVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758824404; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=hxT1dk/Q9h5Yn7oEry5GqRZuZchk4xigtC977k0IQQE=; b=oAcIhwmrv1i4I86YkZse2i9ykRsRpP2RgaTbqBYhWzerWt7t5WSruLjRErGOIoPOZ289jV4lHirODeQOqvcWngT1+UM+p68nopuvA0PQ1Igf2wd8ZJaJWxbDexUeWToAoH6eSawjIczCQtCQrJKiOLuGhR5IO9Fei5UvcFJNyYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1758824404196906.1018686352318; Thu, 25 Sep 2025 11:20:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3A841440AB; Thu, 25 Sep 2025 14:20:02 -0400 (EDT) Received: from [172.19.199.14] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0736244065; Thu, 25 Sep 2025 14:08:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DD84843F81; Thu, 25 Sep 2025 14:07:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 507D343F5A for ; Thu, 25 Sep 2025 14:07:37 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-88AfqJZ1O5CbqQUnKg0s2w-1; Thu, 25 Sep 2025 14:07:35 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C6D719560B2 for ; Thu, 25 Sep 2025 18:07:34 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.225.196]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 78D72300021A for ; Thu, 25 Sep 2025 18:07:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758823656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hxT1dk/Q9h5Yn7oEry5GqRZuZchk4xigtC977k0IQQE=; b=i3M88o2w3NDozur8EIJJIXt+WlU5fThehHvtV/02+ynFPpfFgXr64q8KxA7Q34bbBSw0t6 8post0o5JVHhd1CuXqzMXEQqOhUJBW3MmxPaLsxqUZp0WRgk/a+fAC03iKTEufT+iUUXqw E81lODV5HL9EgeUytGJf7u6OS+cvy3M= X-MC-Unique: 88AfqJZ1O5CbqQUnKg0s2w-1 X-Mimecast-MFC-AGG-ID: 88AfqJZ1O5CbqQUnKg0s2w_1758823654 To: devel@lists.libvirt.org Subject: [PATCH v2 04/38] tests: Don't set PCI address in usb-controller-default tests Date: Thu, 25 Sep 2025 20:06:50 +0200 Message-ID: <20250925180724.500758-5-abologna@redhat.com> In-Reply-To: <20250925180724.500758-1-abologna@redhat.com> References: <20250925180724.500758-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bqyR1DytCP2_FR5y6KSuwqopVtFHAwPEtA6jcF-82ZE_1758823654 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QPNTIUHJ6WGKOPC7MVWGKUL5CFPUWULA X-Message-ID-Hash: QPNTIUHJ6WGKOPC7MVWGKUL5CFPUWULA X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1758824405649116600 Content-Type: text/plain; charset="utf-8"; x-default="true" We want to ensure that libvirt will automatically allocate the PCI address, and setting it ourselves ahead of time will prevent that from happening. In the case of q35, this change will cause additional PCI controllers to show up. That's desirable, as it demonstrates the behavior libvirt users will actually see. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Peter Krempa --- .../usb-controller-default-i440fx.xml | 4 +--- .../usb-controller-default-pseries.xml | 4 +--- ...usb-controller-default-q35.x86_64-latest.args | 5 ++++- .../usb-controller-default-q35.x86_64-latest.xml | 16 +++++++++++++++- .../usb-controller-default-q35.xml | 4 +--- ...ler-default-unavailable-q35.x86_64-latest.xml | 16 +++++++++++++++- 6 files changed, 37 insertions(+), 12 deletions(-) diff --git a/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml b/test= s/qemuxmlconfdata/usb-controller-default-i440fx.xml index 81149b73be..3987b78ebc 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml @@ -10,9 +10,7 @@ /usr/bin/qemu-system-x86_64 - -
- + diff --git a/tests/qemuxmlconfdata/usb-controller-default-pseries.xml b/tes= ts/qemuxmlconfdata/usb-controller-default-pseries.xml index 3717c58261..676a578eb0 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-pseries.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-pseries.xml @@ -18,9 +18,7 @@ restart /usr/bin/qemu-system-ppc64 - -
- +
diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest= .args b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args index 23bdedef6c..7ba7b39a87 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args @@ -26,7 +26,10 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-q35-te= st/.config \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pcie.0","addr":"0x1"= }' \ +-device '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus= ":"pcie.0","multifunction":true,"addr":"0x1"}' \ +-device '{"driver":"pcie-pci-bridge","id":"pci.2","bus":"pci.1","addr":"0x= 0"}' \ +-device '{"driver":"pcie-root-port","port":9,"chassis":3,"id":"pci.3","bus= ":"pcie.0","addr":"0x1.0x1"}' \ +-device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.2","addr":"0x1"}= ' \ -audiodev '{"id":"audio1","driver":"none"}' \ -global ICH9-LPC.noreboot=3Doff \ -watchdog-action reset \ diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest= .xml b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml index fa67c860bb..4295586490 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml @@ -18,8 +18,22 @@ /usr/bin/qemu-system-x86_64 + + + +
+ + + +
+ + + + +
+ -
+
diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.xml b/tests/q= emuxmlconfdata/usb-controller-default-q35.xml index 1436495902..b3a57365bc 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.xml @@ -15,9 +15,7 @@ /usr/bin/qemu-system-x86_64 - -
- + diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x= 86_64-latest.xml b/tests/qemuxmlconfdata/usb-controller-default-unavailable= -q35.x86_64-latest.xml index c857816a3e..f5561ebc1a 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-l= atest.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-l= atest.xml @@ -18,8 +18,22 @@ /usr/bin/qemu-system-x86_64 + + + +
+ + + +
+ + + + +
+ -
+
--=20 2.51.0