From nobody Sun Oct 5 01:49:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1758826830; cv=none; d=zohomail.com; s=zohoarc; b=hj/iWU6RrsvifQ5hoeIjHpZtaBZlvohivOlFD1tLSXgtNdDCEnX02JxXgLC414p7EhnnsF0mcvi3OywqHtBwRFo/uadVcAKy3jt2g/R60ePAKIL/nC6qDKfRMsCIuQ/no/94wlbOD7/Za91kBy+JXWN4OsvKHOt9tnNY58kifKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758826830; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=d3YM0bjAJzBrn/q+alz+e2rUf1fmcb7HeAkhFHgGVPY=; b=OwhAVe0VNI+rdNmgEAp/cyFVDTzEtLJjj/Kz4GGNt2r48TK06MAb8jpTkaHTEmcNi/PLdaG3a4g3GvPLgi+0jIrMI0n4kCBBg9HzPqXOKZ21tHK0FAyMxfYz4J/Tf4CiarMuonYWmWcdBds7DNDja5PZHY7vH0nRMWamPZ8xgUs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1758826830001479.9301898806433; Thu, 25 Sep 2025 12:00:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 11B6944149; Thu, 25 Sep 2025 15:00:29 -0400 (EDT) Received: from [172.19.199.14] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 72AA94480C; Thu, 25 Sep 2025 14:21:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0AA2A4460B; Thu, 25 Sep 2025 14:18:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4FB804412A for ; Thu, 25 Sep 2025 14:08:02 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-20O-DSk3Nt2DVYSdjepv6g-1; Thu, 25 Sep 2025 14:08:00 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C9A6F1956087 for ; Thu, 25 Sep 2025 18:07:59 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.225.196]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02398300021A for ; Thu, 25 Sep 2025 18:07:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758823681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3YM0bjAJzBrn/q+alz+e2rUf1fmcb7HeAkhFHgGVPY=; b=UQJVORIrvyYVlIqfYmEk+EHI0xk/aHUQPGnk7nLYZeVPa4PUHmPBrKg1cIIEXDiI/8bFfT qC/kTmuwime/vwJy1/ChLmY93/vVTfqjkVVk2WmX0ztxiBdbpLsVKV5x7eU/2KtFnmbeqD KkF7Ekqubgk2OWiTLypgV83QSuUrM/4= X-MC-Unique: 20O-DSk3Nt2DVYSdjepv6g-1 X-Mimecast-MFC-AGG-ID: 20O-DSk3Nt2DVYSdjepv6g_1758823679 To: devel@lists.libvirt.org Subject: [PATCH v2 23/38] qemu: Fold check into qemuBuildSkipController() Date: Thu, 25 Sep 2025 20:07:09 +0200 Message-ID: <20250925180724.500758-24-abologna@redhat.com> In-Reply-To: <20250925180724.500758-1-abologna@redhat.com> References: <20250925180724.500758-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xi7SsZ3kUb0ALvG6jKzG7J1bjoDfWT4M9_HiXFOOLns_1758823679 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BDDZN57SRJR7DPTF7PTUCOMDXCFZ7TR2 X-Message-ID-Hash: BDDZN57SRJR7DPTF7PTUCOMDXCFZ7TR2 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1758826830975116600 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b48f7769b5..e57bbc3d9a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3036,6 +3036,11 @@ qemuBuildSkipController(const virDomainControllerDef= *controller, return true; } =20 + /* skip USB controllers with type none */ + if (controller->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_USB && + controller->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE) + return true; + return false; } =20 @@ -3074,13 +3079,6 @@ qemuBuildControllersByTypeCommandLine(virCommand *cm= d, if (qemuBuildSkipController(cont, def)) continue; =20 - if (cont->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_USB) { - - /* skip USB controllers with type none*/ - if (cont->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE) - continue; - } - if (qemuBuildControllerDevProps(def, cont, qemuCaps, &props) < 0) return -1; =20 --=20 2.51.0