From nobody Mon Sep 8 02:40:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1756140483; cv=none; d=zohomail.com; s=zohoarc; b=IVikwevcP+cx68SgA7x8dbYsTlHWLKFZfFhy7RQ8oNa0wCnbo7Sje0waDmj4Qb2KK/TFVroVh63K9H4D0tLqT2gQJICYzcWvdV87upHYN4ZDyJhsUpeThiCRypGMQTkQ5HClHGN9dNaV2yfMc6kX8yDdq6nSz5yjz24pRxYPThY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756140483; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=hl4rGrT9VOLzbXAjiiaQQY07Gkj3JYb/KDDSD0Mfumo=; b=D2MCr/LDHc6mbIFYnuYk2WJgZEN1ms1KBm0B+eWQ6wFjyJuEIW0fXYQU2dA/HqewVBj5sDx2+0xCOsMGndkMXOcxEY/XlO1u537boT1V7PQJQrrVFYNCsT7Pyepw/WG6ebGEvQ0iApKRflywr27U/ff8IfY46OmU9v35wFZ+GgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1756140483619670.8043993613082; Mon, 25 Aug 2025 09:48:03 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C073643EE8; Mon, 25 Aug 2025 12:48:02 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8334A4414A; Mon, 25 Aug 2025 12:22:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9BA4543F6B; Mon, 25 Aug 2025 12:22:44 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 140A443F29 for ; Mon, 25 Aug 2025 12:19:56 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-d_tSlqfwN_Gc_sLVtFqrHQ-1; Mon, 25 Aug 2025 12:19:54 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C3AB18002CE for ; Mon, 25 Aug 2025 16:19:49 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.68]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4DA6C30001A2 for ; Mon, 25 Aug 2025 16:19:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756138795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hl4rGrT9VOLzbXAjiiaQQY07Gkj3JYb/KDDSD0Mfumo=; b=Ws2yS/CyRlXLj2BBOXiocE2l8y2npEwO9Vr+bU4wUSR9i+jkI4Volnqwmv+O/reogkz41B SHKjZynC9PSlN+cnPJqh2zCnKeaV9SaUKtUsJdc1QY2uuXVNe3YamqOszsKNtBw3X4nFGo qwlXpWr/FXWkXuJ5MzYuTohTN2Oxlgc= X-MC-Unique: d_tSlqfwN_Gc_sLVtFqrHQ-1 X-Mimecast-MFC-AGG-ID: d_tSlqfwN_Gc_sLVtFqrHQ_1756138793 To: devel@lists.libvirt.org Subject: [PATCH v2 09/10] DONOTMERGE remove SEV features from non-SEV descriptors Date: Mon, 25 Aug 2025 18:19:32 +0200 Message-ID: <20250825161933.228626-10-abologna@redhat.com> In-Reply-To: <20250825161933.228626-1-abologna@redhat.com> References: <20250825161933.228626-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ONcA8R34ByVIYDC9-QLjUon5cPHOKw3nv3TAwIVByA0_1756138793 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YQCQNC7X5FILZ6HGVYYOC5HZQBQFV6NK X-Message-ID-Hash: YQCQNC7X5FILZ6HGVYYOC5HZQBQFV6NK X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1756140486227116601 Content-Type: text/plain; charset="utf-8"; x-default="true" These changes are not in the Fedora edk2 packages, not even in tentative form, and are just a suggestion of how we could potentially move things forward. The idea is to stop advertising SEV(-ES) support in the descriptors for regular edk2 builds, thus forcing the SEV-specific stateless build to be used. This arguably makes more sense, but it's unclear whether removing the combination could have negative impact on certain use cases. --- .../share/qemu/firmware/50-edk2-ovmf-4m-qcow2-x64-nosb.json | 2 -- .../share/qemu/firmware/51-edk2-ovmf-2m-raw-x64-nosb.json | 2 -- .../usr/share/qemu/firmware/90-combined.json | 1 - .../firmware-auto-efi-sev.x86_64-latest+amdsev.args | 5 ++--- .../firmware-auto-efi-sev.x86_64-latest+amdsev.xml | 3 +-- 5 files changed, 3 insertions(+), 10 deletions(-) diff --git a/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-ovmf-4m= -qcow2-x64-nosb.json b/tests/qemufirmwaredata/usr/share/qemu/firmware/50-ed= k2-ovmf-4m-qcow2-x64-nosb.json index d64735f477..bb11f5febd 100644 --- a/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-ovmf-4m-qcow2-= x64-nosb.json +++ b/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-ovmf-4m-qcow2-= x64-nosb.json @@ -26,8 +26,6 @@ ], "features": [ "acpi-s3", - "amd-sev", - "amd-sev-es", "verbose-dynamic" ], "tags": [ diff --git a/tests/qemufirmwaredata/usr/share/qemu/firmware/51-edk2-ovmf-2m= -raw-x64-nosb.json b/tests/qemufirmwaredata/usr/share/qemu/firmware/51-edk2= -ovmf-2m-raw-x64-nosb.json index 050853e2b8..bb8ea4c07a 100644 --- a/tests/qemufirmwaredata/usr/share/qemu/firmware/51-edk2-ovmf-2m-raw-x6= 4-nosb.json +++ b/tests/qemufirmwaredata/usr/share/qemu/firmware/51-edk2-ovmf-2m-raw-x6= 4-nosb.json @@ -26,8 +26,6 @@ ], "features": [ "acpi-s3", - "amd-sev", - "amd-sev-es", "verbose-dynamic" ], "tags": [ diff --git a/tests/qemufirmwaredata/usr/share/qemu/firmware/90-combined.jso= n b/tests/qemufirmwaredata/usr/share/qemu/firmware/90-combined.json index 8ecac440b4..a788a3fc40 100644 --- a/tests/qemufirmwaredata/usr/share/qemu/firmware/90-combined.json +++ b/tests/qemufirmwaredata/usr/share/qemu/firmware/90-combined.json @@ -21,7 +21,6 @@ ], "features": [ "acpi-s3", - "amd-sev", "enrolled-keys", "requires-smm", "secure-boot", diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amds= ev.args b/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.= args index 550ac52b8a..a0ede6ca92 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.args +++ b/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.args @@ -10,10 +10,9 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/= .config \ -name guest=3Dguest,debug-threads=3Don \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ --blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF_CODE.fd"= ,"node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard":"unm= ap"}' \ +-blockdev '{"driver":"file","filename":"/usr/share/edk2/ovmf/OVMF.amdsev.f= d","node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard":"u= nmap"}' \ -blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"raw","file":"libvirt-pflash0-storage"}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/guest_= VARS.fd","node-name":"libvirt-pflash1-storage","read-only":false}' \ --machine pc-q35-10.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.r= am,confidential-guest-support=3Dlsec0,pflash0=3Dlibvirt-pflash0-format,pfla= sh1=3Dlibvirt-pflash1-storage,acpi=3Don \ +-machine pc-q35-10.0,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.r= am,confidential-guest-support=3Dlsec0,pflash0=3Dlibvirt-pflash0-format,acpi= =3Don \ -accel kvm \ -cpu qemu64 \ -m size=3D1048576k \ diff --git a/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amds= ev.xml b/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.x= ml index cbfdcdeee3..35db3dc7c3 100644 --- a/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.xml +++ b/tests/qemuxmlconfdata/firmware-auto-efi-sev.x86_64-latest+amdsev.xml @@ -10,8 +10,7 @@ - /usr/share/edk= 2/ovmf/OVMF_CODE.fd - /var/lib/libvirt/qemu/nvram/guest_VARS.fd + /usr/share/edk2/ovmf/OVMF.amdsev.fd --=20 2.51.0