From nobody Mon Sep 8 17:08:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1755778448; cv=none; d=zohomail.com; s=zohoarc; b=kUbgi2kHYYuDtZ2SL9fWg85m2W6+CZm0NUZsIFTSEjEBvK5VveinxyokJalu3+/qIwwMhm1wjHwfF4SQfAYtExYo99qWSKbG5oDhwKBIvwwv+wzYM6U8PxavUUe7836kPTNOML1FnnAyAP1wJixl4ww0xLX8vPsAV++GtqixOCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755778448; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=EUZOsF9VvwQgwoOaFIWmzotZ+Zy+iEnHFZhf28Zf1D0=; b=IIEBlnv5iSqbn2nPuKKSpjsz2lGBaYp1ptknyu4THDmU5Ye4bNI6K/KCEnFGT6+DE2aZdnLIpo63a6VZ/rFFDOLqBSJsIE7UCa7H50HRNwoUyYsP0Bx4CsDKs2/WiHZOnwizNWSCLh2dRx/BYZtjjipGCSmEdsfyoqngHY0SYnc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1755778448666234.7476523146563; Thu, 21 Aug 2025 05:14:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3BEE3132E; Thu, 21 Aug 2025 08:14:07 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AB61412A9; Thu, 21 Aug 2025 08:12:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2F87112A6; Thu, 21 Aug 2025 08:12:53 -0400 (EDT) Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 50E18C86 for ; Thu, 21 Aug 2025 08:12:49 -0400 (EDT) Received: from [130.117.225.5] (helo=vz9-barybin-2.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1up3QE-004YJR-2T; Thu, 21 Aug 2025 13:57:00 +0200 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-Greylist: delayed 949 seconds by postgrey-1.37 at lists.libvirt.org; Thu, 21 Aug 2025 08:12:49 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=YLSrJUmS78vSAaS7gBBGM7HG0CNLJo++v3I31zntniE=; b=AwSSzTAxZIkD pDv4OPha5ztbZtAjXy0qQwRJC/mtJRJOBeOzQZN0G2YNLzDJoiqpuyOsojhpMjjZA2caiLf7SoPi6 EhhHlWPz9nkKVcTLTMYwD3l1ExaLW/+Z20lajKDcpgdCIAkLoD9nhvMqCv7ADuiTqcocsgYsuIHid uyyAOxocVRZcaAiTdmgwSDbYkJyWqo8ZK7JpBbjD231rvwzptJDuUOyeEdl37CiRc+WevUiu9WP1r razUgKiThEhxLovQEwSfDhdvaun9k5FHtFFlWQfFdek+TbFCUzPl57aHNfn0uvNV0E1fCEgf2muFu dIN6gIGO9wAc/XVg3udDDg==; To: devel@lists.libvirt.org Subject: [PATCH 2/2] qemu: implement driver support for domainBlockRebase2 API Date: Thu, 21 Aug 2025 14:51:37 +0300 Message-ID: <20250821115652.21045-3-nikolai.barybin@virtuozzo.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250821115652.21045-1-nikolai.barybin@virtuozzo.com> References: <20250821115652.21045-1-nikolai.barybin@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FNY24TC3SWQJ5VGD4CIEHBBYGTEV6UAQ X-Message-ID-Hash: FNY24TC3SWQJ5VGD4CIEHBBYGTEV6UAQ X-MailFrom: nikolai.barybin@virtuozzo.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: den@openvz.org, Nikolai Barybin X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Nikolai Barybin via Devel Reply-To: Nikolai Barybin X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1755778451936116600 Content-Type: text/plain; charset="utf-8" Introduce qemuDomainBlockRebase2 which validates and parses list of params. Since new heavily reuses qemuDomainBlockRebase logic let's now make qemuDomainBlockPull and qemuDomainBlockRebase stub functions. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_driver.c | 113 +++++++++++++++++++++++++++++++++-------- 1 file changed, 93 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ac72ea5cb0..405c20045c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14559,16 +14559,19 @@ qemuDomainBlockCopyCommon(virDomainObj *vm, return ret; } =20 + static int -qemuDomainBlockRebase(virDomainPtr dom, - const char *path, - const char *base, - unsigned long bandwidth, - unsigned int flags) +qemuDomainBlockRebase2(virDomainPtr dom, + const char *path, + virTypedParameterPtr params, + int nparams, + unsigned int flags) { virDomainObj *vm; int ret =3D -1; - unsigned long long speed =3D bandwidth; + size_t i =3D 0; + unsigned long long bandwidth =3D 0; + const char *base =3D NULL; g_autoptr(virStorageSource) dest =3D NULL; =20 virCheckFlags(VIR_DOMAIN_BLOCK_REBASE_SHALLOW | @@ -14579,12 +14582,30 @@ qemuDomainBlockRebase(virDomainPtr dom, VIR_DOMAIN_BLOCK_REBASE_COPY_DEV | VIR_DOMAIN_BLOCK_REBASE_BANDWIDTH_BYTES, -1); =20 + if (virTypedParamsValidate(params, nparams, + VIR_DOMAIN_BLOCK_REBASE_PARAM_BASE, + VIR_TYPED_PARAM_STRING, + VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH, + VIR_TYPED_PARAM_ULLONG, + NULL) < 0) + return -1; + if (!(vm =3D qemuDomainObjFromDomain(dom))) return -1; =20 - if (virDomainBlockRebaseEnsureACL(dom->conn, vm->def) < 0) + if (virDomainBlockRebase2EnsureACL(dom->conn, vm->def) < 0) goto cleanup; =20 + for (i =3D 0; i < nparams; i++) { + virTypedParameterPtr param =3D ¶ms[i]; + + if (STREQ(param->field, VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH)) { + bandwidth =3D param->value.ul; + } else if (STREQ(param->field, VIR_DOMAIN_BLOCK_REBASE_PARAM_BASE)= ) { + base =3D param->value.s; + } + } + /* For normal rebase (enhanced blockpull), the common code handles * everything, including vm cleanup. */ if (!(flags & VIR_DOMAIN_BLOCK_REBASE_COPY)) @@ -14602,13 +14623,13 @@ qemuDomainBlockRebase(virDomainPtr dom, =20 /* Convert bandwidth MiB to bytes, if necessary */ if (!(flags & VIR_DOMAIN_BLOCK_REBASE_BANDWIDTH_BYTES)) { - if (speed > LLONG_MAX >> 20) { + if (bandwidth > LLONG_MAX >> 20) { virReportError(VIR_ERR_OVERFLOW, _("bandwidth must be less than %1$llu"), LLONG_MAX >> 20); goto cleanup; } - speed <<=3D 20; + bandwidth <<=3D 20; } =20 /* XXX: If we are doing a shallow copy but not reusing an external @@ -14626,7 +14647,7 @@ qemuDomainBlockRebase(virDomainPtr dom, flags &=3D (VIR_DOMAIN_BLOCK_REBASE_SHALLOW | VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT); ret =3D qemuDomainBlockCopyCommon(vm, dom->conn, path, dest, - speed, 0, 0, flags, true); + bandwidth, 0, 0, flags, true); dest =3D NULL; =20 cleanup: @@ -14635,6 +14656,48 @@ qemuDomainBlockRebase(virDomainPtr dom, } =20 =20 +static int +qemuDomainBlockRebase(virDomainPtr dom, + const char *path, + const char *base, + unsigned long bandwidth, + unsigned int flags) +{ + int nparams =3D 0; + int maxparams =3D 0; + virTypedParameterPtr params =3D NULL; + int ret =3D -1; + + if (base && + virTypedParamsAddString(¶ms, &nparams, &maxparams, + VIR_DOMAIN_BLOCK_REBASE_PARAM_BASE, + base) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to add param %1$s:%2$s to params list"), + VIR_DOMAIN_BLOCK_REBASE_PARAM_BASE, base); + goto end; + } + + if (bandwidth > 0 && + virTypedParamsAddULLong(¶ms, &nparams, &maxparams, + VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH, + bandwidth) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to add param %1$s:%2$lu to params list"), + VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH, bandwidth); + goto end; + } + + ret =3D qemuDomainBlockRebase2(dom, path, params, nparams, flags); + + end: + virTypedParamsFree(params, nparams); + params =3D NULL; + nparams =3D 0; + return ret; +} + + static int qemuDomainBlockCopy(virDomainPtr dom, const char *disk, @@ -14722,19 +14785,28 @@ qemuDomainBlockPull(virDomainPtr dom, unsigned long bandwidth, unsigned int flags) { - virDomainObj *vm; - virCheckFlags(VIR_DOMAIN_BLOCK_PULL_BANDWIDTH_BYTES, -1); - - if (!(vm =3D qemuDomainObjFromDomain(dom))) - return -1; + int nparams =3D 0; + int maxparams =3D 0; + virTypedParameterPtr params =3D NULL; + int ret =3D -1; =20 - if (virDomainBlockPullEnsureACL(dom->conn, vm->def) < 0) { - virDomainObjEndAPI(&vm); - return -1; + if (bandwidth > 0 && + virTypedParamsAddULLong(¶ms, &nparams, &maxparams, + VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH, + bandwidth) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to add param %1$s:%2$lu to params list"), + VIR_DOMAIN_BLOCK_REBASE_PARAM_BANDWIDTH, bandwidth); + goto end; } =20 - /* qemuDomainBlockPullCommon consumes the reference on @vm */ - return qemuDomainBlockPullCommon(vm, path, NULL, bandwidth, flags); + ret =3D qemuDomainBlockRebase2(dom, path, params, nparams, flags); + + end: + virTypedParamsFree(params, nparams); + params =3D NULL; + nparams =3D 0; + return ret; } =20 =20 @@ -20579,6 +20651,7 @@ static virHypervisorDriver qemuHypervisorDriver =3D= { .domainBlockJobSetSpeed =3D qemuDomainBlockJobSetSpeed, /* 0.9.4 */ .domainBlockPull =3D qemuDomainBlockPull, /* 0.9.4 */ .domainBlockRebase =3D qemuDomainBlockRebase, /* 0.9.10 */ + .domainBlockRebase2 =3D qemuDomainBlockRebase2, /* 11.6.0 */ .domainBlockCopy =3D qemuDomainBlockCopy, /* 1.2.9 */ .domainBlockCommit =3D qemuDomainBlockCommit, /* 1.0.0 */ .connectIsAlive =3D qemuConnectIsAlive, /* 0.9.8 */ --=20 2.47.3