From nobody Mon Sep 8 16:51:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1755621008; cv=none; d=zohomail.com; s=zohoarc; b=AtXao16gVbT+CaRTQYKPBv2fVtN/NmOIj23K/+gf4E4GTvYjd1q7VOpHcTey+aGt/+l9KHptCY76Y3xJumOb2P+xrXcH2ijXbvbvHddhfgEpKuKNNFODU4p9mqu+2+oAWNf3fD06zbuMVMlyHj8oHM1LLFZbCJtQ+lFL5qUaX5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755621008; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=1bI86JfqaNf9QR2z82eniC7LO+wsk69aYW3mhqZWJcw=; b=QG189CeVhbS4I+BPevIhmlhyS15qJgoUWA/ppDEH/lIM6D4wkTwfX6pUuqKLiaclpw53gX9Nr7Knx9Md11728DrnOdKHFb5mxvNnsKJXJhs/pzk/25uyx+NLShkKqnVhMV10lAOZptXVT/xtuUXeN4s9xibFz9WFKJDt0UVb0dw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1755621008810766.8833668142937; Tue, 19 Aug 2025 09:30:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1627FE02; Tue, 19 Aug 2025 12:30:08 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8DB3CC30; Tue, 19 Aug 2025 12:22:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0A942B0D; Tue, 19 Aug 2025 12:22:49 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 52D79980 for ; Tue, 19 Aug 2025 12:22:48 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-ySRTaNM5PMmiau0QL3LJ8Q-1; Tue, 19 Aug 2025 12:22:46 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7BA1D1956095 for ; Tue, 19 Aug 2025 16:22:45 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.253]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A460A1800447 for ; Tue, 19 Aug 2025 16:22:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755620568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQ0LFLQd8CmK2GOGmFkC/dfURpge8Zhaw/VMkWc0hZk=; b=XHc5l1YSlR7L4rlh1rC91EMkqhyXAqVVS3xaNzIRSE1iMgm/oKML+xS2PoU4HZ45qTKUEn 4NcmKGF/vb/SCOUGHODTPSxSM5A1eldE8NdJmdjdKsTUsinU/NE6DF13OH/9xr2NRrje0G bw1vJWL/xPuQ6/hMmwO4Vi+yH299SWI= X-MC-Unique: ySRTaNM5PMmiau0QL3LJ8Q-1 X-Mimecast-MFC-AGG-ID: ySRTaNM5PMmiau0QL3LJ8Q_1755620565 To: devel@lists.libvirt.org Subject: [PATCH 04/31] tests: Don't set PCI address in usb-controller-default tests Date: Tue, 19 Aug 2025 18:22:08 +0200 Message-ID: <20250819162235.468215-5-abologna@redhat.com> In-Reply-To: <20250819162235.468215-1-abologna@redhat.com> References: <20250819162235.468215-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _v65jK25IxciSCWAjjyfmv-55vA1foIxzXZwyh3r_hs_1755620565 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KO7NCA6R7JKS33EVOAXQ6OTMSZIMNQLN X-Message-ID-Hash: KO7NCA6R7JKS33EVOAXQ6OTMSZIMNQLN X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1755621011424124100 Content-Type: text/plain; charset="utf-8"; x-default="true" We want to ensure that libvirt will automatically allocate the PCI address, and setting it ourselves ahead of time will prevent that from happening. In the case of q35, this change will cause additional PCI controllers to show up. That's desirable, as it demonstrates the behavior libvirt users will actually see. Signed-off-by: Andrea Bolognani --- .../usb-controller-default-i440fx.xml | 4 +--- .../usb-controller-default-pseries.xml | 4 +--- ...usb-controller-default-q35.x86_64-latest.args | 5 ++++- .../usb-controller-default-q35.x86_64-latest.xml | 16 +++++++++++++++- .../usb-controller-default-q35.xml | 4 +--- ...ler-default-unavailable-q35.x86_64-latest.xml | 16 +++++++++++++++- 6 files changed, 37 insertions(+), 12 deletions(-) diff --git a/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml b/test= s/qemuxmlconfdata/usb-controller-default-i440fx.xml index 81149b73be..3987b78ebc 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-i440fx.xml @@ -10,9 +10,7 @@ /usr/bin/qemu-system-x86_64 - -
- + diff --git a/tests/qemuxmlconfdata/usb-controller-default-pseries.xml b/tes= ts/qemuxmlconfdata/usb-controller-default-pseries.xml index 3717c58261..676a578eb0 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-pseries.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-pseries.xml @@ -18,9 +18,7 @@ restart /usr/bin/qemu-system-ppc64 - -
- +
diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest= .args b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args index 23bdedef6c..7ba7b39a87 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.args @@ -26,7 +26,10 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-q35-te= st/.config \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pcie.0","addr":"0x1"= }' \ +-device '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus= ":"pcie.0","multifunction":true,"addr":"0x1"}' \ +-device '{"driver":"pcie-pci-bridge","id":"pci.2","bus":"pci.1","addr":"0x= 0"}' \ +-device '{"driver":"pcie-root-port","port":9,"chassis":3,"id":"pci.3","bus= ":"pcie.0","addr":"0x1.0x1"}' \ +-device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.2","addr":"0x1"}= ' \ -audiodev '{"id":"audio1","driver":"none"}' \ -global ICH9-LPC.noreboot=3Doff \ -watchdog-action reset \ diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest= .xml b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml index fa67c860bb..4295586490 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.x86_64-latest.xml @@ -18,8 +18,22 @@ /usr/bin/qemu-system-x86_64 + + + +
+ + + +
+ + + + +
+ -
+
diff --git a/tests/qemuxmlconfdata/usb-controller-default-q35.xml b/tests/q= emuxmlconfdata/usb-controller-default-q35.xml index 1436495902..b3a57365bc 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-q35.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-q35.xml @@ -15,9 +15,7 @@ /usr/bin/qemu-system-x86_64 - -
- + diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x= 86_64-latest.xml b/tests/qemuxmlconfdata/usb-controller-default-unavailable= -q35.x86_64-latest.xml index c857816a3e..f5561ebc1a 100644 --- a/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-l= atest.xml +++ b/tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-l= atest.xml @@ -18,8 +18,22 @@ /usr/bin/qemu-system-x86_64 + + + +
+ + + +
+ + + + +
+ -
+
--=20 2.50.1