From nobody Mon Sep 8 17:06:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1755622135; cv=none; d=zohomail.com; s=zohoarc; b=DJPttb/ZmwBRz+N7ANxbPdbxEL3o0/9JJG2altyaiDgmnBmR8Nec7OOXaKOgzIIpPkkEy7Dk+Y+4QCIm2rGENbxr3q+TwpYwJh+IDepKTWbFzPyeVsFNOVpjzUPvkAEIi3cylK/hihYZD6RoUlVqDy+I5NRfpfZKKxgUJpI0coE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755622135; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=TBoGzXgNJEZ2UcqnYsbuAa5soJqVUqddH4C0OIoadBQ=; b=LAmzFfqbV4Ll6ZrCAAI9AfbYuwp6GjmBKJg3F1qNgyxBCHz4EhOcfsmTOueuhQc3T1Fua70dk2hZN4LzUesM8aAVtMKVbUbdKfiVa9nX7j40ubRRTNC9dXFpZu1hmDdtI2dkroCOsqDwKws3H/elS05hu3f5KHuVs3nZQoq//ec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1755622135565494.6358199417765; Tue, 19 Aug 2025 09:48:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 98AF311FB; Tue, 19 Aug 2025 12:48:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 22BA1B09; Tue, 19 Aug 2025 12:24:23 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 856F8E66; Tue, 19 Aug 2025 12:24:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 53B57E66 for ; Tue, 19 Aug 2025 12:23:12 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-dRXH6oW3OpuG5aAaUob_mw-1; Tue, 19 Aug 2025 12:23:10 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED7DA18004D4 for ; Tue, 19 Aug 2025 16:23:09 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.253]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 23186180044F for ; Tue, 19 Aug 2025 16:23:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755620592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T20SmnlQZp/D/GlS5JybN4R0/rj2KItf3mlTUB94e0g=; b=TtMdfWlsgiQroVDT6SnPoaZuXXWIC5IVzeAy0zET7OePrjSUcNpRMPkGm16LWEqhEaBp9i pas3r0lhvj0v1hqwdG0VsEy2awyt7ANsVxWMgv1oFIFKaUAF54N5GlzrHE9A9rb080v78n 8KmBcRQlyKswFHjBsxZPoBlu5CaKt1s= X-MC-Unique: dRXH6oW3OpuG5aAaUob_mw-1 X-Mimecast-MFC-AGG-ID: dRXH6oW3OpuG5aAaUob_mw_1755620590 To: devel@lists.libvirt.org Subject: [PATCH 22/31] qemu: Fold check into qemuBuildSkipController() Date: Tue, 19 Aug 2025 18:22:26 +0200 Message-ID: <20250819162235.468215-23-abologna@redhat.com> In-Reply-To: <20250819162235.468215-1-abologna@redhat.com> References: <20250819162235.468215-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i85ePuVLzOaZbqNiCoJ5yL-owu-K6yL6itkK18OCPGg_1755620590 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7GXQPVC4CTTHBHMVXCSSLD7TGM6BMA7U X-Message-ID-Hash: 7GXQPVC4CTTHBHMVXCSSLD7TGM6BMA7U X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1755622136159116600 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aabc3d773f..8efcbdebae 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3043,6 +3043,11 @@ qemuBuildSkipController(const virDomainControllerDef= *controller, return true; } =20 + /* skip USB controllers with type none */ + if (controller->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_USB && + controller->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE) + return true; + return false; } =20 @@ -3081,13 +3086,6 @@ qemuBuildControllersByTypeCommandLine(virCommand *cm= d, if (qemuBuildSkipController(cont, def)) continue; =20 - if (cont->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_USB) { - - /* skip USB controllers with type none*/ - if (cont->model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE) - continue; - } - if (qemuBuildControllerDevProps(def, cont, qemuCaps, &props) < 0) return -1; =20 --=20 2.50.1