From nobody Mon Sep 8 17:08:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1755622015; cv=none; d=zohomail.com; s=zohoarc; b=P6BzWBkRE7pHOsjLg1T5yqdomNPcmaLhjDW5/9PGVm1c/hzq4j/q/Zjue69QrEOLD5QG5Iyr6Pc0rE5PBuOb8LzRpxol6TWeSVxcZZL7JbCJkZmAz02mKIwICTv3oGMtjeB9Gk9HgCGY08qL/spBH52czIFV3D3i6se02j8Vebk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755622015; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=j0k4CXHdPhcXx2zR2X4vyJ3gyxmKasm50SR8O2UNoRM=; b=NcSvLxvwS9X514pZUKL8zbBlA9ZBL77xP5LtOj2oOykWYRnupdnlf3JaS+SgOqjDDrNwQ4CqqGnUoz1cV/vlvXlOXiZ3PIA8ZJny6kOZPRE7q3Jz6AdIQjBazWOPVpdt8utZ5xVeYiCAtLtUbiUy6quvrjvhcrBhxUxEdMX0LAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17556220159431001.638213172292; Tue, 19 Aug 2025 09:46:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F13359E8; Tue, 19 Aug 2025 12:46:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 491A61187; Tue, 19 Aug 2025 12:24:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9AB6D11D2; Tue, 19 Aug 2025 12:24:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 88EE9CDD for ; Tue, 19 Aug 2025 12:23:08 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-uchZl1cFNfOo3nJYiqWAMQ-1; Tue, 19 Aug 2025 12:23:06 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E78091800359 for ; Tue, 19 Aug 2025 16:23:05 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.253]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D73C1800447 for ; Tue, 19 Aug 2025 16:23:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755620588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8s7hMcMc63OOQYT8hjdckw2uiWuti9eBo7ERVS3Ls8=; b=EhLNvCxRwDeUAtzllop2PwPCZpA8rTidzYDZSEVKb/NFxz3ZACa1/jLQQDS4oeNZ+oUlHs Su7p3nzRA4Ixk2M5Vqf2QvJAW79+o0c/ci3lr/7dHQoIR3GArPzWahyDIKxC7RE6H5gXAU vpCVdNjq6OQyPSdTOo/n2csRFdvnySc= X-MC-Unique: uchZl1cFNfOo3nJYiqWAMQ-1 X-Mimecast-MFC-AGG-ID: uchZl1cFNfOo3nJYiqWAMQ_1755620586 To: devel@lists.libvirt.org Subject: [PATCH 19/31] qemu: Ensure USB controllers have a PCI address assigned Date: Tue, 19 Aug 2025 18:22:23 +0200 Message-ID: <20250819162235.468215-20-abologna@redhat.com> In-Reply-To: <20250819162235.468215-1-abologna@redhat.com> References: <20250819162235.468215-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ifFJdcKA8XMctZxWKLwKpC2bHobwaDNSKJqz6caev2A_1755620586 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TMX5IXE2DWJZBUJK5XXJTCOSWDVFNFJZ X-Message-ID-Hash: TMX5IXE2DWJZBUJK5XXJTCOSWDVFNFJZ X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1755622016889116600 Content-Type: text/plain; charset="utf-8"; x-default="true" If we have gotten this far into creating the QEMU command line, either the user or some earlier code should have assigned a PCI address to the USB controller. If one is not present, that must mean there's a bug somewhere. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e8de386f30..f5a80f6955 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2598,6 +2598,13 @@ qemuValidateDomainDeviceDefControllerUSB(const virDo= mainControllerDef *def, return -1; } =20 + if (!virDeviceInfoPCIAddressIsPresent(&def->info)) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Missing PCI address for USB controller idx=3D%1$= d"), + def->idx); + return -1; + } + if (!virQEMUCapsGet(qemuCaps, qemuControllerModelUSBToCaps(def->model)= )) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("USB controller model '%1$s' not supported in thi= s QEMU binary"), --=20 2.50.1