From nobody Mon Sep 8 20:12:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1753207220168232.29194061511282; Tue, 22 Jul 2025 11:00:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1ECDC1256; Tue, 22 Jul 2025 14:00:19 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 742A211A8; Tue, 22 Jul 2025 13:59:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 98883E89; Tue, 22 Jul 2025 13:59:53 -0400 (EDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DAFE7C18 for ; Tue, 22 Jul 2025 13:59:52 -0400 (EDT) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56MHt6J9022353 for ; Tue, 22 Jul 2025 17:59:52 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 482ffb813j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 Jul 2025 17:59:51 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 56MEwLMZ024972 for ; Tue, 22 Jul 2025 17:59:51 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 480nptm7qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 Jul 2025 17:59:51 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56MHxo9g23200256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 22 Jul 2025 17:59:50 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5207F5805A for ; Tue, 22 Jul 2025 17:59:50 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 050B658054 for ; Tue, 22 Jul 2025 17:59:50 +0000 (GMT) Received: from localhost.localdomain (unknown [9.61.246.227]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP for ; Tue, 22 Jul 2025 17:59:49 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=MDcOh30n8ZXHDyaLVhJ+oSeO3Uw1vzYH45/opunet 7U=; b=QjOqq+LMd//OZHVYwnUIwd8y4E/d0wNwKp59NaBba7/xrHnEPe798z06s F7dKyd+SN5SClUXCTw0a+gV7rRlBLO/2YShUghjuKvc5UZ8Jyy2hoMVavI9abOYw HghxUkbm1DFrq+7ijloJ+nQ1YJjBeNgl5vVlH5C67g0Pi+O1V2nww2G+oZx8t42J Gl5EqB+RABeb3VXAEGMg7NwycTNlF/EqCtBqAqQm0v807mVojlW9FV4CeaGxz6Ik CeGxJZkht5ELTtY/aDFybA26dEXDEee6zBaB08Qy/7Dbwu4+9cCTpqOXcUX27quF OJhDLtIfLYp0JHEc9FiZhPUerr4dQ== From: "Aaron M. Brown" To: devel@lists.libvirt.org Subject: [PATCH v1] virBitmapNextClearBit: Correct virBitmapNextClearBit function header comment Date: Tue, 22 Jul 2025 13:59:49 -0400 Message-Id: <20250722175949.91137-1-aaronmbr@linux.ibm.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ki0FS1NqqmBRDxd0cKoSoqwkkHRGZUSV X-Authority-Analysis: v=2.4 cv=De8XqutW c=1 sm=1 tr=0 ts=687fd197 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=y6lGjT5iJYnGfkwFOqQA:9 X-Proofpoint-GUID: ki0FS1NqqmBRDxd0cKoSoqwkkHRGZUSV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIyMDE0OSBTYWx0ZWRfX8BfBfxoo/PaL 1XrvjJEA3uUKSlTB/jUTaQojk8l7k8gjbZs2U7Wuy+7QHmvxpDkGjNcorwtAbXZr+JxZqTHhtVE Cbl6y5cv2OheMKIyTyANLFYT3TVQUL1nhP3bwxxGHYSDPEI3RHAV8BSOvDn5D9odcXP7084spxa vyVDdUCBIS2biGBpwt4dQ9bpQwZhROhQmBzt3x1mjEvRowWAX9vWvTYS090RTNVMntx4yuqJPho SnObtGvJ9NOPyEGv9Qt05WixWB8b2gaJXyS1arYjzOnOQQbLZD5/zz1CjmbFpCkmG5cLxziSzLB J9fa7J8f5ZFJVREeNI4EGgXMI6rlYs7f3oladW7INt+KfPnkDM+sPBvn2lhGKyyXgD/jJsKfd55 xgUieT6i0aOnzO3yjfPvE+58UqTK407jh6IEMr/2ac5Nj61+vUqQy5qbfYQZq31UGcH1uuIh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-22_02,2025-07-21_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=512 suspectscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507220149 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SVWDWAVE2Y3NQPEGRQO72MRXYJTFH5GD X-Message-ID-Hash: SVWDWAVE2Y3NQPEGRQO72MRXYJTFH5GD X-MailFrom: aaronmbr@linux.ibm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1753207222582116600 Content-Type: text/plain; charset="utf-8" This patch corrects the header comment for virBitmapNextClearBIt. Currently, the header comment reads: `@pos can be -1 to search for the first set bit.` However, this statement is false. We can prove this by referencing the virbitmaptest functions, i.e virbitmaptest.c:223, in which i =3D 0 if (virBitmapNextClearBIt(bitmap, -1) !=3D 0) return -1 Because this is a zero set, this case would fail if the header statement wa= s true as is. Signed-off-by: Aaron M. Brown Reviewed-by: Michal Privoznik --- src/util/virbitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 8a3f33c806..1a3e75671c 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -948,7 +948,7 @@ virBitmapLastSetBit(virBitmap *bitmap) * @pos: the position after which to search for a clear bit * * Search for the first clear bit after position @pos in bitmap @bitmap. - * @pos can be -1 to search for the first set bit. Position starts + * @pos can be -1 to search for the first clear bit. Position starts * at 0. * * Returns the position of the found bit, or -1 if no bit found. --=20 2.39.5 (Apple Git-154)