From nobody Tue Sep 9 19:05:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1752683655575305.1919559757505; Wed, 16 Jul 2025 09:34:15 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9432D1323; Wed, 16 Jul 2025 12:34:14 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 939FC1574; Wed, 16 Jul 2025 12:31:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4D25314DD; Wed, 16 Jul 2025 12:31:41 -0400 (EDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 10BD214E3 for ; Wed, 16 Jul 2025 12:31:29 -0400 (EDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ae0df6f5758so8810966b.0 for ; Wed, 16 Jul 2025 09:31:28 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82645fdsm1228404866b.97.2025.07.16.09.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jul 2025 09:31:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752683487; x=1753288287; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uvutzzVEOd0WARZ66+7RgkoTwI6Ojyr4hfe3QcXxpU0=; b=Qfw9f9XopKgtRpclm+inzWlLsK8SBOdxFq41KEDCN73lJs4u4g93/GMbTn0+mBc8zy mW7O5z2yXnNptAPg1ONn3dJzbB2TReOcaowzaOfwqWQwG61sLiVTbsn0gBT2zIRPqnIh bsRfaFio4mnn43W8QP5fu2TTVhfSAe5qId6y7rsXvFZIeuJA190Z7GYNpsNA7jiWVEqE NPx5m0xt02SoOamCPfhF+8D5uDIm5XTEZatCLzjjY7PESvjv3bx0wfP4q74Q0CRapJjM 5tvjksLyOpHCS/Bp0AWOVO8GNAcxNhHSjNWpHRGFOLa8Q0Fv5x259E3YGNnrxF6mKZbg JxVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752683487; x=1753288287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uvutzzVEOd0WARZ66+7RgkoTwI6Ojyr4hfe3QcXxpU0=; b=hYvzs2Hc35OsFmOSHMl5JiNft1fNN4mv8p0pBikV9WTbhtYVvonq1chaD0PVelVzpU lWyvibnLjRL97FDPnHVMVcovrLQoTAdDGWAQUrC5E5lutldwoEoZ2TDNHLpL+CIWG7gH 54rOUiLoEJ5s/11D4CLmiMoSG6RMpKKhguKZjozpvQS1ANrdfkjKx2EL26LQW/4w0d5i zrSbO7ZP5HfWHhvJZ6SFAYir2ftKN2jYoMvxDqrAnVPPadeVWDnLUTlTqOWkeY/oq9NX HEZJF2Jx8BJ0gR6eOzWAFDJKw2XHKq+RMfxQweiQC5qHloZGG0VtEr+w+oEB1C/N6/Zw bWpA== X-Gm-Message-State: AOJu0YzSn4YzJEcdgDcHrIrx6SYvxgiJz0tckfrIqFDIrAt+nRhc8FU7 ynvgy78b46Hd4cfF0Y+7ocqULDOKrTLiB0t8OiqBkxCtwoIT/bMQx9ZQ9D/ZpmbOB9k15g== X-Gm-Gg: ASbGncuEnNN1JKywh2jNtRBxz8Yh6QvFSzKo5DqwzwfobBsu3C/Sddu8f7vFV9I/6Wl EceJtRLdjlBG7MVCRmm1Q68V6I8s5M+blhrW7zToPWG0EdPpMlu6UcL68Q0RHZMEK1jJD10lgq9 1dWOtUReiDIDBEjirFUfYgfl8BHyN/GdjrTNxKLIy+HL80fOpie5+uHGsYnQ5XZFcvfe8vTn8P3 cIYTin87vxMQej2WUcdG4zbVUlRwzUUvObM0Sw77HyopNifDNVd9/6yVdDQ05GH3C/GMdAuDlDz KyLzkE6CBUc5TfUkRb8OxdkeAeg892hYH0d6/fASlwX2kVFSo6axutnFktblEI75H9U9iBEFpKE hWfiknlMNB296GwTf/EnmCcBS2y1gfuX0ocE+VjWniXcLtu2oe37aEqioXsdAAgI2FCA2vIs= X-Google-Smtp-Source: AGHT+IH4RHmHG+lFd2ehAiuqiLYz8O3DsHiPxAiCRNHprld8rpwym5TM2BC3qRo1qv1Fre6nhp1Tng== X-Received: by 2002:a17:907:894b:b0:ade:470b:d5ac with SMTP id a640c23a62f3a-ae9ce196ca1mr313536566b.56.1752683487251; Wed, 16 Jul 2025 09:31:27 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 5/5] bhyve: sync error messages Date: Wed, 16 Jul 2025 18:28:47 +0200 Message-ID: <20250716162847.57145-6-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250716162847.57145-1-bogorodskiy@gmail.com> References: <20250716162847.57145-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: B6C6CB4M6KDAHMCEJSESAQIWTK7M423D X-Message-ID-Hash: B6C6CB4M6KDAHMCEJSESAQIWTK7M423D X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1752683656568116600 Content-Type: text/plain; charset="utf-8" Use the same error messages for serial devices validation which are already used in bhyve_domain.c Signed-off-by: Roman Bogorodskiy Reviewed-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 18f65cf757..5757a41e7e 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -171,7 +171,7 @@ bhyveBuildConsoleArgStr(const virDomainDef *def, virCom= mand *cmd) /* bhyve supports 4 ports: com1, com2, com3, com4 */ if (chr->target.port > 3) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("only two serial ports are supported")); + _("Only four serial ports are supported")); return -1; } =20 @@ -190,7 +190,7 @@ bhyveBuildConsoleArgStr(const virDomainDef *def, virCom= mand *cmd) break; default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("only nmdm and tcp console types are supporte= d")); + _("Only 'nmdm' and 'tcp' console types are supp= orted")); return -1; } } --=20 2.49.0