From nobody Wed Sep 10 01:39:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1752663323363337.11870278893866; Wed, 16 Jul 2025 03:55:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5E99C1496; Wed, 16 Jul 2025 06:55:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 114AB138F; Wed, 16 Jul 2025 06:54:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 80812CF9; Wed, 16 Jul 2025 06:54:19 -0400 (EDT) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B0839D33 for ; Wed, 16 Jul 2025 06:54:18 -0400 (EDT) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ae0dad3a179so1080316866b.1 for ; Wed, 16 Jul 2025 03:54:18 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e829d061sm1180627366b.142.2025.07.16.03.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jul 2025 03:54:15 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 006D65F88F; Wed, 16 Jul 2025 11:54:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752663257; x=1753268057; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BuB1ZMI7kjoW2hcwIFccTZ9+4H8jt6BsHwQwTfInE6Y=; b=DrWyii0M7UnbdhTmFLGzV6XiwTQiag+d9oBz4zZ+FysprMQBW8HETz26o2pMcXCp2A iZ8Hn2AsikZFBAw8FoCaT9lei10YRt5BpuBtH743qID6lyx7UMqkX6P0pqioM9lltIPO lGvJkiMSJNDQAWB6MfrjfNGQ34ONufNtUew1PY4+KTtIaxl88N+x8QNL/U1qdnjMCmXG yr25r5CNoI1o2j0ro91mgv2NmpYiduv4G+dVOzjxcHkY43qMm39YNkWmSnAeEdRfLzc/ AwJwxyvCANxJdAsyoZOcAipAPKryw6fo4dEF+pB4SichW51UCBAmR1JWB4tww1ce1YkB vp4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752663257; x=1753268057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BuB1ZMI7kjoW2hcwIFccTZ9+4H8jt6BsHwQwTfInE6Y=; b=mlEBAUP0RLdSwG7RTK2kWJDbXjZj8PCfB109ayo4MfzJsOuQkTFh3Q6AUjiB+HcAld 9kiFzX0vUO0Y3TFpD/BnK3Tz8e/14wvYjr6NIF10HkHzHZB8tBqYvpCcU48L1MmzHq9Z exz5pvaMIwAuPhaEYzyz0kNjsDEgiqbl2uTCseqqnuy5aUtW2b/UZgdYgR5F9L6yqEun Aa1cA787cNEKB2bcXM+2NVDzkAM8ktf/TZLRxOCXcBpXuls3vzqqx1lhvuNPubIvMUy8 19t7i9JqQpewy09e1X8PIbrCNvj9ENE5IYdC+45iMcqUq3s8TJUCGgjUuo+bY+6gjgmL qJiA== X-Forwarded-Encrypted: i=1; AJvYcCUdCKfWg4OiJZtTaPGeDkIJCIcWIaG+MlhL+CjqXgAaT3uLZmJvqKQOEtSLS2hRY1k7NrOqRQ==@lists.libvirt.org X-Gm-Message-State: AOJu0YwOGAsA5neGQnXwhIS+VtwGFUHOoHTvnCEwmIwojrcKBaJrFKyy 0dcPBpb9jWQY6regCI3MSQat4u+mYvmr0Uy+2u24TIfRaCZlTuAp68p5MexaDpbSbBg= X-Gm-Gg: ASbGncvfrShvqptTozUU+MxALNXCV+jCU8KTZm8I6E02FU931r9Q+odIK4Ir+XUzpPa gxq6VHYGWxmiPwG9xG1vdFlS5n6OWQxbG2M3Mdc8d92T8ccSft5coQl6iGG0PdW98l3cyOd5Mq7 nfIt69IWoc1zWKC+HWt1ZpI4kuqXGFnDr3fB17ABt9Tz2rO7FoXnCY2dwbT4lNu1gRgWQSWozlW k0MuNhsuzltuRWqKoMI7BmdabI2h3snAi2nu8glvrRGfwTXRpHz7ik0q4AIVoG8lDw3WNgYpN8A SQEc78Qxup7krDbNPiEF/B2JzKwaU6Rkpqlnn2qcjx785Xts5GF5ofg5Yk3vTdXgITeULYU3UFB 5m1Z0hlwrbCxUBZJxsvYY9FLGUJlyBuqywQ== X-Google-Smtp-Source: AGHT+IEZZN002AZsx8/RaE2WlnZo8/860ASRVez3aQMFeEK9zWni+S6tEaCFJXuHih0Ej9lo2qVidw== X-Received: by 2002:a17:906:cad5:b0:ae9:c47f:1bda with SMTP id a640c23a62f3a-ae9c9b908demr270950666b.59.1752663257522; Wed, 16 Jul 2025 03:54:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 1/6] tests/tcg: special case sparc test cases Date: Wed, 16 Jul 2025 11:54:09 +0100 Message-ID: <20250716105414.2330204-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250716105414.2330204-1-alex.bennee@linaro.org> References: <20250716105414.2330204-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SAPJNUFMA7PBFCFNG3Q2RLVZHV44YITS X-Message-ID-Hash: SAPJNUFMA7PBFCFNG3Q2RLVZHV44YITS X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: Paolo Bonzini , Mark Cave-Ayland , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , devel@lists.libvirt.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Artyom Tarasenko X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1752663325731116600 Content-Type: text/plain; charset="utf-8" Due to an existing bug #1771 we can't run anything we build so we have to suppress the normal multiarch build. As we can't have duplicate build rules we need to copy the bits we need from the normal multiarch Makefile so we can redefine all the run-% rules. For signals and vma-pthread they also need slightly different LDFLAGS to link to the atomic support library. Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/Makefile.target | 9 ++++--- tests/tcg/sparc/Makefile.target | 45 +++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 4 deletions(-) create mode 100644 tests/tcg/sparc/Makefile.target diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index af68f11664..8bcafaaf7b 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -103,9 +103,10 @@ ifeq ($(filter %-softmmu, $(TARGET)),) # then the target. If there are common tests shared between # sub-targets (e.g. ARM & AArch64) then it is up to # $(TARGET_NAME)/Makefile.target to include the common parent -# architecture in its VPATH. However some targets are so minimal we -# can't even build the multiarch tests. -ifneq ($(filter $(TARGET_NAME),aarch64_be),) +# architecture in its VPATH. However some targets are so +# minimal/broken just include directly and skip the common multiarch +# tests Makefile. +ifeq ($(filter $(TARGET_NAME),aarch64_be sparc),$(TARGET_NAME)) -include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.target else -include $(SRC_PATH)/tests/tcg/multiarch/Makefile.target @@ -147,7 +148,7 @@ all: $(TESTS) $(EXTRA_TESTS) RUN_TESTS=3D$(patsubst %,run-%, $(TESTS)) =20 # If plugins exist also include those in the tests -ifeq ($(CONFIG_PLUGIN),y) +ifeq ($(CONFIG_PLUGIN)$(SKIP_PLUGIN_TESTS),y) PLUGIN_SRC=3D$(SRC_PATH)/tests/tcg/plugins PLUGIN_LIB=3D../plugins VPATH+=3D$(PLUGIN_LIB) diff --git a/tests/tcg/sparc/Makefile.target b/tests/tcg/sparc/Makefile.tar= get new file mode 100644 index 0000000000..0b5f9e8b2d --- /dev/null +++ b/tests/tcg/sparc/Makefile.target @@ -0,0 +1,45 @@ +# -*- Mode: makefile -*- +# +# For Sparc we only have multiarch tests - however as everything is +# currently broken we have to duplicate the bits needed from the +# multiarch makefile. This can be removed if we ever get running again +# (or we deprecate the target). +# + +# Compressed copy of tests/tcg/multiarch/Makefile.target +MULTIARCH_SRC=3D$(SRC_PATH)/tests/tcg/multiarch +VPATH +=3D $(MULTIARCH_SRC) +MULTIARCH_SRCS =3D $(notdir $(wildcard $(MULTIARCH_SRC)/*.c)) +ifeq ($(filter %-linux-user, $(TARGET)),$(TARGET)) +VPATH +=3D $(MULTIARCH_SRC)/linux +MULTIARCH_SRCS +=3D $(notdir $(wildcard $(MULTIARCH_SRC)/linux/*.c)) +endif +MULTIARCH_TESTS =3D $(MULTIARCH_SRCS:.c=3D) + +float_%: LDFLAGS+=3D-lm +float_%: float_%.c libs/float_helpers.c + $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< $(MULTIARCH_SRC)/libs/float_helpers.c = -o $@ $(LDFLAGS) + +fnmsub: LDFLAGS+=3D-lm +testthread: LDFLAGS+=3D-lpthread +threadcount: LDFLAGS+=3D-lpthread +munmap-pthread: CFLAGS+=3D-pthread +munmap-pthread: LDFLAGS+=3D-pthread +sigreturn-sigmask: CFLAGS+=3D-pthread +sigreturn-sigmask: LDFLAGS+=3D-pthread +sha1: CFLAGS+=3D-Wno-stringop-overread -Wno-unknown-warning-option + +TESTS +=3D $(MULTIARCH_TESTS) +# End of copy of multiarch/Makefile.target + +# atomic primitives used by these tests need -latomic +signals: LDFLAGS+=3D-lrt -lpthread -latomic +vma-pthread: CFLAGS+=3D-pthread +vma-pthread: LDFLAGS+=3D-pthread -latomic + +# all tests currently broken due to broken CASA +run-%: + $(call skip-test, $*, "CASA is broken (see bug #1771)") + +# we can't even think about plugin tests yet +SKIP_PLUGIN_TESTS=3Dy --=20 2.47.2