From nobody Tue Sep 9 19:03:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1752132379430904.3169089573734; Thu, 10 Jul 2025 00:26:19 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 72E841549; Thu, 10 Jul 2025 03:26:18 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 44FB71291; Thu, 10 Jul 2025 03:22:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CB9C09A9; Thu, 10 Jul 2025 03:22:36 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2B3FB11CF for ; Thu, 10 Jul 2025 03:22:14 -0400 (EDT) Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:13 -0700 Received: from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:11 -0700 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752132134; x=1783668134; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LEJH1g0hsJhcxRTTjADn9iaefjOPkykJit7Nc1KT5fk=; b=DijrZoQfu/CHiJx/oHsAV+HYNjkMm40OYiQXq2hKzfjfPv0+StljT90c 7VKoL44JuJFNji7diodqm0kzOUupnuag+kG83SI7OuGvGK/3qgqm+6MyE grWxDsDibqwi2n/fBiSse46wGgG9Q7S6OGhnd+zxh7MR5fvUhcYnaJPic ZWRJlXLqoelR8QGTWzyo3UV6TSYv/pRzVaSq0p04QLAxMOJpDEawNqoZk md2t4urUd3yPe6MjlCiAVjA48xkcQ23ggsNN11joQfNS8h/GNXfbdtQH0 SXtTSAm1b8HgAqh3qKyYF/66h9qJ974MmxmiESFS6hjhgUWiGUZvH9IZi A==; X-CSE-ConnectionGUID: rF/1FKNBQVOoSVb/d0JHbQ== X-CSE-MsgGUID: 5vfKrlLBTJWazvZQ7vRJuA== X-IronPort-AV: E=McAfee;i="6800,10657,11489"; a="54257030" X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="54257030" X-CSE-ConnectionGUID: KdLEZ8MVQqOC1eO7dYVkqQ== X-CSE-MsgGUID: suynd1RQRhuRRERYRrOM0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="186997159" From: Zhenzhong Duan To: devel@lists.libvirt.org Subject: [PATCH v4 08/23] conf: Validate TDX launchSecurity element mrConfigId/mrOwner/mrOwnerConfig Date: Thu, 10 Jul 2025 03:21:10 -0400 Message-ID: <20250710072127.695558-9-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250710072127.695558-1-zhenzhong.duan@intel.com> References: <20250710072127.695558-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: POHNEEHSZGVMLWGT6PTQZ4VC6WWOI4RH X-Message-ID-Hash: POHNEEHSZGVMLWGT6PTQZ4VC6WWOI4RH X-MailFrom: zhenzhong.duan@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: phrdina@redhat.com, pkrempa@redhat.com, jjongsma@redhat.com, jsuchane@redhat.com, chenyi.qiang@intel.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@intel.com, Zhenzhong Duan X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1752132380903116600 Content-Type: text/plain; charset="utf-8" mrConfigId/mrOwner/mrOwnerConfig are base64 encoded SHA384 digest, can be provided for TDX attestation. Check their decoded lengths to ensure they are 48 bytes. Signed-off-by: Zhenzhong Duan Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/domain_validate.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 7d68ea2478..14c00f3d1b 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1915,10 +1915,13 @@ virDomainDefValidateIOThreads(const virDomainDef *d= ef) } \ } =20 +#define SHA384_DIGEST_SIZE 48 + static int virDomainDefLaunchSecurityValidate(const virDomainDef *def) { virDomainSEVSNPDef *sev_snp; + virDomainTDXDef *tdx; =20 if (!def->sec) return 0; @@ -1933,10 +1936,17 @@ virDomainDefLaunchSecurityValidate(const virDomainD= ef *def) CHECK_BASE64_LEN(sev_snp->host_data, "hostData", 32); break; =20 + case VIR_DOMAIN_LAUNCH_SECURITY_TDX: + tdx =3D &def->sec->data.tdx; + + CHECK_BASE64_LEN(tdx->mrconfigid, "mrConfigId", SHA384_DIGEST_SIZE= ); + CHECK_BASE64_LEN(tdx->mrowner, "mrOwner", SHA384_DIGEST_SIZE); + CHECK_BASE64_LEN(tdx->mrownerconfig, "mrOwnerConfig", SHA384_DIGES= T_SIZE); + break; + case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_SEV: case VIR_DOMAIN_LAUNCH_SECURITY_PV: - case VIR_DOMAIN_LAUNCH_SECURITY_TDX: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: break; } --=20 2.47.1