From nobody Tue Sep 9 19:03:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1752132658402871.6938615011501; Thu, 10 Jul 2025 00:30:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6111E14E9; Thu, 10 Jul 2025 03:30:57 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 236D1CB1; Thu, 10 Jul 2025 03:23:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A5A18127A; Thu, 10 Jul 2025 03:23:21 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9B7C31123 for ; Thu, 10 Jul 2025 03:22:53 -0400 (EDT) Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:51 -0700 Received: from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:48 -0700 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752132174; x=1783668174; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KXKVFqlbubR+7vEywB5xIRuapjiF27y+yEwn3JzJhZo=; b=CRpbrQlVIjP2NKGkey1gO48JBGqR3GL7VcellZO3gr6/ftAd9MTPj0Tz 1C3HzHaD3Kr1gRd24+vp0ApQxVEP+7QW0d/WnuMd9O9e63KWD+rmOxAVQ S6og8QMBTmKIL/FmMCa3vF+/0s37gSU9oDwOFjgnXonw+9B+ojgmpYWb0 IaM0kQD5Ida+ONt/KWiQrT3KpI/W2ExryU/WJD2t7xakJ/Wqa7QktORsl Pfo8a5c/5t2ERjpmTDskIVTAAzgnm7TUsvey2yVOzYGLHvhhzvFrNTN2f sYmINIa9fyyJe7Dzt8u/MgNmmnJnuGCjMZgCE9wLdvB6XfU/ZrcKCyBdt Q==; X-CSE-ConnectionGUID: W/kVCDyPSSeZKJ9AXIYawQ== X-CSE-MsgGUID: YVbthGu4S66XDrEOoKqWOA== X-IronPort-AV: E=McAfee;i="6800,10657,11489"; a="54257178" X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="54257178" X-CSE-ConnectionGUID: hpfyfGNgRc6pbn/QvdNBmg== X-CSE-MsgGUID: 79LDagXPRQqp+uvOZbwaLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="186997228" From: Zhenzhong Duan To: devel@lists.libvirt.org Subject: [PATCH v4 19/23] qemu: Send event VIR_DOMAIN_EVENT_[STOPPED|STARTED] during recreation Date: Thu, 10 Jul 2025 03:21:21 -0400 Message-ID: <20250710072127.695558-20-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250710072127.695558-1-zhenzhong.duan@intel.com> References: <20250710072127.695558-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VZG65VKSNQATQVQOJBQ2QY4IXWJMHMTK X-Message-ID-Hash: VZG65VKSNQATQVQOJBQ2QY4IXWJMHMTK X-MailFrom: zhenzhong.duan@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: phrdina@redhat.com, pkrempa@redhat.com, jjongsma@redhat.com, jsuchane@redhat.com, chenyi.qiang@intel.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@intel.com, Zhenzhong Duan X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1752132660171116600 Content-Type: text/plain; charset="utf-8" For secure guest, FakeReboot kills original QEMU instance and create new one which is quite different from normal guest. To reflect this fact, VIR_DOMAIN_EVENT_[STOPPED|STARTED] are sent to control plane with new introduced reasons VIR_DOMAIN_EVENT_[STOPPED|STARTED]_RECREATION. That would let control plane software understand that these events are from a fake reboot. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Zhenzhong Duan --- examples/c/misc/event-test.c | 6 ++++++ include/libvirt/libvirt-domain.h | 2 ++ src/qemu/qemu_process.c | 10 ++++++++++ tools/virsh-domain-event.c | 6 ++++-- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c index a61dbf4529..bafa929c47 100644 --- a/examples/c/misc/event-test.c +++ b/examples/c/misc/event-test.c @@ -143,6 +143,9 @@ eventDetailToString(int event, case VIR_DOMAIN_EVENT_STARTED_WAKEUP: return "Event wakeup"; =20 + case VIR_DOMAIN_EVENT_STARTED_RECREATION: + return "Recreation"; + case VIR_DOMAIN_EVENT_STARTED_LAST: break; } @@ -227,6 +230,9 @@ eventDetailToString(int event, case VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT: return "Snapshot"; =20 + case VIR_DOMAIN_EVENT_STOPPED_RECREATION: + return "Recreation"; + case VIR_DOMAIN_EVENT_STOPPED_LAST: break; } diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index 3d05ffc5aa..fad58cf409 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -5051,6 +5051,7 @@ typedef enum { VIR_DOMAIN_EVENT_STARTED_RESTORED =3D 2, /* Restored from a state file= (Since: 0.5.0) */ VIR_DOMAIN_EVENT_STARTED_FROM_SNAPSHOT =3D 3, /* Restored from snapsho= t (Since: 0.8.0) */ VIR_DOMAIN_EVENT_STARTED_WAKEUP =3D 4, /* Started due to wakeup even= t (Since: 0.9.11) */ + VIR_DOMAIN_EVENT_STARTED_RECREATION =3D 5, /* Secure guest recreation = (Since: 10.1.0) */ =20 # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_EVENT_STARTED_LAST /* (Since: 0.9.10) */ @@ -5115,6 +5116,7 @@ typedef enum { VIR_DOMAIN_EVENT_STOPPED_SAVED =3D 4, /* Saved to a state file (Si= nce: 0.5.0) */ VIR_DOMAIN_EVENT_STOPPED_FAILED =3D 5, /* Host emulator/mgmt failed= (Since: 0.5.0) */ VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT =3D 6, /* offline snapshot load= ed (Since: 0.8.0) */ + VIR_DOMAIN_EVENT_STOPPED_RECREATION =3D 7, /* Secure guest recreati= on (Since: 10.1.0) */ =20 # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_EVENT_STOPPED_LAST /* (Since: 0.9.10) */ diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7c8f785f32..7467a378ad 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -455,6 +455,7 @@ qemuProcessFakeRebootViaRecreate(virDomainObj *vm) { qemuDomainObjPrivate *priv =3D vm->privateData; virQEMUDriver *driver =3D priv->driver; + virObjectEvent *event =3D NULL; int ret =3D -1; =20 VIR_DEBUG("Handle secure guest reboot: destroy phase"); @@ -471,6 +472,11 @@ qemuProcessFakeRebootViaRecreate(virDomainObj *vm) qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_DESTROYED, VIR_ASYNC_JOB_NONE, = 0); virDomainAuditStop(vm, "destroyed"); =20 + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_REC= REATION); + virObjectEventStateQueue(driver->domainEventState, event); + /* skip remove inactive domain from active list */ qemuProcessEndStopJob(vm); =20 @@ -491,6 +497,10 @@ qemuProcessFakeRebootViaRecreate(virDomainObj *vm) } =20 virDomainAuditStart(vm, "booted", true); + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STARTED, + VIR_DOMAIN_EVENT_STARTED_REC= REATION); + virObjectEventStateQueue(driver->domainEventState, event); =20 qemuDomainSaveStatus(vm); ret =3D 0; diff --git a/tools/virsh-domain-event.c b/tools/virsh-domain-event.c index de33ed9d74..21dbf6e1d2 100644 --- a/tools/virsh-domain-event.c +++ b/tools/virsh-domain-event.c @@ -71,7 +71,8 @@ VIR_ENUM_IMPL(virshDomainEventStarted, N_("Migrated"), N_("Restored"), N_("Snapshot"), - N_("Event wakeup")); + N_("Event wakeup"), + N_("Recreation")); =20 VIR_ENUM_DECL(virshDomainEventSuspended); VIR_ENUM_IMPL(virshDomainEventSuspended, @@ -104,7 +105,8 @@ VIR_ENUM_IMPL(virshDomainEventStopped, N_("Migrated"), N_("Saved"), N_("Failed"), - N_("Snapshot")); + N_("Snapshot"), + N_("Recreation")); =20 VIR_ENUM_DECL(virshDomainEventShutdown); VIR_ENUM_IMPL(virshDomainEventShutdown, --=20 2.47.1