From nobody Tue Sep 9 19:03:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1752132542320238.5001614964192; Thu, 10 Jul 2025 00:29:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5CF231122; Thu, 10 Jul 2025 03:29:01 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A562D152A; Thu, 10 Jul 2025 03:23:10 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 08419134F; Thu, 10 Jul 2025 03:22:57 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 60AEA14B4 for ; Thu, 10 Jul 2025 03:22:35 -0400 (EDT) Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:34 -0700 Received: from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2025 00:22:31 -0700 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752132156; x=1783668156; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iNqFngvfNipxOUJh3jRPEf39KPHNCa0mp+KAZZicbpw=; b=hL8uMfgFTgKUV2w7WzijDvAGo3/z9uZywqzmXiTGcBGtq1uIKlQhty8x T7UddcMublw80gEgDmiuRAkpMcXjUpgDoa6ixydDaSvaER0QlYEYdNbO/ rzAXs314W4Hso4zBoY4lJci/0T7MflEAjFLXNwd5Pb2Txto06g5kLTgvX 30Gx3zkHn01pgiuA2+N06hJEjHlC2FE0R6kjPn371RzvHVQrZsKchwQrj Yxj2R/dKEQTmT9SKfx0ubOp305PZlgJNYoligxnN4axX7jmo16/9ibJAo ZNfkSusfFCSZxyd8KXcvM5ZJ02qtsjq7rzUAUoxQ9yp5/SflHpYwZa295 g==; X-CSE-ConnectionGUID: eDjYBXH+RdKNo3JGSz8b9w== X-CSE-MsgGUID: X2o4IgtuTvS03nSS5EHjDw== X-IronPort-AV: E=McAfee;i="6800,10657,11489"; a="54257119" X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="54257119" X-CSE-ConnectionGUID: 1XSS9iExSxKKZxMJHf1QqA== X-CSE-MsgGUID: pssxRnAqT+GRhKLoLFg1+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,300,1744095600"; d="scan'208";a="186997184" From: Zhenzhong Duan To: devel@lists.libvirt.org Subject: [PATCH v4 14/23] conf: Add Intel TDX Quote Generation Service(QGS) support Date: Thu, 10 Jul 2025 03:21:16 -0400 Message-ID: <20250710072127.695558-15-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250710072127.695558-1-zhenzhong.duan@intel.com> References: <20250710072127.695558-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ID3725D3DFNKH46DJGELQUMHQB2BEKSR X-Message-ID-Hash: ID3725D3DFNKH46DJGELQUMHQB2BEKSR X-MailFrom: zhenzhong.duan@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: phrdina@redhat.com, pkrempa@redhat.com, jjongsma@redhat.com, jsuchane@redhat.com, chenyi.qiang@intel.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@intel.com, Zhenzhong Duan X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1752132542824116600 Content-Type: text/plain; charset="utf-8" Add element "quoteGenerationService" to tdx launch security type. It contains only an optional unix socket address attribute, when omitted, libvirt will use default QGS server address "/var/run/tdx-qgs/qgs.socket". UNIX sockets offer the required functionality with greater security than vsock, so libvirt only provides support for unix socket. XML example: 0x10000001 xxx xxx xxx Signed-off-by: Zhenzhong Duan Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/domain_conf.c | 35 ++++++++++++++++++++++++++++++- src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 9 ++++++++ 3 files changed, 45 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d2f01a9397..3eb3ab35f1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3963,6 +3963,7 @@ virDomainSecDefFree(virDomainSecDef *def) g_free(def->data.tdx.mrconfigid); g_free(def->data.tdx.mrowner); g_free(def->data.tdx.mrownerconfig); + g_free(def->data.tdx.qgs_unix_path); break; case VIR_DOMAIN_LAUNCH_SECURITY_PV: case VIR_DOMAIN_LAUNCH_SECURITY_NONE: @@ -14210,6 +14211,33 @@ virDomainSEVSNPDefParseXML(virDomainSEVSNPDef *def, } =20 =20 +static int +virDomainTDXQGSDefParseXML(virDomainTDXDef *def, xmlXPathContextPtr ctxt) +{ + g_autofree xmlNodePtr *nodes =3D NULL; + xmlNodePtr node; + int n; + + if ((n =3D virXPathNodeSet("./quoteGenerationService", ctxt, &nodes)) = < 0) + return -1; + + if (!n) + return 0; + + if (n > 1) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("only a single QGS element is supported")); + return -1; + } + node =3D nodes[0]; + + def->haveQGS =3D true; + def->qgs_unix_path =3D virXMLPropString(node, "path"); + + return 0; +} + + static int virDomainTDXDefParseXML(virDomainTDXDef *def, xmlXPathContextPtr ctxt) @@ -14229,7 +14257,7 @@ virDomainTDXDefParseXML(virDomainTDXDef *def, def->mrowner =3D virXPathString("string(./mrOwner)", ctxt); def->mrownerconfig =3D virXPathString("string(./mrOwnerConfig)", ctxt); =20 - return 0; + return virDomainTDXQGSDefParseXML(def, ctxt); } =20 =20 @@ -27746,6 +27774,11 @@ virDomainTDXDefFormat(virBuffer *childBuf, virDoma= inTDXDef *def) virBufferEscapeString(childBuf, "%s\n", def->= mrconfigid); virBufferEscapeString(childBuf, "%s\n", def->mrowne= r); virBufferEscapeString(childBuf, "%s\n",= def->mrownerconfig); + if (def->haveQGS) { + virBufferAddLit(childBuf, "qgs_unix_path= ); + virBufferAddLit(childBuf, "/>\n"); + } } =20 =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 51c05a3f18..cf5437f642 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3005,6 +3005,8 @@ struct _virDomainTDXDef { char *mrconfigid; char *mrowner; char *mrownerconfig; + bool haveQGS; + char *qgs_unix_path; }; =20 =20 diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 56dbddcb43..0e13f79e99 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -673,6 +673,15 @@ + + + + + + + + + =20 --=20 2.47.1