From nobody Fri Dec 19 18:47:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1751539211; cv=none; d=zohomail.com; s=zohoarc; b=JbcyjxYSuj4iJlsdCpZ+htZYTU1EgJirb51sTTUuRWJh6OnItpH3XyWlQgM24nPru/d0dr41gX241k+GsXBeDCMBNwWCS6edpGXMmhnvX+gS4WcYwoQlz/ttOVQQdzLmSRzdhZ21l5pVHrB9Oum1qkIgfDWG/g+wDndiFKZXVPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751539211; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=QKL+xchjPF4VqEyo+BU9iWZn03b5HCueMOvc6pfdcf0=; b=ByWV0pjozokuZu4gNZlphgc8iRUDCiMC121sGT81g31WyYT5Pyooq7t4AqaMD6YaxRCL7EGM7CEM7YrFZwJbLk2YJYMGCe+c1oDssbgMEiFaW3JUJpwAsxOFBiCzrRFV3BOIyRJ1UnEzRJtr7fNVwWmC9tzfE8fbGxPj8kL6+GQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1751539211823726.9472453599967; Thu, 3 Jul 2025 03:40:11 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DB10911E8; Thu, 3 Jul 2025 06:40:10 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E6C64E90; Thu, 3 Jul 2025 06:39:52 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4F1E7C6B; Thu, 3 Jul 2025 06:39:49 -0400 (EDT) Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A61B6E7B for ; Thu, 3 Jul 2025 06:39:48 -0400 (EDT) Received: from [130.117.225.5] (helo=vz9-barybin-2.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1uXH2I-0063NZ-3C; Thu, 03 Jul 2025 12:24:40 +0200 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-Greylist: delayed 905 seconds by postgrey-1.37 at lists.libvirt.org; Thu, 03 Jul 2025 06:39:48 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Vf3WQgbNOpZEPBMmq+CnpfhVY9yZQ1gHoQDNJFKGO+E=; b=jSXYcu2Zm3FL 92Gp0v60GERK+Elaa2xtUSDS/pmXOrUUTwnRRxTsiABCWjhI1sqiRSF/viAqBvdMrr2YswOV079eu D+npDQtcDfOUOWMzn/AWVYIFbr/7TQO/B1fXv3yn2FIlw30ic0hF7TEglElSqkxHN7YLsvx/k5i7C JtAn+HrvcrFPcLTXxY7ipMLfzKWhXEJdj9lIsHQ3/Mmm+yUe9wnGKWboyFntYiRKOfSygxuc+Y0cm ONAWJk6dlp4GHFo1AczgIbMADFlQKrzTCYcRaWo5i0FxAUqCbNmhBrJ0T7GQu06eSXg8hSt6uKL1i XYBwDOtplf2LKWfPrUzuHQ==; To: devel@lists.libvirt.org Subject: [PATCH 1/1] qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject() Date: Thu, 3 Jul 2025 13:19:07 +0300 Message-ID: <20250703102434.17975-2-nikolai.barybin@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250703102434.17975-1-nikolai.barybin@virtuozzo.com> References: <20250703102434.17975-1-nikolai.barybin@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZJPBAEKD3KPG75BY65KENBVF4L6H3FRO X-Message-ID-Hash: ZJPBAEKD3KPG75BY65KENBVF4L6H3FRO X-MailFrom: nikolai.barybin@virtuozzo.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: den@openvz.org, Nikolai Barybin X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Nikolai Barybin via Devel Reply-To: Nikolai Barybin X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751539214082116600 Content-Type: text/plain; charset="utf-8" We need to check obj ptr before passing it to virJSONValueObjectHasKey(). If it's NULL it will fail with SIGSEGV. Signed-off-by: Nikolai Barybin Reviewed-by: Peter Krempa --- src/qemu/qemu_qapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index 184c0a965f..a2fef55019 100644 --- a/src/qemu/qemu_qapi.c +++ b/src/qemu/qemu_qapi.c @@ -180,7 +180,7 @@ virQEMUQAPISchemaTraverseObject(virJSONValue *cur, } else { obj =3D virQEMUQAPISchemaObjectGet("members", query, "name", cur); =20 - if (modifier =3D=3D '*' && + if (modifier =3D=3D '*' && obj && !virJSONValueObjectHasKey(obj, "default")) return 0; } --=20 2.43.5