From nobody Sun Dec 14 06:18:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1751253711135666.4001381606853; Sun, 29 Jun 2025 20:21:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3675B139D; Sun, 29 Jun 2025 23:21:50 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4061913BC; Sun, 29 Jun 2025 23:20:05 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4B10912D3; Sun, 29 Jun 2025 23:19:54 -0400 (EDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C41B912D3 for ; Sun, 29 Jun 2025 23:19:53 -0400 (EDT) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55TAkRGQ020698; Mon, 30 Jun 2025 03:19:53 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j7wr6w57-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 03:19:52 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55U1CsCL006928; Mon, 30 Jun 2025 03:19:51 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jvxm3u72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 03:19:51 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55U3Jp4e14811700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Jun 2025 03:19:51 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38A5C5805D; Mon, 30 Jun 2025 03:19:51 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B58E158043; Mon, 30 Jun 2025 03:19:50 +0000 (GMT) Received: from li-d664314c-3171-11b2-a85c-fa8047ef35bd.ibm.com.com (unknown [9.67.116.154]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 30 Jun 2025 03:19:50 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=NChceEjZZBczznPZY GiQ8NJeQ6lKhypcMPqvXfmLrCU=; b=CWRezYAz6GZyIB3WaD8C0bb8YmXjT05AU be5Zi7JZ5GW/mujGzodPAggisLS3YbTbMHbvItG7kUq99tKvUKdlUEfAveoHqtqs Z5+C3QucQay1qcVJFd+Y7AKKvYwu2SBvVKTPeWaapaXPLsI+JmQE3hKCLZMy9qoK tky9plVqVC0MAHUR2FsWIz2zf1fWmEeWGiMcN7wHnlsWy7O4ONGD+Z0eDGZ3V5yb 6olCi2HDtiIczemb+mgei8j1AokCFzf1PxZP7VBME2TMj1hxNFF4BlsQ+2sk5iwq xf8dqnfOaoq5nDTolhBk1+0qIDGEl/TXBvxnxGGR6oyNUdjA12stA== From: Collin Walling To: devel@lists.libvirt.org Subject: [PATCH v5 3/5] qemu: process: refactor deprecated features code Date: Sun, 29 Jun 2025 23:19:28 -0400 Message-ID: <20250630031930.950021-4-walling@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630031930.950021-1-walling@linux.ibm.com> References: <20250630031930.950021-1-walling@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E/PNpbdl c=1 sm=1 tr=0 ts=68620258 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=wPMzV5M0OsZwT5GRDksA:9 X-Proofpoint-GUID: XclWhJnC9o9EwRPjzO7DQkfl1CgAKk1E X-Proofpoint-ORIG-GUID: XclWhJnC9o9EwRPjzO7DQkfl1CgAKk1E X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjMwMDAyNiBTYWx0ZWRfX0xKe/ev/fKQ4 lF03vOD2bfEvBLwPaFA7aK6yuWLigdZ3FzpAac5JzS5mxD1eVICQ1j8sVmAtNYLOsRjgZs0+T1l dBoT+ZRLSUQiRMTzW7Flz+IYOnjWzmS1liRt2Z2LQzEmhI5zVtsdTX1T6ro0sleptnmiWL5Yetn 0VuICaMnApqadKl/gmatERnasZ3TJQ0Am1kEOTh0blQghhGv8vIulH5bxzMBJYDiZ9ub2vLEAfZ ehWUfCChCo3lPeXIrgnMnFVh8nu0GfCF3IzP7xxE8D0ACErmjf583Whq6cGVk7rskcklluj7t/+ p0N6UO4FR14FbzhUGYx0JmKPC6oKC9/O8LksmisYKkFywgPn5fIBnzbCp8L4fDqKvK+J/NH7NrH 22PbywyhXkqS2Tlv3r8S3eRd9SU7wr53E16s5Um70tYuVyTHmgSEA7xMIxe2TdxmmzQcW/gV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-27_05,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=813 lowpriorityscore=0 mlxscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506300026 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FV52CAKHB3VYBUCGMZDFR7LKPDRKQE6V X-Message-ID-Hash: FV52CAKHB3VYBUCGMZDFR7LKPDRKQE6V X-MailFrom: walling@linux.ibm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: pkrempa@redhat.com, fiuczy@linux.ibm.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751253712140116600 Content-Type: text/plain; charset="utf-8" Group up the deprecated features code into a single block to keep things clean; only check if the deprecated_features attribute is present once and then do relevent work. Signed-off-by: Collin Walling Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_process.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e6124b670a..7155742d13 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6448,18 +6448,17 @@ qemuProcessUpdateGuestCPU(virDomainDef *def, &def->os.arch) < 0) return -1; =20 - if (def->cpu->deprecated_feats && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_DEPR= ECATED_PROPS)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("toggling deprecated features for CPU model is un= supported")); - return -1; - } - if (def->cpu->deprecated_feats) { virCPUFeaturePolicy policy =3D VIR_CPU_FEATURE_REQUIRE; if (def->cpu->deprecated_feats =3D=3D VIR_TRISTATE_SWITCH_OFF) policy =3D VIR_CPU_FEATURE_DISABLE; =20 + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_= DEPRECATED_PROPS)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("toggling deprecated features for CPU model i= s unsupported")); + return -1; + } + virQEMUCapsUpdateCPUDeprecatedFeatures(qemuCaps, def->virtType, def->cpu, policy); } --=20 2.49.0