From nobody Wed Dec 17 03:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1750845450400473.2965299333133; Wed, 25 Jun 2025 02:57:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5D17A139F; Wed, 25 Jun 2025 05:57:29 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B93E31500; Wed, 25 Jun 2025 05:51:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D54ED13FE; Wed, 25 Jun 2025 05:51:22 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 669E5146A for ; Wed, 25 Jun 2025 05:50:56 -0400 (EDT) Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2025 02:49:54 -0700 Received: from spr-s2600bt.bj.intel.com ([10.240.192.127]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2025 02:49:48 -0700 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750845057; x=1782381057; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LQbJ5UYuhMqYN978+u7jPbuYtT0iRNFMjWaQ+elgOwI=; b=A4U4bZ7fh4J3Uv0z/rGOVowoPs7Ut3T26O/ET+SyhPRH5Ff0QaQ/7izL mTkifu7JW52jPJcfxHwBcW1nlrAd+xpMzlYjMs7mgzTv8Kjt0fKTHJKzY AFwZdTuj1tUtz6E4I8JZBClOZj1Ry+4pskR/RWnwBfM7Z+3htAOQxqdP2 Tbk5sFeGgeqM01PpHvAbRAWxI6l6DUuKidF3KEEKI+YD7tENnU1fjGOVy DdGGSx+fBNfBY62qG0hKUsL0MDXButDORcsrUvulCB9x14nmptOMJa14C awW8iIPxz+WuKjE+67QJ+DmYbGH0rvqds3Qj8LuMXqYA+1zuNiH7CoCLv g==; X-CSE-ConnectionGUID: F2Wd7GTRTFqZyYTVMMN1vQ== X-CSE-MsgGUID: LH9AoONGSGecRkbr40AzUA== X-IronPort-AV: E=McAfee;i="6800,10657,11474"; a="70680357" X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="70680357" X-CSE-ConnectionGUID: EUT/RyXdQV+x1W88vheL4Q== X-CSE-MsgGUID: 3O+HDL6RTKyc9QzUX7P4fg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="151786622" From: Zhenzhong Duan To: devel@lists.libvirt.org Subject: [PATCH v2 07/21] qemu: Add command line and validation for TDX type Date: Wed, 25 Jun 2025 17:45:19 +0800 Message-Id: <20250625094533.234897-8-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250625094533.234897-1-zhenzhong.duan@intel.com> References: <20250625094533.234897-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PZOOQVF6VHYON2JKC47HT6IRCFF565UR X-Message-ID-Hash: PZOOQVF6VHYON2JKC47HT6IRCFF565UR X-MailFrom: zhenzhong.duan@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: phrdina@redhat.com, pkrempa@redhat.com, jjongsma@redhat.com, jsuchane@redhat.com, chenyi.qiang@intel.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@intel.com, Zhenzhong Duan X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1750845450684116600 Content-Type: text/plain; charset="utf-8" QEMU will provides 'tdx-guest' object which is used to launch encrypted VMs on Intel platform using TDX feature. Command line looks like: $QEMU ... \ -object '{"qom-type":"tdx-guest","id":"lsec0","mrconfigid":"xxx","mrowner= ":"xxx","mrownerconfig":"xxx","attributes":268435457}' \ -machine pc-q35-6.0,confidential-guest-support=3Dlsec0 Signed-off-by: Zhenzhong Duan --- src/conf/domain_conf.h | 5 +++++ src/qemu/qemu_command.c | 27 +++++++++++++++++++++++++++ src/qemu/qemu_validate.c | 12 ++++++++++++ 3 files changed, 44 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index e216c63018..51c05a3f18 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3008,6 +3008,11 @@ struct _virDomainTDXDef { }; =20 =20 +#define VIR_DOMAIN_TDX_POLICY_DEBUG 0x1 +#define VIR_DOMAIN_TDX_POLICY_SEPT_VE_DISABLE 0x10000000 +#define VIR_DOMAIN_TDX_POLICY_ALLOWED_MASK (VIR_DOMAIN_TDX_POLICY_DE= BUG | \ + VIR_DOMAIN_TDX_POLICY_SE= PT_VE_DISABLE) + struct _virDomainSecDef { virDomainLaunchSecurity sectype; union { diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 363bee5c8c..3081636c24 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9945,6 +9945,32 @@ qemuBuildPVCommandLine(virCommand *cmd) } =20 =20 +static int +qemuBuildTDXCommandLine(virCommand *cmd, virDomainTDXDef *tdx) +{ + g_autoptr(virJSONValue) props =3D NULL; + + if (tdx->havePolicy) + VIR_DEBUG("policy=3D0x%llx", tdx->policy); + + if (qemuMonitorCreateObjectProps(&props, "tdx-guest", "lsec0", + "S:mrconfigid", tdx->mrconfigid, + "S:mrowner", tdx->mrowner, + "S:mrownerconfig", tdx->mrownerconfig, + NULL) < 0) + return -1; + + if (tdx->havePolicy && + virJSONValueObjectAdd(&props, "U:attributes", tdx->policy, NULL) <= 0) + return -1; + + if (qemuBuildObjectCommandlineFromJSON(cmd, props) < 0) + return -1; + + return 0; +} + + static int qemuBuildSecCommandLine(virDomainObj *vm, virCommand *cmd, virDomainSecDef *sec) @@ -9963,6 +9989,7 @@ qemuBuildSecCommandLine(virDomainObj *vm, virCommand = *cmd, return qemuBuildPVCommandLine(cmd); =20 case VIR_DOMAIN_LAUNCH_SECURITY_TDX: + return qemuBuildTDXCommandLine(cmd, &sec->data.tdx); case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: virReportEnumRangeError(virDomainLaunchSecurity, sec->sectype); diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 93e191dd13..ef9f326a9b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1414,6 +1414,18 @@ qemuValidateDomainDef(const virDomainDef *def, } break; case VIR_DOMAIN_LAUNCH_SECURITY_TDX: + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_TDX_GUEST)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Intel TDX launch security is not support= ed with this QEMU binary")); + return -1; + } + if (def->sec->data.tdx.havePolicy && + def->sec->data.tdx.policy & ~VIR_DOMAIN_TDX_POLICY_ALLOWED= _MASK) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Only bit0(debug) and bit28(sept-ve-disab= le) are supported intel TDX launch security policy")); + return -1; + } + break; case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: virReportEnumRangeError(virDomainLaunchSecurity, def->sec->sec= type); --=20 2.34.1