From nobody Wed Dec 17 03:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1750845487507277.3792863159654; Wed, 25 Jun 2025 02:58:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8B54A1517; Wed, 25 Jun 2025 05:58:06 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 386441428; Wed, 25 Jun 2025 05:51:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 20BEE14F5; Wed, 25 Jun 2025 05:51:30 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5F700146D for ; Wed, 25 Jun 2025 05:51:00 -0400 (EDT) Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2025 02:49:59 -0700 Received: from spr-s2600bt.bj.intel.com ([10.240.192.127]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2025 02:49:56 -0700 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750845060; x=1782381060; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cmATkZ55MqAus8gjChdVdwBMVAiUjNy4h2zNTSaqRQI=; b=DzCAAbUK1LegpBJyHtOv5B2CY5sBTeT6qqSqzGnxXfsFwOC2kcypM7Ii 5pEWZLWIMJHsg51NSQgRIyaYkwXGhSZGmSPKMNyTuH4M7pVvqTSLxGoy9 bzXhx0UJaDS8lYZB+6v9XNPuL37kr/ZdjxRcO9/oW2Riy5IK5a01HSj/3 xPAKF96kHydRIIJZhyPgWUqioELKPVa9DtOc4ut2wHYkUlurCpKwdEZ9l 5zc8E9xFhTZ1k1R5Flrd4DrMRx5hUylz0MjAiyFiS3W0rL+KCZ7HbxRT9 u486DYt0qd9DEdBonJfVNpgJQnh5zZzANXzlkdnoqnCHFkaxhn/5/e+io A==; X-CSE-ConnectionGUID: MvqO3NDDRxWrQr4Kjy0bbg== X-CSE-MsgGUID: Jrnf9gB9R9u6OiLLKGtomg== X-IronPort-AV: E=McAfee;i="6800,10657,11474"; a="70680368" X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="70680368" X-CSE-ConnectionGUID: 0ATZrGJEQWuUjQdk2A0S5A== X-CSE-MsgGUID: gjmCMIhwQba+DTWjsdBCHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="151786643" From: Zhenzhong Duan To: devel@lists.libvirt.org Subject: [PATCH v2 09/21] qemu: Force special parameters enabled for TDX guest Date: Wed, 25 Jun 2025 17:45:21 +0800 Message-Id: <20250625094533.234897-10-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250625094533.234897-1-zhenzhong.duan@intel.com> References: <20250625094533.234897-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YRNVC5IRE5I6D2NFU4NXFRPQBGJUI37U X-Message-ID-Hash: YRNVC5IRE5I6D2NFU4NXFRPQBGJUI37U X-MailFrom: zhenzhong.duan@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: phrdina@redhat.com, pkrempa@redhat.com, jjongsma@redhat.com, jsuchane@redhat.com, chenyi.qiang@intel.com, isaku.yamahata@intel.com, xiaoyao.li@intel.com, chao.p.peng@intel.com, Zhenzhong Duan X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1750845489269116600 Content-Type: text/plain; charset="utf-8" TDX guest requires some special parameters to boot, currently: "kernel_irqchip=3Dsplit" "pmu!=3Don" "smm!=3Don" "-bios" If not specified explicitly, QEMU should configure this option implicitly when start a TDX guest. Signed-off-by: Zhenzhong Duan Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index ef9f326a9b..adba3e4a89 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1425,6 +1425,38 @@ qemuValidateDomainDef(const virDomainDef *def, _("Only bit0(debug) and bit28(sept-ve-disab= le) are supported intel TDX launch security policy")); return -1; } + if (def->features[VIR_DOMAIN_FEATURE_IOAPIC] =3D=3D VIR_DOMAIN= _IOAPIC_KVM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Intel TDX launch security needs split ke= rnel irqchip")); + return -1; + } + /* Current KVM doesn't support PMU for TD guest. It returns + * error if TD is created with PMU bit being set in attributes. + * By default, QEMU disable PMU for TD guest. + */ + if (def->features[VIR_DOMAIN_FEATURE_PMU] =3D=3D VIR_TRISTATE_= SWITCH_ON) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Intel TDX launch security is not support= ed with PMU enabled")); + return -1; + } + /* TDX doesn't support SMM and VMM cannot emulate SMM for TDX = VMs + * because VMM cannot manipulate TDX VM's memory. + * By default, QEMU disable SMM for TD guest. + */ + if (def->features[VIR_DOMAIN_FEATURE_SMM] =3D=3D VIR_TRISTATE_= SWITCH_ON) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Intel TDX launch security is not support= ed with SMM enabled")); + return -1; + } + /* TDVF(OVMF) needs to run at private memory for TD guest. TDX= cannot + * support pflash device since it doesn't support read-only pr= ivate memory. + * Thus load TDVF(OVMF) with -bios option for TDs. + */ + if (def->os.loader && def->os.loader->type =3D=3D VIR_DOMAIN_L= OADER_TYPE_PFLASH) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Intel TDX launch security is not support= ed with pflash loader")); + return -1; + } break; case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: --=20 2.34.1