From nobody Tue Sep 9 23:35:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1749821856625228.38603405653964; Fri, 13 Jun 2025 06:37:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8F2BDD76; Fri, 13 Jun 2025 09:37:35 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6DD6813B8; Fri, 13 Jun 2025 09:33:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 786A91242; Fri, 13 Jun 2025 09:33:30 -0400 (EDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 488E9DA0 for ; Fri, 13 Jun 2025 09:33:27 -0400 (EDT) Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55DAKmJF030944 for ; Fri, 13 Jun 2025 13:33:26 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 474dv819u2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jun 2025 13:33:25 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55DCLDKU019602 for ; Fri, 13 Jun 2025 13:33:25 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4752f2sveq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jun 2025 13:33:25 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55DDXNW715991518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Jun 2025 13:33:23 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 136505805A; Fri, 13 Jun 2025 13:33:23 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE0F258073; Fri, 13 Jun 2025 13:33:22 +0000 (GMT) Received: from li-d664314c-3171-11b2-a85c-fa8047ef35bd.ibm.com.com (unknown [9.67.26.12]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 13 Jun 2025 13:33:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=SYPgz7y7GoIPtsebg 3tsbA+EaG0Tm5KfBtd+NfXtpcc=; b=qJ/XLztg8WyEwuB2AIZHHiBQPpHwfo2OF 3wm1+4fe4tOW2K5aID6kPxy4VEjyw6aT8Q2jaFKOtdFRE6PQv54MeYAa45ratzUf NtHsBkf1hdl8hIk09AZ2CKZEuiDTB9yHLD4PFCC37NAp0l+kpepvNv2JjDGSF7ev nF4a8jsavf7pC3TAIu/SjB2cm/7+kInZB8xjJ80nZ8GL9DK2Z9KIl4POR1gS1vBo EqGErxzfKHKRynlHunOXdvKAzxrPbBixEe4rkff4spEZZA+DK79454EYJvoej1zq AxNYf9BANTYozncIiCvbNfX3FZlof883Y4UGR/KLF1QPUnpFjXmbw== From: Collin Walling To: devel@lists.libvirt.org Subject: [PATCH v4 5/5] tests: new qemuxmlactive tests for s390x Date: Fri, 13 Jun 2025 09:33:15 -0400 Message-ID: <20250613133315.41095-6-walling@linux.ibm.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250613133315.41095-1-walling@linux.ibm.com> References: <20250613133315.41095-1-walling@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2Lid2XEoc3FXQKWGGg0ZcNYnDzWFvhAz X-Proofpoint-GUID: 2Lid2XEoc3FXQKWGGg0ZcNYnDzWFvhAz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEzMDA5NyBTYWx0ZWRfX0XfzwsBXMHYB 7rrpQPvXCrZhc3PPNY6RO+NCihRqmAMeWykR+T2fsZ9rKxz7Emo0u68YFvg8ktrRgvWFQkGqi3r IhiPmOqYUHTFatx0cqnlro3bNrZB7Kfbg+dbmAJUFMQN0RH19i/8Q0fasrIARND7WrDt+Dtx1cs hXLGlkuib9ofU79495EBAJTRHwrgF5BRn+lqzpW1T7mcZky33UCk4FQSK3DIkXPufAyV2hm9+B1 newoYIwPsLLIcDHHaF22NeEaWJJnWf78u5hwnvgjS19XE/xZsxq2yQ/CinbFznx/pRVCDp0R9vP 2sD2JdtQdXy1pHVRJe5n5kjfg4rmbk/R4Q+ue/lpoZX4zDGrXzQPhqAkdARHnFZtc/z/Os244tX VCImt5PRWrmRBcgmcJL4BOJBCMds+xK7EUFowTjKGh1Qw1Lg70r4VHu6XIhDnAVR6TVqz9kH X-Authority-Analysis: v=2.4 cv=CfMI5Krl c=1 sm=1 tr=0 ts=684c28a6 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=BDJYt16Id4nyBWKYUj8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-13_01,2025-06-12_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506130097 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Y5SP7KNMA5AYMWIKXYAX2JAE76HMVB46 X-Message-ID-Hash: Y5SP7KNMA5AYMWIKXYAX2JAE76HMVB46 X-MailFrom: walling@linux.ibm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Boris Fiuczynski X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749821857806116600 Content-Type: text/plain; charset="utf-8" From: Boris Fiuczynski Add tests for active/inactive XML with deprecated_features attribute. Note that deprecated_features is not set by default when the attribute is absent while running the active/inactive tests. The active XML should contain the attribute, but it doesn't. This is because the method introduced in the previous patch to check the configured default behavior for the attribute does not get called at all -- just the method virDomainDefCheckABIStability is called. Therefore the test's expected file qemuxmlactive2xmldata/cpu-model-deprecated-features-none-active.s390x-lates= t.xml should really contain deprecated_features=3D'off'. However, due to the config method not being hit, the attribute has to be omitted to ensure the test passes. Some coverage is handled via the qemuxmlconf test, which will check the expected args to see the respective features disabled when the domain XML does not contain the attribute. Signed-off-by: Boris Fiuczynski Reviewed-by: Collin Walling --- ...ated-features-none-active.s390x-latest.xml | 25 +++++++++++++++ ...ed-features-none-inactive.s390x-latest.xml | 25 +++++++++++++++ ...cated-features-off-active.s390x-latest.xml | 25 +++++++++++++++ ...ted-features-off-inactive.s390x-latest.xml | 25 +++++++++++++++ ...ecated-features-on-active.s390x-latest.xml | 25 +++++++++++++++ ...ated-features-on-inactive.s390x-latest.xml | 25 +++++++++++++++ tests/qemuxmlactivetest.c | 11 +++++-- ...deprecated-features-none.s390x-latest.args | 32 +++++++++++++++++++ ...-deprecated-features-none.s390x-latest.xml | 25 +++++++++++++++ .../cpu-model-deprecated-features-none.xml | 15 +++++++++ tests/qemuxmlconftest.c | 1 + 11 files changed, 232 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-none-active.s390x-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-none-inactive.s390x-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-off-active.s390x-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-off-inactive.s390x-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-on-active.s390x-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/cpu-model-deprecated-featur= es-on-inactive.s390x-latest.xml create mode 100644 tests/qemuxmlconfdata/cpu-model-deprecated-features-non= e.s390x-latest.args create mode 100644 tests/qemuxmlconfdata/cpu-model-deprecated-features-non= e.s390x-latest.xml create mode 100644 tests/qemuxmlconfdata/cpu-model-deprecated-features-non= e.xml diff --git a/tests/qemuxmlactive2xmldata/cpu-model-deprecated-features-none= -active.s390x-latest.xml b/tests/qemuxmlactive2xmldata/cpu-model-deprecated= -features-none-active.s390x-latest.xml new file mode 100644 index 0000000000..bed2ea8552 --- /dev/null +++ b/tests/qemuxmlactive2xmldata/cpu-model-deprecated-features-none-active= .s390x-latest.xml @@ -0,0 +1,25 @@ + + guest + 22782664-6b93-46bf-9595-317220dd2d1c + 219100 + 219100 + 1 + + hvm + + + + + destroy + restart + destroy + + /usr/bin/qemu-system-s390x + +