From nobody Tue Sep 9 23:26:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1749470524; cv=none; d=zohomail.com; s=zohoarc; b=nbNhC30JMMctldrzKjdkQOsKqkkIupcCs336sGJvkXh8aVaOa/dgavCPHO7qpjIBHEj7YFngVgyMiJqh6eQb2FbJMTKMYE67hU8Tg8pB04bd2UoozEhONNlCZ7bHA2rYVaiSzcpz99aP7L9cGbxa9+2lWqFmbetIk7dEZWLfCt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749470524; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Fm7DWCz7AqQkWYSfvi9l9Xp4O1Kinhsdn/mVZxIW7Os=; b=VvLcIHtLIoQ16vNUxHv59brTlQjXfwA1SSPQ2anb91qVmgO9NdTaipxtHN2XHL+j5p+kAuv34f9Pmkb5ysaQMjTXncXmtnbWlAdoSICg6GhHyDhf2hydUpM0N70b0nvMXQQdIQ4+nI0Zld/7sJfNOeQBlaOb7fmu/x3x2f9L/YQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1749470524225555.9830755194398; Mon, 9 Jun 2025 05:02:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 35BF811AC; Mon, 9 Jun 2025 08:02:03 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B67BF11B4; Mon, 9 Jun 2025 08:01:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 95AC011B4; Mon, 9 Jun 2025 08:01:42 -0400 (EDT) Received: from relay0.allsecuredomains.com (relay0.allsecuredomains.com [51.68.204.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 138D81185 for ; Mon, 9 Jun 2025 08:01:42 -0400 (EDT) Received: from [81.174.144.187] (helo=custard.lan) by relay0.allsecuredomains.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uObC7-000L0a-MF; Mon, 09 Jun 2025 12:01:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=seoss.co.uk ; s=asd201810; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oYMnqkIq85HDY/IlFhsr3jxN3tRmFE4W6SQEaChGQNw=; b=LlxN57JIt0c9Oi2m4BMyDMwpDn i3TSZkh2LsKhi0Z8nOj4nWHkq+jGLA/M8ut3h5MskqzN1eCEjdXtGoIdNuPE4wBFzmuscOJVnvSc6 FAaJS5HPyDzkyE7eoVFmUDmByyUomropG/GYymqfIvk3m/w876+e5Z2X1b1w5OFl5eKU=; To: tim@seoss.co.uk, devel@lists.libvirt.org Subject: [PATCH v3 1/2] virt-aa-helper: refactor for readability Date: Mon, 9 Jun 2025 12:59:05 +0100 Message-ID: <20250609115903.796595-5-tim@seoss.co.uk> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250609115903.796595-2-tim@seoss.co.uk> References: <20250609115903.796595-2-tim@seoss.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JLQ547I7W2SUNWOXKBRBY4KXQG4DC6Z5 X-Message-ID-Hash: JLQ547I7W2SUNWOXKBRBY4KXQG4DC6Z5 X-MailFrom: tim@seoss.co.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Tim Small via Devel Reply-To: Tim Small X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749470527788116600 Content-Type: text/plain; charset="utf-8" From: Tim Small Signed-off-by: Tim Small --- Changes since earlier patch versions: Since V2: . Fix missing from line in patch body . Add this narrative Since V1: . Formatting - ref Peter Krempa's feedback src/security/virt-aa-helper.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index e3802c18be..6481e9cfd7 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1134,10 +1134,10 @@ get_files(vahControl * ctl) } =20 for (i =3D 0; i < ctl->def->nnets; i++) { - if (ctl->def->nets[i] && - ctl->def->nets[i]->type =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUS= ER && - ctl->def->nets[i]->data.vhostuser) { - virDomainChrSourceDef *vhu =3D ctl->def->nets[i]->data.vhostus= er; + virDomainNetDef *net =3D ctl->def->nets[i]; + + if (net && net->type =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUSER && net->= data.vhostuser) { + virDomainChrSourceDef *vhu =3D net->data.vhostuser; =20 if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw", vhu->type) !=3D 0) --=20 2.47.2