From nobody Tue Sep 9 23:37:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748863061; cv=none; d=zohomail.com; s=zohoarc; b=ms93qIs9NAZy+pYesf9EjYXzjoR0udDXCIhLFh6poXAoiIYvpPojJQRDG9Us1MHdICEYAfSd3hu8qDOWYEGJLviKW45Dkh04fTNNoW8DiepgciFSapYvbPwfZZU5w+PwsIry1zSQFfwhKrZ+l/tT0luMLPYJpkq+4tk0Z1ZO/f0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748863061; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=9kClDq/FsI2+KDgStVNYVntEhEuyH9TP6eIAvc/XsjQ=; b=Zz55mbRCk3RvtfVPa9Va/FErzTcH35Ic4VelDG87bhsVwg3l4EXStUsAVdUx/wnLCezuZvasUOyV3IVDyCbn/aIa6G3+qZQ9X26YbgtL6HuMDinKd8OLra3yVa3zCFAqibe2/BT43x6Y4BxuDWZO9nMEh1o/B//wQzwY+/AfxDE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748863061312604.3702108127229; Mon, 2 Jun 2025 04:17:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 51EC713EA; Mon, 2 Jun 2025 07:17:40 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3178815B4; Mon, 2 Jun 2025 07:15:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C4F0815F0; Mon, 2 Jun 2025 07:15:43 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 507E11571 for ; Mon, 2 Jun 2025 07:15:32 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-qdqFd7YYNSC9cJIJouLiSQ-1; Mon, 02 Jun 2025 07:15:30 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 261111956087 for ; Mon, 2 Jun 2025 11:15:30 +0000 (UTC) Received: from kshcheti-thinkpadp1gen4i.tpbc.com (unknown [10.43.2.246]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C0B3C1800359; Mon, 2 Jun 2025 11:15:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748862932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mJw3RzBUcId9iWQPuJ/7XN5bI05aWoUQ518ot8jre40=; b=ZGOyMvnBEw6o3fR3+EXTj3kCABEMZPQOeYpfBN8BTjTpPcWbYr6alhTkTqLAMnkwDpgShN SrwZnBnmQL1/cszg80aamvGpWWHAmHK3lHrd4IFlWS21VCaEjg5nJg0JHTX/04oQdTJyZN f6sE73p+MZltC1rMJApH4UtMKw8JeVw= X-MC-Unique: qdqFd7YYNSC9cJIJouLiSQ-1 X-Mimecast-MFC-AGG-ID: qdqFd7YYNSC9cJIJouLiSQ_1748862930 To: devel@lists.libvirt.org Subject: [PATCH 4/4] conf: desktop graphics remove unused option Date: Mon, 2 Jun 2025 12:39:43 +0200 Message-ID: <20250602111504.387917-5-kshcheti@redhat.com> In-Reply-To: <20250602111504.387917-1-kshcheti@redhat.com> References: <20250602111504.387917-1-kshcheti@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nRypKbhI0yrVJt_baRp-NDuxdBaLO2yrIurifwkvOk0_1748862930 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3PK2D5ARBQ4SC4EJM4B5VHCB7ULC2CZS X-Message-ID-Hash: 3PK2D5ARBQ4SC4EJM4B5VHCB7ULC2CZS X-MailFrom: kshcheti@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Kirill Shchetiniuk X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Kirill Shchetiniuk via Devel Reply-To: Kirill Shchetiniuk X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748863063287116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Kirill Shchetiniuk Previously, the 'desktop' graphics configuration contained the 'fullscreen' option which was never used, removed the unused option. Signed-off-by: Kirill Shchetiniuk --- docs/formatdomain.rst | 5 ++--- src/conf/domain_conf.c | 17 ++--------------- src/conf/domain_conf.h | 1 - src/conf/schemas/domaincommon.rng | 5 ----- 4 files changed, 4 insertions(+), 24 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 8753ee9c23..9940b2e38f 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -6697,7 +6697,7 @@ interaction with the admin. - + @@ -6878,8 +6878,7 @@ interaction with the admin. ``desktop`` This value is reserved for VirtualBox domains for the moment. It dis= plays a window on the host desktop, similarly to "sdl", but using the Virt= ualBox - viewer. Just like "sdl", it accepts the optional attributes ``displa= y`` - and ``fullscreen``. + viewer. Just like "sdl", it accepts the optional attribute ``display= ``. =20 ``egl-headless`` :since:`Since 4.6.0` This display type provides support for an OpenGL accelerated display diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 201a4ded8b..be70ec3b96 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11961,20 +11961,11 @@ virDomainGraphicsDefParseXMLRDP(virDomainGraphics= Def *def, } =20 =20 -static int +static void virDomainGraphicsDefParseXMLDesktop(virDomainGraphicsDef *def, xmlNodePtr node) { - virTristateBool fullscreen; - - if (virXMLPropTristateBool(node, "fullscreen", VIR_XML_PROP_NONE, - &fullscreen) < 0) - return -1; - - virTristateBoolToBool(fullscreen, &def->data.desktop.fullscreen); def->data.desktop.display =3D virXMLPropString(node, "display"); - - return 0; } =20 =20 @@ -12260,8 +12251,7 @@ virDomainGraphicsDefParseXML(virDomainXMLOption *xm= lopt, goto error; break; case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: - if (virDomainGraphicsDefParseXMLDesktop(def, node) < 0) - goto error; + virDomainGraphicsDefParseXMLDesktop(def, node); break; case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: if (virDomainGraphicsDefParseXMLSpice(def, node, ctxt, flags) < 0) @@ -26998,9 +26988,6 @@ virDomainGraphicsDefFormatDesktop(virBuffer *attrBu= f, virDomainGraphicsDef *def) { virBufferEscapeString(attrBuf, " display=3D'%s'", def->data.desktop.di= splay); - - if (def->data.desktop.fullscreen) - virBufferAddLit(attrBuf, " fullscreen=3D'yes'"); } =20 static int diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index c909cfba3f..5e02c15ed5 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2049,7 +2049,6 @@ struct _virDomainGraphicsDef { } rdp; struct { char *display; - bool fullscreen; } desktop; struct { int port; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 5597d5a66b..81afa10083 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -4573,11 +4573,6 @@ - - - - - --=20 2.49.0