From nobody Tue Sep 9 23:41:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174875659853362.74028553239168; Sat, 31 May 2025 22:43:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 984101449; Sun, 1 Jun 2025 01:43:17 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3F821143F; Sun, 1 Jun 2025 01:41:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 88FAB1387; Sun, 1 Jun 2025 01:41:53 -0400 (EDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5F6941298 for ; Sun, 1 Jun 2025 01:41:47 -0400 (EDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-acacb8743a7so611974266b.1 for ; Sat, 31 May 2025 22:41:47 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb35af4456sm399732266b.182.2025.05.31.22.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:41:44 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748756506; x=1749361306; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=nQLoruUvfqSuIDfq/ihituUvORXhxIS+Mi2ya8GVsoxDROSznPmref+thYpW5ssYyk YSRmNWfCLc0VQRpwveFocsB5uDo8ayAZksSF0Cr/IW2yGX7fcIrc+Xfk4BRf4XDK5FHY UBv6jkihYxl4rfTwZ0GGd5wz5t5R8Kjd/BymQy6jKpODp1R66a2ZIVmgscSfvTpr+/BN i5FoevmCC75QDXbSP9bE8lLtCoZzMHI4HRs74lJG7zUTCIGhiUopRKv9nIo1/P57Cyy/ zYe3tbiEIUo07z9g87oqoRE5vptORZNj0RArZKd4KUgCeO+jBHfAfi9gXS3dpzN1gcvH R+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748756506; x=1749361306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=TyjIHV40QqxwptYD3mcMTfkXamQwVgj3LonMtqUUaoiU4A0RKKsdC/INn0lKB8t3bC 4AqsABxzT8mTFk8oeNuKEsACpcsg18ZSi1N3A0O+/O0Ob9rVGmxNbMIyU1Zh2wyTqiO4 lA7COO98c494PPD5D7oISkV+SF3uMGeptuz3KFnyEbRs9ehWQmp9kmVDTIhtJXJs6XlV jvyhrSuCt8dLeMi/czuJVAtbBG4zTbt5/ZlusMR0Due2KLi9HJz4YmfMc6iXmARSvFjT uNtiEUYQfFkMDoZhfP67nFyEww6mIxKX/bLV8MUc8YBc4tPss8K1w+hypzRHmqxdDW6Y s0Eg== X-Gm-Message-State: AOJu0YyP0bPnWeJRzDJvEsReP3NBSTKqAHrbGbczUDTH1KL1w0VSUqSw lcTH1Tiy3iC99aLhnQJ6ueUo1vx88FFFllT3Otue8OmdaSOJYKRtzNtzAX8VxSo6Kxk= X-Gm-Gg: ASbGncuRrdWIDjl38aEJ0jfNyjL22yfrsSqVzzBWhHA5pQVqUsfi1updJOOEJUpDd8S b1iJUczGe8V9whkTuZnpGT1kuyhkFJhIBoHgS1VbjrkMT4b5yWQ0AX50pbnTHsA45oidaVGaGUp twXbYGUaF4wuvvM64rdfy2ibWa6fbl/8O7LT2MRlzMcu0tlsXx6/XqtP9OpZsnxsH1yt/DGrpFE RewZSSgKe+v6464iJzapAZeaFJx1ki7pQNe8VHvogMcMUDhxyVQfX2zvzeTdzxTG2Yr8OkIpVTC 9PYkMkd7qnv4Jz1tDqvLRD6ALD6jYVJysLZS96Dm35fQLQdtJiV3XTMjjn0Kon10XVEe2BjTCZA 7dBtQtiV6np/MuvBUdgumGrNdPz5jLxhm3gs= X-Google-Smtp-Source: AGHT+IGuvC+Me7YJTlYlkG+BmOaMn6wbxWkZMEknimxMxQu1Dws/EKxwRxfxKR+q7phnxRtxDZiRtg== X-Received: by 2002:a17:907:608d:b0:ad8:5595:ce07 with SMTP id a640c23a62f3a-adb32ca4d5emr776241066b.19.1748756505584; Sat, 31 May 2025 22:41:45 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 3/4] bhyve: implement domainMemoryStats Date: Sun, 1 Jun 2025 07:40:25 +0200 Message-ID: <20250601054026.59551-4-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250601054026.59551-1-bogorodskiy@gmail.com> References: <20250601054026.59551-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZVJYGPXXL35K6KCCHPJPL5BOQIHFKABZ X-Message-ID-Hash: ZVJYGPXXL35K6KCCHPJPL5BOQIHFKABZ X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748756600091116600 Content-Type: text/plain; charset="utf-8" Currently, bhyve does not support neither memory ballooning nor reporting guest memory usage. So the following information can be obtained: - RSS of the running process - Memory available to the guest (that is, guest total memory) Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 50 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index e4698b71bf..70e28c7e0b 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -3,6 +3,7 @@ * * Copyright (C) 2014 Roman Bogorodskiy * Copyright (C) 2014-2015 Red Hat, Inc. + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -1658,6 +1659,54 @@ bhyveDomainInterfaceStats(virDomainPtr domain, return ret; } =20 +#define BHYVE_SET_MEMSTAT(TAG, VAL) \ + if (i < nr_stats) { \ + stats[i].tag =3D TAG; \ + stats[i].val =3D VAL; \ + i++; \ + } + +static int +bhyveDomainMemoryStats(virDomainPtr domain, + virDomainMemoryStatPtr stats, + unsigned int nr_stats, + unsigned int flags) +{ + virDomainObj *vm; + unsigned maxmem; + unsigned long long rss; + size_t i =3D 0; + int ret =3D -1; + + virCheckFlags(0, -1); + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (virDomainMemoryStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virProcessGetStatInfo(NULL, NULL, NULL, NULL, &rss, vm->pid, 0) < = 0) + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("cannot get RSS for domain")); + else + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_RSS, rss); + + maxmem =3D virDomainDefGetMemoryTotal(vm->def); + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_AVAILABLE, maxmem); + + ret =3D i; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + +#undef BHYVE_SET_MEMSTAT + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1719,6 +1768,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ + .domainMemoryStats =3D bhyveDomainMemoryStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0