From nobody Tue Sep 9 09:50:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748618150; cv=none; d=zohomail.com; s=zohoarc; b=Oiw096kVYKmbaFhTzn4zUkMV2Z4gFAYkg+P1T9NiZ6o3ov3VFl7gGjZ+4vjtyU5+BQVgKb73CUKIIEg8FkZKxPvDk1V3RCJEHpK8h4tr4AV1k7wOzZ/+UAyfax4L4boZbQsvpkpwf75kwWV2voKJSedd59ry1nybrWKPD0W98qI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748618150; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=jpe5iiNc7mX4r+FEvCUBWpYl34a8h9D22OyNsGH/kdg=; b=laLMF/OrlCRqYTrfYEM7bbLgHlja5kN/wfL9QQ6wjdTPgsbSd7ZwMuOg4RqWQoAOKeFR8XUCdkzxo9ShQEtQjYgJBzraE1OTBjc9StALNw2dw28qrv3LobcUgL8wC4tqysPc/jfPCMM0876Tnmr0cwPxtOWIt1vTzLc+bkjlTno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748618149902611.8669803381022; Fri, 30 May 2025 08:15:49 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C9B481295; Fri, 30 May 2025 11:15:48 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3136611E7; Fri, 30 May 2025 11:15:34 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A12F1CCB; Fri, 30 May 2025 11:15:31 -0400 (EDT) Received: from relay0.allsecuredomains.com (relay0.allsecuredomains.com [51.68.204.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A669111D9 for ; Fri, 30 May 2025 11:15:30 -0400 (EDT) Received: from [81.174.144.187] (helo=custard.lan) by relay0.allsecuredomains.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uL1SC-0000zm-98; Fri, 30 May 2025 15:15:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=seoss.co.uk ; s=asd201810; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Zq598MZ16DkgsGupKwdd3YGa8yPhNA22U+9JQpCjiEA=; b=zhOcv6lpI+HE4yowFTsSWKyYxC 7xAsdDfrwn6stZUmepN+BlPztNlOciOlVTui3aChT48eT8UZZjU36LuKyanHC9BiBt3rmgJigo6hR lFCgpmiBffq25ayUmRWS/lSEg0LgT4O1Ae128TC2oRVGdFuo2PPPRFoHnS08dhJah2cM=; To: devel@lists.libvirt.org Subject: [PATCH v2 1/2] virt-aa-helper: refactor for readability Date: Fri, 30 May 2025 16:12:50 +0100 Message-ID: <20250530151333.463934-4-tim@seoss.co.uk> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250506160020.2118323-1-tim@seoss.co.uk> References: <20250506160020.2118323-1-tim@seoss.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WBW57QG6ERGXIVCC5XP6J3D6QNWTC3LN X-Message-ID-Hash: WBW57QG6ERGXIVCC5XP6J3D6QNWTC3LN X-MailFrom: tim@seoss.co.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Tim Small X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Tim Small via Devel Reply-To: Tim Small X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748618151102116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Small --- src/security/virt-aa-helper.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index e3802c18be..6481e9cfd7 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1134,10 +1134,10 @@ get_files(vahControl * ctl) } =20 for (i =3D 0; i < ctl->def->nnets; i++) { - if (ctl->def->nets[i] && - ctl->def->nets[i]->type =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUS= ER && - ctl->def->nets[i]->data.vhostuser) { - virDomainChrSourceDef *vhu =3D ctl->def->nets[i]->data.vhostus= er; + virDomainNetDef *net =3D ctl->def->nets[i]; + + if (net && net->type =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUSER && net->= data.vhostuser) { + virDomainChrSourceDef *vhu =3D net->data.vhostuser; =20 if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw", vhu->type) !=3D 0) --=20 2.47.2